Re: [PATCH 4/7] dt-bindings: regulator: qcom-labibb: Document soft start properties
Il 10/01/21 18:18, Rob Herring ha scritto:
On Sat, 09 Jan 2021 14:29:18 +0100, AngeloGioacchino Del Regno wrote:
Document properties to configure soft start and discharge resistor
for LAB and IBB respectively.
Signed-off-by: AngeloGioacchino Del Regno
---
.../bindings/regulator/qcom-labibb-regulator.yaml | 8
1 file changed, 8 insertions(+)
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml:
properties:ibb:properties:qcom,discharge-resistor-kohms: 'oneOf' conditional
failed, one must be fixed:
'type' is a required property
Additional properties are not allowed ('default', 'enum' were
unexpected)
Additional properties are not allowed ('default' was unexpected)
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml:
properties:ibb:properties:qcom,discharge-resistor-kohms: 'oneOf' conditional
failed, one must be fixed:
'$ref' is a required property
'allOf' is a required property
300 is not of type 'string'
64 is not of type 'string'
32 is not of type 'string'
16 is not of type 'string'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml:
ignoring, error in schema: properties: ibb: properties:
qcom,discharge-resistor-kohms
warning: no schema found in file:
./Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
See https://patchwork.ozlabs.org/patch/1424112
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
Fixing ASAP.
Re: [PATCH 4/7] dt-bindings: regulator: qcom-labibb: Document soft start properties
On Sat, 09 Jan 2021 14:29:18 +0100, AngeloGioacchino Del Regno wrote:
> Document properties to configure soft start and discharge resistor
> for LAB and IBB respectively.
>
> Signed-off-by: AngeloGioacchino Del Regno
>
> ---
> .../bindings/regulator/qcom-labibb-regulator.yaml | 8
> 1 file changed, 8 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml:
properties:ibb:properties:qcom,discharge-resistor-kohms: 'oneOf' conditional
failed, one must be fixed:
'type' is a required property
Additional properties are not allowed ('default', 'enum' were
unexpected)
Additional properties are not allowed ('default' was unexpected)
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml:
properties:ibb:properties:qcom,discharge-resistor-kohms: 'oneOf' conditional
failed, one must be fixed:
'$ref' is a required property
'allOf' is a required property
300 is not of type 'string'
64 is not of type 'string'
32 is not of type 'string'
16 is not of type 'string'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml:
ignoring, error in schema: properties: ibb: properties:
qcom,discharge-resistor-kohms
warning: no schema found in file:
./Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
See https://patchwork.ozlabs.org/patch/1424112
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
[PATCH 4/7] dt-bindings: regulator: qcom-labibb: Document soft start properties
Document properties to configure soft start and discharge resistor for LAB and IBB respectively. Signed-off-by: AngeloGioacchino Del Regno --- .../bindings/regulator/qcom-labibb-regulator.yaml | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml index 53853ec20fe2..1cdaff66fdb9 100644 --- a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml +++ b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml @@ -22,6 +22,10 @@ properties: type: object properties: + qcom,soft-start-us: +description: Regulator soft start time in microseconds. +enum: [200, 400, 600, 800] +default: 200 interrupts: maxItems: 1 @@ -35,6 +39,10 @@ properties: type: object properties: + qcom,discharge-resistor-kohms: +description: Discharge resistor value in KiloOhms. +enum: [300, 64, 32, 16] +default: 300 interrupts: maxItems: 1 -- 2.29.2
