Re: [PATCH 4/9] serial: stm32: fix pio transmit timeout
Hi Greg, On 07/30/2017 04:32 PM, Greg Kroah-Hartman wrote: > On Thu, Jul 13, 2017 at 03:08:28PM +, Bich HEMON wrote: >> From: Gerald Baeza>> >> 100µs was too short for low speed transmission >> (9600bps) >> >> Signed-off-by: Gerald Baeza >> Signed-off-by: Bich Hemon >> --- >> drivers/tty/serial/stm32-usart.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > This patch did not apply :( > I have rebased the patch on top of your tty-next branch . Please drop this patch as I will send you a new version. Thx, Bich
Re: [PATCH 4/9] serial: stm32: fix pio transmit timeout
Hi Greg, On 07/30/2017 04:32 PM, Greg Kroah-Hartman wrote: > On Thu, Jul 13, 2017 at 03:08:28PM +, Bich HEMON wrote: >> From: Gerald Baeza >> >> 100µs was too short for low speed transmission >> (9600bps) >> >> Signed-off-by: Gerald Baeza >> Signed-off-by: Bich Hemon >> --- >> drivers/tty/serial/stm32-usart.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > This patch did not apply :( > I have rebased the patch on top of your tty-next branch . Please drop this patch as I will send you a new version. Thx, Bich
Re: [PATCH 4/9] serial: stm32: fix pio transmit timeout
On Thu, Jul 13, 2017 at 03:08:28PM +, Bich HEMON wrote: > From: Gerald Baeza> > 100µs was too short for low speed transmission > (9600bps) > > Signed-off-by: Gerald Baeza > Signed-off-by: Bich Hemon > --- > drivers/tty/serial/stm32-usart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This patch did not apply :(
Re: [PATCH 4/9] serial: stm32: fix pio transmit timeout
On Thu, Jul 13, 2017 at 03:08:28PM +, Bich HEMON wrote: > From: Gerald Baeza > > 100µs was too short for low speed transmission > (9600bps) > > Signed-off-by: Gerald Baeza > Signed-off-by: Bich Hemon > --- > drivers/tty/serial/stm32-usart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This patch did not apply :(
[PATCH 4/9] serial: stm32: fix pio transmit timeout
From: Gerald Baeza100µs was too short for low speed transmission (9600bps) Signed-off-by: Gerald Baeza Signed-off-by: Bich Hemon --- drivers/tty/serial/stm32-usart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c index a12d79c..ca61bfe 100644 --- a/drivers/tty/serial/stm32-usart.c +++ b/drivers/tty/serial/stm32-usart.c @@ -202,7 +202,7 @@ static void stm32_transmit_chars_pio(struct uart_port *port) ret = readl_relaxed_poll_timeout_atomic(port->membase + ofs->isr, isr, (isr & USART_SR_TXE), - 10, 100); + 10, 10); if (ret) dev_err(port->dev, "tx empty not set\n"); -- 1.9.1
[PATCH 4/9] serial: stm32: fix pio transmit timeout
From: Gerald Baeza 100µs was too short for low speed transmission (9600bps) Signed-off-by: Gerald Baeza Signed-off-by: Bich Hemon --- drivers/tty/serial/stm32-usart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c index a12d79c..ca61bfe 100644 --- a/drivers/tty/serial/stm32-usart.c +++ b/drivers/tty/serial/stm32-usart.c @@ -202,7 +202,7 @@ static void stm32_transmit_chars_pio(struct uart_port *port) ret = readl_relaxed_poll_timeout_atomic(port->membase + ofs->isr, isr, (isr & USART_SR_TXE), - 10, 100); + 10, 10); if (ret) dev_err(port->dev, "tx empty not set\n"); -- 1.9.1