Re: [PATCH 4.4 00/88] 4.4.168-stable review
On Mon, Dec 17, 2018 at 12:12:09PM -0800, Guenter Roeck wrote: > On Mon, Dec 17, 2018 at 08:08:34PM +0100, Greg Kroah-Hartman wrote: > > > > > > v4.4.167-89-g9c558d7fe359 seemed to be happy. v4.4.167-89-g50a0280f2f7e > > > replaced it and will take a while. > > > > If I read your site right, it passed everything except one qemu test? > > Is that normal? > > > > Kind of. I was playing with that specific build, swapping out the root file > system, and that was broken for a bit. I restarted the test, but for all > practial purposes the build is fine. Wonderful, thanks for letting me know. greg k-h
Re: [PATCH 4.4 00/88] 4.4.168-stable review
On Mon, Dec 17, 2018 at 08:08:34PM +0100, Greg Kroah-Hartman wrote: > > > > v4.4.167-89-g9c558d7fe359 seemed to be happy. v4.4.167-89-g50a0280f2f7e > > replaced it and will take a while. > > If I read your site right, it passed everything except one qemu test? > Is that normal? > Kind of. I was playing with that specific build, swapping out the root file system, and that was broken for a bit. I restarted the test, but for all practial purposes the build is fine. Guenter
Re: [PATCH 4.4 00/88] 4.4.168-stable review
On Mon, Dec 17, 2018 at 05:46:01AM -0800, Guenter Roeck wrote:
> On 12/17/18 1:05 AM, Greg Kroah-Hartman wrote:
> > On Sun, Dec 16, 2018 at 11:58:13PM +, Ben Hutchings wrote:
> > > On Sat, 2018-12-15 at 07:45 -0800, Guenter Roeck wrote:
> > > > On 12/15/18 12:07 AM, Greg Kroah-Hartman wrote:
> > > > > On Fri, Dec 14, 2018 at 06:10:29PM -0800, Guenter Roeck wrote:
> > > > > > On 12/14/18 3:59 AM, Greg Kroah-Hartman wrote:
> > > > > > > This is the start of the stable review cycle for the 4.4.168
> > > > > > > release.
> > > > > > > There are 88 patches in this series, all will be posted as a
> > > > > > > response
> > > > > > > to this one. If anyone has any issues with these being applied,
> > > > > > > please
> > > > > > > let me know.
> > > > > > >
> > > > > > > Responses should be made by Sun Dec 16 11:56:41 UTC 2018.
> > > > > > > Anything received after that time might be too late.
> > > > > >
> > > > > > Build results:
> > > > > > total: 170 pass: 145 fail: 25
> > > > > > Failed builds:
> > > > > > arm:allnoconfig
> > > > > > arm:tinyconfig
> > > > > > arm:efm32_defconfig
> > > > > > blackfin:defconfig
> > > > > > blackfin:BF561-EZKIT-SMP_defconfig
> > > > > > c6x:dsk6455_defconfig
> > > > > > c6x:evmc6457_defconfig
> > > > > > c6x:evmc6678_defconfig
> > > > > > h8300:allnoconfig
> > > > > > h8300:tinyconfig
> > > > > > h8300:edosk2674_defconfig
> > > > > > h8300:h8300h-sim_defconfig
> > > > > > h8300:h8s-sim_defconfig
> > > > > > m68k:allnoconfig
> > > > > > m68k:tinyconfig
> > > > > > m68k:m5272c3_defconfig
> > > > > > m68k:m5307c3_defconfig
> > > > > > m68k:m5249evb_defconfig
> > > > > > m68k:m5407c3_defconfig
> > > > > > microblaze:nommu_defconfig
> > > > > > microblaze:allnoconfig
> > > > > > microblaze:tinyconfig
> > > > > > sh:defconfig
> > > > > > sh:allnoconfig
> > > > > > sh:tinyconfig
> > > > > > Qemu test results:
> > > > > > total: 288 pass: 288 fail: 0
> > > > > >
> > > > > > mm/nommu.c: In function '__get_user_pages_unlocked':
> > > > > > mm/nommu.c:211:49: error: 'write' undeclared (first use in this
> > > > > > function)
> > > > > > mm/nommu.c:211:56: error: 'force' undeclared (first use in this
> > > > > > function)
> > > > > > mm/nommu.c:212:9: warning: passing argument 7 of 'get_user_pages'
> > > > > > from incompatible pointer type [enabled by default]
> > > > > > mm/nommu.c:185:6: note: expected 'struct vm_area_struct **' but
> > > > > > argument is of type 'struct page **'
> > > > > > mm/nommu.c:212:9: error: too many arguments to function
> > > > > > 'get_user_pages'
> > > > > > mm/nommu.c:185:6: note: declared here
> > > > > >
> > > > > > Details are available at https://kerneltests.org/builders/.
> > > > >
> > > > > Ugh, I'll dig through this later on today, we must be missing
> > > > > something
> > > > > with those backports that Ben did...
> > > > >
> > > >
> > > > 69ce144e5c3a ("mm: replace get_user_pages() write/force parameters
> > > > with gup_flags") seems to have missed converting a call of
> > > > get_user_pages().
> > >
> > > Right. This was changed earlier upstream in commit cde70140fed8
> > > "mm/gup: Overload get_user_pages() functions", but I don't think it
> > > makes sense to apply all of that. I'm attaching a minimal patch
> > > (tested with an arm allnoconfig build) which should ideally be inserted
> > > before mm-replace-get_user_pages-write-force-parameters-with-
> > > gup_flags.patch.
> > >
> > > Ben.
> > >
> > > --
> > > Ben Hutchings, Software Developer Codethink Ltd
> > > https://www.codethink.co.uk/ Dale House, 35 Dale Street
> > > Manchester, M1 2HF, United Kingdom
> >
> > > From 0d0afe933f60f5736c984e9171214aa34b18764c Mon Sep 17 00:00:00 2001
> > > From: Ben Hutchings
> > > Date: Sun, 16 Dec 2018 23:50:08 +
> > > Subject: [PATCH] mm/nommu.c: Switch __get_user_pages_unlocked() to use
> > > __get_user_pages()
> > >
> > > Extracted from commit cde70140fed8 "mm/gup: Overload get_user_pages()
> > > functions". This is needed before picking commit 768ae309a961
> > > "mm: replace get_user_pages() write/force parameters with gup_flags".
> > >
> > > Signed-off-by: Ben Hutchings
> > > ---
> > > mm/nommu.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/mm/nommu.c b/mm/nommu.c
> > > index fa1560c218d5..2360546db065 100644
> > > --- a/mm/nommu.c
> > > +++ b/mm/nommu.c
> > > @@ -208,8 +208,8 @@ long __get_user_pages_unlocked(struct task_struct
> > > *tsk, struct mm_struct *mm,
> > > {
> > > long ret;
> > > down_read(>mmap_sem);
> > > - ret = get_user_pages(tsk, mm, start, nr_pages, write, force,
> > > - pages, NULL);
> > > + ret = __get_user_pages(tsk, mm, start, nr_pages, gup_flags, pages,
> > > +NULL, NULL);
> > >
Re: [PATCH 4.4 00/88] 4.4.168-stable review
On 12/17/18 1:05 AM, Greg Kroah-Hartman wrote:
On Sun, Dec 16, 2018 at 11:58:13PM +, Ben Hutchings wrote:
On Sat, 2018-12-15 at 07:45 -0800, Guenter Roeck wrote:
On 12/15/18 12:07 AM, Greg Kroah-Hartman wrote:
On Fri, Dec 14, 2018 at 06:10:29PM -0800, Guenter Roeck wrote:
On 12/14/18 3:59 AM, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.4.168 release.
There are 88 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Sun Dec 16 11:56:41 UTC 2018.
Anything received after that time might be too late.
Build results:
total: 170 pass: 145 fail: 25
Failed builds:
arm:allnoconfig
arm:tinyconfig
arm:efm32_defconfig
blackfin:defconfig
blackfin:BF561-EZKIT-SMP_defconfig
c6x:dsk6455_defconfig
c6x:evmc6457_defconfig
c6x:evmc6678_defconfig
h8300:allnoconfig
h8300:tinyconfig
h8300:edosk2674_defconfig
h8300:h8300h-sim_defconfig
h8300:h8s-sim_defconfig
m68k:allnoconfig
m68k:tinyconfig
m68k:m5272c3_defconfig
m68k:m5307c3_defconfig
m68k:m5249evb_defconfig
m68k:m5407c3_defconfig
microblaze:nommu_defconfig
microblaze:allnoconfig
microblaze:tinyconfig
sh:defconfig
sh:allnoconfig
sh:tinyconfig
Qemu test results:
total: 288 pass: 288 fail: 0
mm/nommu.c: In function '__get_user_pages_unlocked':
mm/nommu.c:211:49: error: 'write' undeclared (first use in this function)
mm/nommu.c:211:56: error: 'force' undeclared (first use in this function)
mm/nommu.c:212:9: warning: passing argument 7 of 'get_user_pages' from
incompatible pointer type [enabled by default]
mm/nommu.c:185:6: note: expected 'struct vm_area_struct **' but argument is of
type 'struct page **'
mm/nommu.c:212:9: error: too many arguments to function 'get_user_pages'
mm/nommu.c:185:6: note: declared here
Details are available at https://kerneltests.org/builders/.
Ugh, I'll dig through this later on today, we must be missing something
with those backports that Ben did...
69ce144e5c3a ("mm: replace get_user_pages() write/force parameters
with gup_flags") seems to have missed converting a call of
get_user_pages().
Right. This was changed earlier upstream in commit cde70140fed8
"mm/gup: Overload get_user_pages() functions", but I don't think it
makes sense to apply all of that. I'm attaching a minimal patch
(tested with an arm allnoconfig build) which should ideally be inserted
before mm-replace-get_user_pages-write-force-parameters-with-
gup_flags.patch.
Ben.
--
Ben Hutchings, Software Developer Codethink Ltd
https://www.codethink.co.uk/ Dale House, 35 Dale Street
Manchester, M1 2HF, United Kingdom
From 0d0afe933f60f5736c984e9171214aa34b18764c Mon Sep 17 00:00:00 2001
From: Ben Hutchings
Date: Sun, 16 Dec 2018 23:50:08 +
Subject: [PATCH] mm/nommu.c: Switch __get_user_pages_unlocked() to use
__get_user_pages()
Extracted from commit cde70140fed8 "mm/gup: Overload get_user_pages()
functions". This is needed before picking commit 768ae309a961
"mm: replace get_user_pages() write/force parameters with gup_flags".
Signed-off-by: Ben Hutchings
---
mm/nommu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/nommu.c b/mm/nommu.c
index fa1560c218d5..2360546db065 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -208,8 +208,8 @@ long __get_user_pages_unlocked(struct task_struct *tsk,
struct mm_struct *mm,
{
long ret;
down_read(>mmap_sem);
- ret = get_user_pages(tsk, mm, start, nr_pages, write, force,
-pages, NULL);
+ ret = __get_user_pages(tsk, mm, start, nr_pages, gup_flags, pages,
+ NULL, NULL);
up_read(>mmap_sem);
return ret;
}
Thanks for the patch. I've added it to the queue and pushed out a -rc2
with this in it.
Let's see what the builders say :)
v4.4.167-89-g9c558d7fe359 seemed to be happy. v4.4.167-89-g50a0280f2f7e
replaced it and will take a while.
Guenter
Re: [PATCH 4.4 00/88] 4.4.168-stable review
On Sat, Dec 15, 2018 at 04:45:33PM +0530, Harsh Shandilya wrote: > On 14 December 2018 5:29:34 PM IST, Greg Kroah-Hartman > wrote: > >This is the start of the stable review cycle for the 4.4.168 release. > >There are 88 patches in this series, all will be posted as a response > >to this one. If anyone has any issues with these being applied, please > >let me know. > > > >Responses should be made by Sun Dec 16 11:56:41 UTC 2018. > >Anything received after that time might be too late. > > > >The whole patch series can be found in one patch at: > > > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.168-rc1.gz > >or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > >linux-4.4.y > >and the diffstat can be found below. > > > >thanks, > > > >greg k-h > Built and booted on the Pixel 2, no dmesg regressions. Rather clean merge, > only required adjustments in two places in Qualcomm drivers for the > get_user_pages API change. Thanks for the merge warning, it's appreciated :) And for testing. greg k-h
Re: [PATCH 4.4 00/88] 4.4.168-stable review
On Sun, Dec 16, 2018 at 11:58:13PM +, Ben Hutchings wrote:
> On Sat, 2018-12-15 at 07:45 -0800, Guenter Roeck wrote:
> > On 12/15/18 12:07 AM, Greg Kroah-Hartman wrote:
> > > On Fri, Dec 14, 2018 at 06:10:29PM -0800, Guenter Roeck wrote:
> > > > On 12/14/18 3:59 AM, Greg Kroah-Hartman wrote:
> > > > > This is the start of the stable review cycle for the 4.4.168 release.
> > > > > There are 88 patches in this series, all will be posted as a response
> > > > > to this one. If anyone has any issues with these being applied,
> > > > > please
> > > > > let me know.
> > > > >
> > > > > Responses should be made by Sun Dec 16 11:56:41 UTC 2018.
> > > > > Anything received after that time might be too late.
> > > >
> > > > Build results:
> > > > total: 170 pass: 145 fail: 25
> > > > Failed builds:
> > > > arm:allnoconfig
> > > > arm:tinyconfig
> > > > arm:efm32_defconfig
> > > > blackfin:defconfig
> > > > blackfin:BF561-EZKIT-SMP_defconfig
> > > > c6x:dsk6455_defconfig
> > > > c6x:evmc6457_defconfig
> > > > c6x:evmc6678_defconfig
> > > > h8300:allnoconfig
> > > > h8300:tinyconfig
> > > > h8300:edosk2674_defconfig
> > > > h8300:h8300h-sim_defconfig
> > > > h8300:h8s-sim_defconfig
> > > > m68k:allnoconfig
> > > > m68k:tinyconfig
> > > > m68k:m5272c3_defconfig
> > > > m68k:m5307c3_defconfig
> > > > m68k:m5249evb_defconfig
> > > > m68k:m5407c3_defconfig
> > > > microblaze:nommu_defconfig
> > > > microblaze:allnoconfig
> > > > microblaze:tinyconfig
> > > > sh:defconfig
> > > > sh:allnoconfig
> > > > sh:tinyconfig
> > > > Qemu test results:
> > > > total: 288 pass: 288 fail: 0
> > > >
> > > > mm/nommu.c: In function '__get_user_pages_unlocked':
> > > > mm/nommu.c:211:49: error: 'write' undeclared (first use in this
> > > > function)
> > > > mm/nommu.c:211:56: error: 'force' undeclared (first use in this
> > > > function)
> > > > mm/nommu.c:212:9: warning: passing argument 7 of 'get_user_pages' from
> > > > incompatible pointer type [enabled by default]
> > > > mm/nommu.c:185:6: note: expected 'struct vm_area_struct **' but
> > > > argument is of type 'struct page **'
> > > > mm/nommu.c:212:9: error: too many arguments to function 'get_user_pages'
> > > > mm/nommu.c:185:6: note: declared here
> > > >
> > > > Details are available at https://kerneltests.org/builders/.
> > >
> > > Ugh, I'll dig through this later on today, we must be missing something
> > > with those backports that Ben did...
> > >
> >
> > 69ce144e5c3a ("mm: replace get_user_pages() write/force parameters
> > with gup_flags") seems to have missed converting a call of
> > get_user_pages().
>
> Right. This was changed earlier upstream in commit cde70140fed8
> "mm/gup: Overload get_user_pages() functions", but I don't think it
> makes sense to apply all of that. I'm attaching a minimal patch
> (tested with an arm allnoconfig build) which should ideally be inserted
> before mm-replace-get_user_pages-write-force-parameters-with-
> gup_flags.patch.
>
> Ben.
>
> --
> Ben Hutchings, Software Developer Codethink Ltd
> https://www.codethink.co.uk/ Dale House, 35 Dale Street
> Manchester, M1 2HF, United Kingdom
> From 0d0afe933f60f5736c984e9171214aa34b18764c Mon Sep 17 00:00:00 2001
> From: Ben Hutchings
> Date: Sun, 16 Dec 2018 23:50:08 +
> Subject: [PATCH] mm/nommu.c: Switch __get_user_pages_unlocked() to use
> __get_user_pages()
>
> Extracted from commit cde70140fed8 "mm/gup: Overload get_user_pages()
> functions". This is needed before picking commit 768ae309a961
> "mm: replace get_user_pages() write/force parameters with gup_flags".
>
> Signed-off-by: Ben Hutchings
> ---
> mm/nommu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/nommu.c b/mm/nommu.c
> index fa1560c218d5..2360546db065 100644
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -208,8 +208,8 @@ long __get_user_pages_unlocked(struct task_struct *tsk,
> struct mm_struct *mm,
> {
> long ret;
> down_read(>mmap_sem);
> - ret = get_user_pages(tsk, mm, start, nr_pages, write, force,
> - pages, NULL);
> + ret = __get_user_pages(tsk, mm, start, nr_pages, gup_flags, pages,
> +NULL, NULL);
> up_read(>mmap_sem);
> return ret;
> }
Thanks for the patch. I've added it to the queue and pushed out a -rc2
with this in it.
Let's see what the builders say :)
greg k-h
Re: [PATCH 4.4 00/88] 4.4.168-stable review
On Sat, 2018-12-15 at 07:45 -0800, Guenter Roeck wrote:
> On 12/15/18 12:07 AM, Greg Kroah-Hartman wrote:
> > On Fri, Dec 14, 2018 at 06:10:29PM -0800, Guenter Roeck wrote:
> > > On 12/14/18 3:59 AM, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 4.4.168 release.
> > > > There are 88 patches in this series, all will be posted as a response
> > > > to this one. If anyone has any issues with these being applied, please
> > > > let me know.
> > > >
> > > > Responses should be made by Sun Dec 16 11:56:41 UTC 2018.
> > > > Anything received after that time might be too late.
> > >
> > > Build results:
> > > total: 170 pass: 145 fail: 25
> > > Failed builds:
> > > arm:allnoconfig
> > > arm:tinyconfig
> > > arm:efm32_defconfig
> > > blackfin:defconfig
> > > blackfin:BF561-EZKIT-SMP_defconfig
> > > c6x:dsk6455_defconfig
> > > c6x:evmc6457_defconfig
> > > c6x:evmc6678_defconfig
> > > h8300:allnoconfig
> > > h8300:tinyconfig
> > > h8300:edosk2674_defconfig
> > > h8300:h8300h-sim_defconfig
> > > h8300:h8s-sim_defconfig
> > > m68k:allnoconfig
> > > m68k:tinyconfig
> > > m68k:m5272c3_defconfig
> > > m68k:m5307c3_defconfig
> > > m68k:m5249evb_defconfig
> > > m68k:m5407c3_defconfig
> > > microblaze:nommu_defconfig
> > > microblaze:allnoconfig
> > > microblaze:tinyconfig
> > > sh:defconfig
> > > sh:allnoconfig
> > > sh:tinyconfig
> > > Qemu test results:
> > > total: 288 pass: 288 fail: 0
> > >
> > > mm/nommu.c: In function '__get_user_pages_unlocked':
> > > mm/nommu.c:211:49: error: 'write' undeclared (first use in this function)
> > > mm/nommu.c:211:56: error: 'force' undeclared (first use in this function)
> > > mm/nommu.c:212:9: warning: passing argument 7 of 'get_user_pages' from
> > > incompatible pointer type [enabled by default]
> > > mm/nommu.c:185:6: note: expected 'struct vm_area_struct **' but argument
> > > is of type 'struct page **'
> > > mm/nommu.c:212:9: error: too many arguments to function 'get_user_pages'
> > > mm/nommu.c:185:6: note: declared here
> > >
> > > Details are available at https://kerneltests.org/builders/.
> >
> > Ugh, I'll dig through this later on today, we must be missing something
> > with those backports that Ben did...
> >
>
> 69ce144e5c3a ("mm: replace get_user_pages() write/force parameters
> with gup_flags") seems to have missed converting a call of
> get_user_pages().
Right. This was changed earlier upstream in commit cde70140fed8
"mm/gup: Overload get_user_pages() functions", but I don't think it
makes sense to apply all of that. I'm attaching a minimal patch
(tested with an arm allnoconfig build) which should ideally be inserted
before mm-replace-get_user_pages-write-force-parameters-with-
gup_flags.patch.
Ben.
--
Ben Hutchings, Software Developer Codethink Ltd
https://www.codethink.co.uk/ Dale House, 35 Dale Street
Manchester, M1 2HF, United KingdomFrom 0d0afe933f60f5736c984e9171214aa34b18764c Mon Sep 17 00:00:00 2001
From: Ben Hutchings
Date: Sun, 16 Dec 2018 23:50:08 +
Subject: [PATCH] mm/nommu.c: Switch __get_user_pages_unlocked() to use
__get_user_pages()
Extracted from commit cde70140fed8 "mm/gup: Overload get_user_pages()
functions". This is needed before picking commit 768ae309a961
"mm: replace get_user_pages() write/force parameters with gup_flags".
Signed-off-by: Ben Hutchings
---
mm/nommu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/nommu.c b/mm/nommu.c
index fa1560c218d5..2360546db065 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -208,8 +208,8 @@ long __get_user_pages_unlocked(struct task_struct *tsk, struct mm_struct *mm,
{
long ret;
down_read(>mmap_sem);
- ret = get_user_pages(tsk, mm, start, nr_pages, write, force,
- pages, NULL);
+ ret = __get_user_pages(tsk, mm, start, nr_pages, gup_flags, pages,
+ NULL, NULL);
up_read(>mmap_sem);
return ret;
}
Re: [PATCH 4.4 00/88] 4.4.168-stable review
On Fri, Dec 14, 2018 at 12:59:34PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.168 release. > There are 88 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Sun Dec 16 11:56:41 UTC 2018. > Anything received after that time might be too late. Results from Linaro’s test farm. No regressions on arm64, arm, x86_64, and i386. Summary kernel: 4.4.168-rc1 git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git branch: linux-4.4.y git commit: 9c558d7fe359a962e214e426ffeb338e012bba39 git describe: v4.4.167-89-g9c558d7fe359 Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.4-oe/build/v4.4.167-89-g9c558d7fe359 No regressions (compared to build v4.4.167-40-g840a97100a76) No fixes (compared to build v4.4.167-40-g840a97100a76) Ran 17023 total tests in the following environments and test suites. Environments -- - i386 - juno-r2 - arm64 - qemu_arm - qemu_i386 - qemu_x86_64 - x15 - arm - x86_64 Test Suites --- * boot * kselftest * libhugetlbfs * ltp-cap_bounds-tests * ltp-containers-tests * ltp-cpuhotplug-tests * ltp-cve-tests * ltp-fcntl-locktests-tests * ltp-filecaps-tests * ltp-fs-tests * ltp-fs_bind-tests * ltp-fs_perms_simple-tests * ltp-fsx-tests * ltp-hugetlb-tests * ltp-io-tests * ltp-ipc-tests * ltp-math-tests * ltp-nptl-tests * ltp-open-posix-tests * ltp-pty-tests * ltp-sched-tests * ltp-securebits-tests * ltp-syscalls-tests * ltp-timers-tests * spectre-meltdown-checker-test * install-android-platform-tools-r2600 * kselftest-vsyscall-mode-native * kselftest-vsyscall-mode-none Summary kernel: 4.4.168-rc1 git repo: https://git.linaro.org/lkft/arm64-stable-rc.git git branch: 4.4.168-rc1-hikey-20181214-340 git commit: adb4d07253946d647c9afde07d2002b28b3c0ec0 git describe: 4.4.168-rc1-hikey-20181214-340 Test details: https://qa-reports.linaro.org/lkft/linaro-hikey-stable-rc-4.4-oe/build/4.4.168-rc1-hikey-20181214-340 No regressions (compared to build 4.4.167-rc1-hikey-20181211-336) No fixes (compared to build 4.4.167-rc1-hikey-20181211-336) Ran 2756 total tests in the following environments and test suites. Environments -- - hi6220-hikey - arm64 - qemu_arm64 Test Suites --- * boot * install-android-platform-tools-r2600 * kselftest * libhugetlbfs * ltp-cap_bounds-tests * ltp-containers-tests * ltp-cpuhotplug-tests * ltp-cve-tests * ltp-fcntl-locktests-tests * ltp-filecaps-tests * ltp-fs-tests * ltp-fs_bind-tests * ltp-fs_perms_simple-tests * ltp-fsx-tests * ltp-hugetlb-tests * ltp-io-tests * ltp-ipc-tests * ltp-math-tests * ltp-nptl-tests * ltp-pty-tests * ltp-sched-tests * ltp-securebits-tests * ltp-syscalls-tests * ltp-timers-tests * spectre-meltdown-checker-test -- Linaro LKFT https://lkft.linaro.org
Re: [PATCH 4.4 00/88] 4.4.168-stable review
On 12/15/18 12:07 AM, Greg Kroah-Hartman wrote:
On Fri, Dec 14, 2018 at 06:10:29PM -0800, Guenter Roeck wrote:
On 12/14/18 3:59 AM, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.4.168 release.
There are 88 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Sun Dec 16 11:56:41 UTC 2018.
Anything received after that time might be too late.
Build results:
total: 170 pass: 145 fail: 25
Failed builds:
arm:allnoconfig
arm:tinyconfig
arm:efm32_defconfig
blackfin:defconfig
blackfin:BF561-EZKIT-SMP_defconfig
c6x:dsk6455_defconfig
c6x:evmc6457_defconfig
c6x:evmc6678_defconfig
h8300:allnoconfig
h8300:tinyconfig
h8300:edosk2674_defconfig
h8300:h8300h-sim_defconfig
h8300:h8s-sim_defconfig
m68k:allnoconfig
m68k:tinyconfig
m68k:m5272c3_defconfig
m68k:m5307c3_defconfig
m68k:m5249evb_defconfig
m68k:m5407c3_defconfig
microblaze:nommu_defconfig
microblaze:allnoconfig
microblaze:tinyconfig
sh:defconfig
sh:allnoconfig
sh:tinyconfig
Qemu test results:
total: 288 pass: 288 fail: 0
mm/nommu.c: In function '__get_user_pages_unlocked':
mm/nommu.c:211:49: error: 'write' undeclared (first use in this function)
mm/nommu.c:211:56: error: 'force' undeclared (first use in this function)
mm/nommu.c:212:9: warning: passing argument 7 of 'get_user_pages' from
incompatible pointer type [enabled by default]
mm/nommu.c:185:6: note: expected 'struct vm_area_struct **' but argument is of
type 'struct page **'
mm/nommu.c:212:9: error: too many arguments to function 'get_user_pages'
mm/nommu.c:185:6: note: declared here
Details are available at https://kerneltests.org/builders/.
Ugh, I'll dig through this later on today, we must be missing something
with those backports that Ben did...
69ce144e5c3a ("mm: replace get_user_pages() write/force parameters
with gup_flags") seems to have missed converting a call of
get_user_pages().
Guenter
Re: [PATCH 4.4 00/88] 4.4.168-stable review
On 14 December 2018 5:29:34 PM IST, Greg Kroah-Hartman wrote: >This is the start of the stable review cycle for the 4.4.168 release. >There are 88 patches in this series, all will be posted as a response >to this one. If anyone has any issues with these being applied, please >let me know. > >Responses should be made by Sun Dec 16 11:56:41 UTC 2018. >Anything received after that time might be too late. > >The whole patch series can be found in one patch at: > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.168-rc1.gz >or in the git tree and branch at: > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git >linux-4.4.y >and the diffstat can be found below. > >thanks, > >greg k-h Built and booted on the Pixel 2, no dmesg regressions. Rather clean merge, only required adjustments in two places in Qualcomm drivers for the get_user_pages API change. -- Harsh Shandilya PRJKT Development LLC
Re: [PATCH 4.4 00/88] 4.4.168-stable review
On Fri, Dec 14, 2018 at 06:10:29PM -0800, Guenter Roeck wrote: > On 12/14/18 3:59 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.4.168 release. > > There are 88 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Sun Dec 16 11:56:41 UTC 2018. > > Anything received after that time might be too late. > > Build results: > total: 170 pass: 145 fail: 25 > Failed builds: > arm:allnoconfig > arm:tinyconfig > arm:efm32_defconfig > blackfin:defconfig > blackfin:BF561-EZKIT-SMP_defconfig > c6x:dsk6455_defconfig > c6x:evmc6457_defconfig > c6x:evmc6678_defconfig > h8300:allnoconfig > h8300:tinyconfig > h8300:edosk2674_defconfig > h8300:h8300h-sim_defconfig > h8300:h8s-sim_defconfig > m68k:allnoconfig > m68k:tinyconfig > m68k:m5272c3_defconfig > m68k:m5307c3_defconfig > m68k:m5249evb_defconfig > m68k:m5407c3_defconfig > microblaze:nommu_defconfig > microblaze:allnoconfig > microblaze:tinyconfig > sh:defconfig > sh:allnoconfig > sh:tinyconfig > Qemu test results: > total: 288 pass: 288 fail: 0 > > mm/nommu.c: In function '__get_user_pages_unlocked': > mm/nommu.c:211:49: error: 'write' undeclared (first use in this function) > mm/nommu.c:211:56: error: 'force' undeclared (first use in this function) > mm/nommu.c:212:9: warning: passing argument 7 of 'get_user_pages' from > incompatible pointer type [enabled by default] > mm/nommu.c:185:6: note: expected 'struct vm_area_struct **' but argument is > of type 'struct page **' > mm/nommu.c:212:9: error: too many arguments to function 'get_user_pages' > mm/nommu.c:185:6: note: declared here > > Details are available at https://kerneltests.org/builders/. Ugh, I'll dig through this later on today, we must be missing something with those backports that Ben did... greg k-h
Re: [PATCH 4.4 00/88] 4.4.168-stable review
On 12/14/18 3:59 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.4.168 release. There are 88 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun Dec 16 11:56:41 UTC 2018. Anything received after that time might be too late. Build results: total: 170 pass: 145 fail: 25 Failed builds: arm:allnoconfig arm:tinyconfig arm:efm32_defconfig blackfin:defconfig blackfin:BF561-EZKIT-SMP_defconfig c6x:dsk6455_defconfig c6x:evmc6457_defconfig c6x:evmc6678_defconfig h8300:allnoconfig h8300:tinyconfig h8300:edosk2674_defconfig h8300:h8300h-sim_defconfig h8300:h8s-sim_defconfig m68k:allnoconfig m68k:tinyconfig m68k:m5272c3_defconfig m68k:m5307c3_defconfig m68k:m5249evb_defconfig m68k:m5407c3_defconfig microblaze:nommu_defconfig microblaze:allnoconfig microblaze:tinyconfig sh:defconfig sh:allnoconfig sh:tinyconfig Qemu test results: total: 288 pass: 288 fail: 0 mm/nommu.c: In function '__get_user_pages_unlocked': mm/nommu.c:211:49: error: 'write' undeclared (first use in this function) mm/nommu.c:211:56: error: 'force' undeclared (first use in this function) mm/nommu.c:212:9: warning: passing argument 7 of 'get_user_pages' from incompatible pointer type [enabled by default] mm/nommu.c:185:6: note: expected 'struct vm_area_struct **' but argument is of type 'struct page **' mm/nommu.c:212:9: error: too many arguments to function 'get_user_pages' mm/nommu.c:185:6: note: declared here Details are available at https://kerneltests.org/builders/. Guenter
Re: [PATCH 4.4 00/88] 4.4.168-stable review
On 12/14/18 4:59 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.4.168 release. There are 88 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun Dec 16 11:56:41 UTC 2018. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.168-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah
Re: [PATCH 4.4 00/88] 4.4.168-stable review
stable-rc/linux-4.4.y boot: 93 boots: 1 failed, 91 passed with 1 offline (v4.4.167-89-g9c558d7fe359) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.4.y/kernel/v4.4.167-89-g9c558d7fe359/ Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.167-89-g9c558d7fe359/ Tree: stable-rc Branch: linux-4.4.y Git Describe: v4.4.167-89-g9c558d7fe359 Git Commit: 9c558d7fe359a962e214e426ffeb338e012bba39 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 42 unique boards, 20 SoC families, 12 builds out of 187 Boot Failure Detected: arm64: defconfig qcom-qdf2400: 1 failed lab Offline Platforms: arm: multi_v7_defconfig: stih410-b2120: 1 offline lab --- For more info write to
Re: [PATCH 4.4 00/88] 4.4.168-stable review
On Fri, Dec 14, 2018 at 12:59:34PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.168 release. > There are 88 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Sun Dec 16 11:56:41 UTC 2018. > Anything received after that time might be too late. > All nommu builds fail: mm/nommu.c:211:49: error: 'write' undeclared and various similar errors. Guenter
[PATCH 4.4 00/88] 4.4.168-stable review
This is the start of the stable review cycle for the 4.4.168 release.
There are 88 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Sun Dec 16 11:56:41 UTC 2018.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.168-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.4.y
and the diffstat can be found below.
thanks,
greg k-h
-
Pseudo-Shortlog of commits:
Greg Kroah-Hartman
Linux 4.4.168-rc1
Shuah Khan
selftests: Move networking/timestamping from Documentation
Arnd Bergmann
rocker: fix rocker_tlv_put_* functions for KASAN
Guenter Roeck
staging: speakup: Replace strncpy with memcpy
Sudip Mukherjee
matroxfb: fix size of memcpy
Arnd Bergmann
media: dvb-frontends: fix i2c access helpers for KASAN
Willy Tarreau
proc: do not access cmdline nor environ from file-backed areas
Linus Torvalds
proc: don't use FOLL_FORCE for reading cmdline and environment
Lorenzo Stoakes
mm: replace access_remote_vm() write parameter with gup_flags
Lorenzo Stoakes
mm: replace __access_remote_vm() write parameter with gup_flags
Lorenzo Stoakes
mm: replace get_user_pages() write/force parameters with gup_flags
Lorenzo Stoakes
mm: replace get_vaddr_frames() write/force parameters with gup_flags
Lorenzo Stoakes
mm: replace get_user_pages_locked() write/force parameters with gup_flags
Lorenzo Stoakes
mm: replace get_user_pages_unlocked() write/force parameters with gup_flags
Lorenzo Stoakes
mm: remove write/force parameters from __get_user_pages_unlocked()
Lorenzo Stoakes
mm: remove write/force parameters from __get_user_pages_locked()
Jens Axboe
sr: pass down correctly sized SCSI sense buffer
Kees Cook
swiotlb: clean up reporting
Mike Kravetz
hugetlbfs: fix bug in pgoff overflow checking
Mike Kravetz
hugetlbfs: check for pgoff value overflow
Mike Kravetz
hugetlbfs: fix offset overflow in hugetlbfs mmap
Mike Kravetz
mm/hugetlb.c: don't call region_abort if region_chg fails
Thomas Gleixner
posix-timers: Sanitize overrun handling
Lior David
wil6210: missing length check in wmi_set_ie
Alexei Starovoitov
bpf: Prevent memory disambiguation attack
Ben Hutchings
bpf/verifier: Pass instruction index to check_mem_access() and check_xadd()
Ben Hutchings
bpf/verifier: Add spi variable to check_stack_write()
Alexei Starovoitov
bpf: support 8-byte metafield access
Tom Lendacky
KVM: SVM: Implement VIRT_SPEC_CTRL support for SSBD
Borislav Petkov
x86/speculation: Use synthetic bits for IBRS/IBPB/STIBP
Thomas Gleixner
x86/bugs, KVM: Extend speculation control for VIRT_SPEC_CTRL
Thomas Gleixner
KVM: SVM: Move spec control call after restore of GS
Konrad Rzeszutek Wilk
x86/KVM/VMX: Expose SPEC_CTRL Bit(2) to the guest
Konrad Rzeszutek Wilk
x86/bugs, KVM: Support the combination of guest and host IBRS
Dan Williams
x86/uaccess: Use __uaccess_begin_nospec() and uaccess_try_nospec
Dan Williams
x86/usercopy: Replace open coded stac/clac with __uaccess_{begin, end}
Dan Williams
x86: Introduce __uaccess_begin_nospec() and uaccess_try_nospec
Linus Torvalds
x86: fix SMAP in 32-bit environments
Linus Torvalds
x86: reorganize SMAP handling in user space accesses
Paolo Bonzini
KVM/x86: Remove indirect MSR op calls from SPEC_CTRL
KarimAllah Ahmed
KVM/SVM: Allow direct access to MSR_IA32_SPEC_CTRL
KarimAllah Ahmed
KVM/VMX: Allow direct access to MSR_IA32_SPEC_CTRL
KarimAllah Ahmed
KVM/VMX: Emulate MSR_IA32_ARCH_CAPABILITIES
Ashok Raj
KVM/x86: Add IBPB support
Paolo Bonzini
KVM: VMX: make MSR bitmaps per-VCPU
Paolo Bonzini
KVM: VMX: introduce alloc_loaded_vmcs
Jim Mattson
KVM: nVMX: Eliminate vmcs02 pool
David Matlack
KVM: nVMX: mark vmcs12 pages dirty on L2 exit
Radim Krčmář
KVM: nVMX: fix msr bitmaps to prevent L2 from accessing L0 x2APIC
Takashi Sakamoto
ALSA: pcm: remove SNDRV_PCM_IOCTL1_INFO internal command
Namhyung Kim
pstore: Convert console write to use ->write_buf
Pan Bian
ocfs2: fix potential use after free
Qian Cai
debugobjects: avoid recursive calls with kmemleak
Pan Bian
hfsplus: do not free node before using
Pan Bian
hfs: do not free node before using
Larry Chen
ocfs2: fix deadlock caused by ocfs2_defrag_extent()
Colin Ian King
fscache, cachefiles: remove redundant variable 'cache'
NeilBrown
fscache: fix race between enablement and dropping of object
Srikanth Boddepalli
xen: xlate_mmu: add missing header to fix 'W=1' warning
Y.C. Chen
drm/ast: fixed reading
