Re: [PATCH 4.9 00/35] 4.9.265-rc1 review
On Mon, Apr 05, 2021 at 07:36:02PM -0700, Guenter Roeck wrote:
> On Mon, Apr 05, 2021 at 07:22:00PM -0700, Guenter Roeck wrote:
> > On Mon, Apr 05, 2021 at 04:51:55PM -0700, Guenter Roeck wrote:
> > > On Mon, Apr 05, 2021 at 10:56:29AM -0700, Guenter Roeck wrote:
> > > > On Mon, Apr 05, 2021 at 10:53:35AM +0200, Greg Kroah-Hartman wrote:
> > > > > This is the start of the stable review cycle for the 4.9.265 release.
> > > > > There are 35 patches in this series, all will be posted as a response
> > > > > to this one. If anyone has any issues with these being applied,
> > > > > please
> > > > > let me know.
> > > > >
> > > > > Responses should be made by Wed, 07 Apr 2021 08:50:09 +.
> > > > > Anything received after that time might be too late.
> > > > >
> > > >
> > > > Build results:
> > > > total: 163 pass: 163 fail: 0
> > > > Qemu test results:
> > > > total: 383 pass: 382 fail: 1
> > > > Failed tests:
> > > >
> > > > parisc:generic-32bit_defconfig:smp:net,pcnet:scsi[53C895A]:rootfs
> > > >
> > > > In the failing test, the network interfcace instantiates but fails to
> > > > get
> > > > an IP address. This is not a new problem but a new test. For some reason
> > > > it only happens with this specific network interface, this specific SCSI
> > > > controller, and with v4.9.y. No reason for concern; I'll try to track
> > > > down
> > > > what is going on.
> > > >
> > >
> > > Interesting. The problem affects all kernels up to and including
> > > v4.19.y. Unlike I thought initially, the problem is not associated
> > > with the SCSI controller (that was coincidental) but with pcnet
> > > Ethernet interfaces. It has been fixed in the upstream kernel with
> > > commit 518a2f1925c3 ("dma-mapping: zero memory returned from
> > > dma_alloc_*"). This patch does not apply cleanly to any of the
> > > affected kernels. I backported part of it to v4.19.y and v4.9.y
> > > and confirmed that it fixes the problem in those branches.
> > >
> > > Question is what we should do: try to backport 518a2f1925c3 to v4.19.y
> > > and earlier, or stop testing against this specific problem.
> > >
> >
> > Another update: The following code change fixes the problem as well.
> > Commit 518a2f1925c3 fixes it only as side effect since it clears
> > all DMA buffers.
> >
> > diff --git a/drivers/net/ethernet/amd/pcnet32.c
> > b/drivers/net/ethernet/amd/pcnet32.c
> > index c22bf52d3320..7a25ec8390e4 100644
> > --- a/drivers/net/ethernet/amd/pcnet32.c
> > +++ b/drivers/net/ethernet/amd/pcnet32.c
> > @@ -1967,7 +1967,7 @@ static int pcnet32_alloc_ring(struct net_device *dev,
> > const char *name)
> > return -ENOMEM;
> > }
> >
> > - lp->rx_ring = pci_alloc_consistent(lp->pci_dev,
> > + lp->rx_ring = pci_zalloc_consistent(lp->pci_dev,
> >sizeof(struct pcnet32_rx_head) *
> >lp->rx_ring_size,
> >>rx_ring_dma_addr);
> >
> > I'll submit a patch implementing that; we'll see how it goes.
>
> Sigh. That doesn't work; upstream uses dma_alloc_coherent().
> We could apply the patch making the switch, but dma_alloc_coherent()
> doesn't clear memory in older kernels (we are back to commit 518a2f1925c3
> which is introducing that). I'll just drop pcnet tests for kernels older
> than v5.4.
If the patch above fixes this in the older kernel versions, I'm all for
taking it if needed.
thanks,
greg k-h
Re: [PATCH 4.9 00/35] 4.9.265-rc1 review
On Mon, 5 Apr 2021 at 14:27, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.9.265 release. > There are 35 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Wed, 07 Apr 2021 08:50:09 +. > Anything received after that time might be too late. > > The whole patch series can be found in one patch at: > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.265-rc1.gz > or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > linux-4.9.y > and the diffstat can be found below. > > thanks, > > greg k-h Results from Linaro’s test farm. No regressions on arm64, arm, x86_64, and i386. Tested-by: Linux Kernel Functional Testing ## Build * kernel: 4.9.265-rc1 * git: ['https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git', 'https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc'] * git branch: linux-4.9.y * git commit: 570fbad9f4ca61dfb49359b9c2627a97e41e2b4b * git describe: v4.9.264-36-g570fbad9f4ca * test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-4.9.y/build/v4.9.264-36-g570fbad9f4ca ## No regressions (compared to v4.9.264-25-gea8146018e96) ## No fixes (compared to v4.9.264-25-gea8146018e96) ## Test result summary total: 58777, pass: 48253, fail: 593, skip: 9676, xfail: 255, ## Build Summary * arm: 96 total, 96 passed, 0 failed * arm64: 23 total, 23 passed, 0 failed * dragonboard-410c: 1 total, 1 passed, 0 failed * hi6220-hikey: 1 total, 1 passed, 0 failed * i386: 13 total, 13 passed, 0 failed * juno-r2: 1 total, 1 passed, 0 failed * mips: 36 total, 36 passed, 0 failed * sparc: 9 total, 9 passed, 0 failed * x15: 1 total, 1 passed, 0 failed * x86: 1 total, 1 passed, 0 failed * x86_64: 13 total, 13 passed, 0 failed ## Test suites summary * fwts * igt-gpu-tools * install-android-platform-tools-r2600 * kselftest-android * kselftest-bpf * kselftest-capabilities * kselftest-cgroup * kselftest-clone3 * kselftest-core * kselftest-cpu-hotplug * kselftest-cpufreq * kselftest-efivarfs * kselftest-filesystems * kselftest-firmware * kselftest-fpu * kselftest-futex * kselftest-gpio * kselftest-intel_pstate * kselftest-ipc * kselftest-ir * kselftest-kcmp * kselftest-kexec * kselftest-kvm * kselftest-lib * kselftest-livepatch * kselftest-lkdtm * kselftest-membarrier * kselftest-ptrace * kselftest-rseq * kselftest-rtc * kselftest-seccomp * kselftest-sigaltstack * kselftest-size * kselftest-splice * kselftest-static_keys * kselftest-sync * kselftest-sysctl * kselftest-timens * kselftest-timers * kselftest-tmpfs * kselftest-tpm2 * kselftest-user * kselftest-vm * kselftest-x86 * kselftest-zram * kvm-unit-tests * libhugetlbfs * linux-log-parser * ltp-cap_bounds-tests * ltp-commands-tests * ltp-containers-tests * ltp-controllers-tests * ltp-cpuhotplug-tests * ltp-crypto-tests * ltp-cve-tests * ltp-dio-tests * ltp-fcntl-locktests-tests * ltp-filecaps-tests * ltp-fs-tests * ltp-fs_bind-tests * ltp-fs_perms_simple-tests * ltp-fsx-tests * ltp-hugetlb-tests * ltp-io-tests * ltp-ipc-tests * ltp-math-tests * ltp-mm-tests * ltp-nptl-tests * ltp-open-posix-tests * ltp-pty-tests * ltp-sched-tests * ltp-securebits-tests * ltp-syscalls-tests * ltp-tracing-tests * network-basic-tests * perf * ssuite * v4l2-compliance -- Linaro LKFT https://lkft.linaro.org
Re: [PATCH 4.9 00/35] 4.9.265-rc1 review
On Mon, Apr 05, 2021 at 07:22:00PM -0700, Guenter Roeck wrote:
> On Mon, Apr 05, 2021 at 04:51:55PM -0700, Guenter Roeck wrote:
> > On Mon, Apr 05, 2021 at 10:56:29AM -0700, Guenter Roeck wrote:
> > > On Mon, Apr 05, 2021 at 10:53:35AM +0200, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 4.9.265 release.
> > > > There are 35 patches in this series, all will be posted as a response
> > > > to this one. If anyone has any issues with these being applied, please
> > > > let me know.
> > > >
> > > > Responses should be made by Wed, 07 Apr 2021 08:50:09 +.
> > > > Anything received after that time might be too late.
> > > >
> > >
> > > Build results:
> > > total: 163 pass: 163 fail: 0
> > > Qemu test results:
> > > total: 383 pass: 382 fail: 1
> > > Failed tests:
> > > parisc:generic-32bit_defconfig:smp:net,pcnet:scsi[53C895A]:rootfs
> > >
> > > In the failing test, the network interfcace instantiates but fails to get
> > > an IP address. This is not a new problem but a new test. For some reason
> > > it only happens with this specific network interface, this specific SCSI
> > > controller, and with v4.9.y. No reason for concern; I'll try to track down
> > > what is going on.
> > >
> >
> > Interesting. The problem affects all kernels up to and including
> > v4.19.y. Unlike I thought initially, the problem is not associated
> > with the SCSI controller (that was coincidental) but with pcnet
> > Ethernet interfaces. It has been fixed in the upstream kernel with
> > commit 518a2f1925c3 ("dma-mapping: zero memory returned from
> > dma_alloc_*"). This patch does not apply cleanly to any of the
> > affected kernels. I backported part of it to v4.19.y and v4.9.y
> > and confirmed that it fixes the problem in those branches.
> >
> > Question is what we should do: try to backport 518a2f1925c3 to v4.19.y
> > and earlier, or stop testing against this specific problem.
> >
>
> Another update: The following code change fixes the problem as well.
> Commit 518a2f1925c3 fixes it only as side effect since it clears
> all DMA buffers.
>
> diff --git a/drivers/net/ethernet/amd/pcnet32.c
> b/drivers/net/ethernet/amd/pcnet32.c
> index c22bf52d3320..7a25ec8390e4 100644
> --- a/drivers/net/ethernet/amd/pcnet32.c
> +++ b/drivers/net/ethernet/amd/pcnet32.c
> @@ -1967,7 +1967,7 @@ static int pcnet32_alloc_ring(struct net_device *dev,
> const char *name)
> return -ENOMEM;
> }
>
> - lp->rx_ring = pci_alloc_consistent(lp->pci_dev,
> + lp->rx_ring = pci_zalloc_consistent(lp->pci_dev,
>sizeof(struct pcnet32_rx_head) *
>lp->rx_ring_size,
>>rx_ring_dma_addr);
>
> I'll submit a patch implementing that; we'll see how it goes.
Sigh. That doesn't work; upstream uses dma_alloc_coherent().
We could apply the patch making the switch, but dma_alloc_coherent()
doesn't clear memory in older kernels (we are back to commit 518a2f1925c3
which is introducing that). I'll just drop pcnet tests for kernels older
than v5.4.
Guenter
Re: [PATCH 4.9 00/35] 4.9.265-rc1 review
On Mon, Apr 05, 2021 at 04:51:55PM -0700, Guenter Roeck wrote:
> On Mon, Apr 05, 2021 at 10:56:29AM -0700, Guenter Roeck wrote:
> > On Mon, Apr 05, 2021 at 10:53:35AM +0200, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 4.9.265 release.
> > > There are 35 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Wed, 07 Apr 2021 08:50:09 +.
> > > Anything received after that time might be too late.
> > >
> >
> > Build results:
> > total: 163 pass: 163 fail: 0
> > Qemu test results:
> > total: 383 pass: 382 fail: 1
> > Failed tests:
> > parisc:generic-32bit_defconfig:smp:net,pcnet:scsi[53C895A]:rootfs
> >
> > In the failing test, the network interfcace instantiates but fails to get
> > an IP address. This is not a new problem but a new test. For some reason
> > it only happens with this specific network interface, this specific SCSI
> > controller, and with v4.9.y. No reason for concern; I'll try to track down
> > what is going on.
> >
>
> Interesting. The problem affects all kernels up to and including
> v4.19.y. Unlike I thought initially, the problem is not associated
> with the SCSI controller (that was coincidental) but with pcnet
> Ethernet interfaces. It has been fixed in the upstream kernel with
> commit 518a2f1925c3 ("dma-mapping: zero memory returned from
> dma_alloc_*"). This patch does not apply cleanly to any of the
> affected kernels. I backported part of it to v4.19.y and v4.9.y
> and confirmed that it fixes the problem in those branches.
>
> Question is what we should do: try to backport 518a2f1925c3 to v4.19.y
> and earlier, or stop testing against this specific problem.
>
Another update: The following code change fixes the problem as well.
Commit 518a2f1925c3 fixes it only as side effect since it clears
all DMA buffers.
diff --git a/drivers/net/ethernet/amd/pcnet32.c
b/drivers/net/ethernet/amd/pcnet32.c
index c22bf52d3320..7a25ec8390e4 100644
--- a/drivers/net/ethernet/amd/pcnet32.c
+++ b/drivers/net/ethernet/amd/pcnet32.c
@@ -1967,7 +1967,7 @@ static int pcnet32_alloc_ring(struct net_device *dev,
const char *name)
return -ENOMEM;
}
- lp->rx_ring = pci_alloc_consistent(lp->pci_dev,
+ lp->rx_ring = pci_zalloc_consistent(lp->pci_dev,
sizeof(struct pcnet32_rx_head) *
lp->rx_ring_size,
>rx_ring_dma_addr);
I'll submit a patch implementing that; we'll see how it goes.
Thanks,
Guenter
Re: [PATCH 4.9 00/35] 4.9.265-rc1 review
On 4/5/21 2:53 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.9.265 release. There are 35 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 07 Apr 2021 08:50:09 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.265-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah
Re: [PATCH 4.9 00/35] 4.9.265-rc1 review
On Mon, Apr 05, 2021 at 10:56:29AM -0700, Guenter Roeck wrote:
> On Mon, Apr 05, 2021 at 10:53:35AM +0200, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.9.265 release.
> > There are 35 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 07 Apr 2021 08:50:09 +.
> > Anything received after that time might be too late.
> >
>
> Build results:
> total: 163 pass: 163 fail: 0
> Qemu test results:
> total: 383 pass: 382 fail: 1
> Failed tests:
> parisc:generic-32bit_defconfig:smp:net,pcnet:scsi[53C895A]:rootfs
>
> In the failing test, the network interfcace instantiates but fails to get
> an IP address. This is not a new problem but a new test. For some reason
> it only happens with this specific network interface, this specific SCSI
> controller, and with v4.9.y. No reason for concern; I'll try to track down
> what is going on.
>
Interesting. The problem affects all kernels up to and including
v4.19.y. Unlike I thought initially, the problem is not associated
with the SCSI controller (that was coincidental) but with pcnet
Ethernet interfaces. It has been fixed in the upstream kernel with
commit 518a2f1925c3 ("dma-mapping: zero memory returned from
dma_alloc_*"). This patch does not apply cleanly to any of the
affected kernels. I backported part of it to v4.19.y and v4.9.y
and confirmed that it fixes the problem in those branches.
Question is what we should do: try to backport 518a2f1925c3 to v4.19.y
and earlier, or stop testing against this specific problem.
Any thoughts ?
Thanks,
Guenter
Re: [PATCH 4.9 00/35] 4.9.265-rc1 review
On Mon, Apr 05, 2021 at 10:53:35AM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.265 release. > There are 35 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Wed, 07 Apr 2021 08:50:09 +. > Anything received after that time might be too late. > Build results: total: 163 pass: 163 fail: 0 Qemu test results: total: 383 pass: 382 fail: 1 Failed tests: parisc:generic-32bit_defconfig:smp:net,pcnet:scsi[53C895A]:rootfs In the failing test, the network interfcace instantiates but fails to get an IP address. This is not a new problem but a new test. For some reason it only happens with this specific network interface, this specific SCSI controller, and with v4.9.y. No reason for concern; I'll try to track down what is going on. Tested-by: Guenter Roeck Guenter
Re: [PATCH 4.9 00/35] 4.9.265-rc1 review
On 4/5/2021 1:53 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.265 release. > There are 35 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Wed, 07 Apr 2021 08:50:09 +. > Anything received after that time might be too late. > > The whole patch series can be found in one patch at: > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.265-rc1.gz > or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > linux-4.9.y > and the diffstat can be found below. > > thanks, > > greg k-h On ARCH_BRCMSTB, using 32-bit and 64-bit kernels: Tested-by: Florian Fainelli -- Florian
[PATCH 4.9 00/35] 4.9.265-rc1 review
This is the start of the stable review cycle for the 4.9.265 release. There are 35 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 07 Apr 2021 08:50:09 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.265-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h - Pseudo-Shortlog of commits: Greg Kroah-Hartman Linux 4.9.265-rc1 Paul Moore audit: fix a net reference leak in audit_list_rules_send() Paul Moore audit: fix a net reference leak in audit_send_reply() Atul Gopinathan staging: rtl8192e: Change state information from u16 to u8 Atul Gopinathan staging: rtl8192e: Fix incorrect source in memcpy() Johan Hovold USB: cdc-acm: fix use-after-free after probe failure Oliver Neukum USB: cdc-acm: downgrade message to debug Oliver Neukum cdc-acm: fix BREAK rx code path adding necessary calls Chunfeng Yun usb: xhci-mtk: fix broken streams issue on 0.96 xHCI Vincent Palatin USB: quirks: ignore remote wake-up on Fibocom L850-GL LTE modem Zheyu Ma firewire: nosy: Fix a use-after-free bug in nosy_ioctl() Dinghao Liu extcon: Fix error handling in extcon_dev_register Wang Panzhenzhuan pinctrl: rockchip: fix restore error in resume Tetsuo Handa reiserfs: update reiserfs_xattrs_initialized() condition Ilya Lipnitskiy mm: fix race by making init_zero_pfn() early_initcall Steven Rostedt (VMware) tracing: Fix stack trace event size Hui Wang ALSA: hda/realtek: call alc_update_headset_mode() in hp_automute_hook Ikjoon Jang ALSA: usb-audio: Apply sample rate quirk to Logitech Connect Jesper Dangaard Brouer bpf: Remove MTU check in __bpf_skb_max_len Tong Zhang net: wan/lmc: unregister device when no matching device is found Doug Brown appletalk: Fix skb allocation size in loopback case zhangyi (F) ext4: do not iput inode under running transaction in ext4_rename() Sameer Pujar ASoC: rt5659: Update MCLK rate in set_sysclk() Tong Zhang staging: comedi: cb_pcidas64: fix request_irq() warn Tong Zhang staging: comedi: cb_pcidas: fix request_irq() warn Alexey Dobriyan scsi: qla2xxx: Fix broken #endif placement Lv Yunlong scsi: st: Fix a use after free in st_open() Laurent Vivier vhost: Fix vhost_vq_reset() Christophe Leroy powerpc: Force inlining of cpu_has_feature() to avoid build failure Benjamin Rood ASoC: sgtl5000: set DAP_AVC_CTRL register to correct default value on probe Hans de Goede ASoC: rt5651: Fix dac- and adc- vol-tlv values being off by a factor of 10 Hans de Goede ASoC: rt5640: Fix dac- and adc- vol-tlv values being off by a factor of 10 J. Bruce Fields rpc: fix NULL dereference on kmalloc failure Zhaolong Zhang ext4: fix bh ref count on error paths Jakub Kicinski ipv6: weaken the v4mapped source check David Brazdil selinux: vsock: Set SID for socket returned by accept() - Diffstat: Makefile | 4 +-- arch/powerpc/include/asm/cpu_has_feature.h | 4 +-- drivers/extcon/extcon.c | 1 + drivers/firewire/nosy.c | 9 -- drivers/net/wan/lmc/lmc_main.c | 2 ++ drivers/pinctrl/pinctrl-rockchip.c | 13 +--- drivers/scsi/qla2xxx/qla_target.h| 2 +- drivers/scsi/st.c| 2 +- drivers/staging/comedi/drivers/cb_pcidas.c | 2 +- drivers/staging/comedi/drivers/cb_pcidas64.c | 2 +- drivers/staging/rtl8192e/rtllib.h| 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 2 +- drivers/usb/class/cdc-acm.c | 12 +-- drivers/usb/core/quirks.c| 4 +++ drivers/usb/host/xhci-mtk.c | 10 +- drivers/vhost/vhost.c| 2 +- fs/ext4/inode.c | 6 ++-- fs/ext4/namei.c | 18 +-- fs/reiserfs/xattr.h | 2 +- kernel/audit.c | 48 +--- kernel/audit.h | 2 +- kernel/auditfilter.c | 13 kernel/trace/trace.c | 3 +- mm/memory.c | 2 +- net/appletalk/ddp.c | 33 --- net/core/filter.c| 7 ++-- net/dccp/ipv6.c | 5 +++ net/ipv6/ip6_input.c | 10 -- net/ipv6/tcp_ipv6.c
