Re: [PATCH 4.9 00/96] 4.9.163-stable review
On Wed, Mar 13, 2019 at 01:49:49PM -0700, Greg Kroah-Hartman wrote: > On Wed, Mar 13, 2019 at 01:34:41PM -0700, Guenter Roeck wrote: > > On Tue, Mar 12, 2019 at 10:09:18AM -0700, Greg Kroah-Hartman wrote: > > > This is the start of the stable review cycle for the 4.9.163 release. > > > There are 96 patches in this series, all will be posted as a response > > > to this one. If anyone has any issues with these being applied, please > > > let me know. > > > > > > Responses should be made by Thu Mar 14 17:10:06 UTC 2019. > > > Anything received after that time might be too late. > > > > > > > Build results: > > total: 172 pass: 170 fail: 2 > > Failed builds: > > i386:tools/perf > > x86_64:tools/perf > > Qemu test results: > > total: 316 pass: 316 fail: 0 > > > > Culprit is commit 386ca5754fad ("perf trace: Support multiple "vfs_getname" > > probes"), which introduces a call to strstarts() but not the necessary > > include file or declaration. Unfortunately, fixing that is quite complex > > (commit 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel") > > doesn't apply). > > Thanks for tracking this down, I'm lost in a maze of gcc8 issues with > perf on 4.9 and 4.4 at the moment trying to fix that. > > I'll go drop this patch from the 4.9 and 4.4 queues. > Agreed; the same patch also introduces a call to evlist__for_each_entry_safe(), which does not exist in v4.4.y. Guenter
Re: [PATCH 4.9 00/96] 4.9.163-stable review
On Wed, Mar 13, 2019 at 01:34:41PM -0700, Guenter Roeck wrote: > On Tue, Mar 12, 2019 at 10:09:18AM -0700, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.9.163 release. > > There are 96 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Thu Mar 14 17:10:06 UTC 2019. > > Anything received after that time might be too late. > > > > Build results: > total: 172 pass: 170 fail: 2 > Failed builds: > i386:tools/perf > x86_64:tools/perf > Qemu test results: > total: 316 pass: 316 fail: 0 > > Culprit is commit 386ca5754fad ("perf trace: Support multiple "vfs_getname" > probes"), which introduces a call to strstarts() but not the necessary > include file or declaration. Unfortunately, fixing that is quite complex > (commit 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel") > doesn't apply). Thanks for tracking this down, I'm lost in a maze of gcc8 issues with perf on 4.9 and 4.4 at the moment trying to fix that. I'll go drop this patch from the 4.9 and 4.4 queues. thanks, greg k-h
Re: [PATCH 4.9 00/96] 4.9.163-stable review
On Tue, Mar 12, 2019 at 10:09:18AM -0700, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.163 release. > There are 96 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Thu Mar 14 17:10:06 UTC 2019. > Anything received after that time might be too late. > Build results: total: 172 pass: 170 fail: 2 Failed builds: i386:tools/perf x86_64:tools/perf Qemu test results: total: 316 pass: 316 fail: 0 Culprit is commit 386ca5754fad ("perf trace: Support multiple "vfs_getname" probes"), which introduces a call to strstarts() but not the necessary include file or declaration. Unfortunately, fixing that is quite complex (commit 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel") doesn't apply). Guenter
Re: [PATCH 4.9 00/96] 4.9.163-stable review
Hello! On Wed, 13 Mar 2019 at 11:58, Greg Kroah-Hartman wrote: > > On Wed, Mar 13, 2019 at 08:14:29AM -0700, Greg Kroah-Hartman wrote: > > On Wed, Mar 13, 2019 at 07:44:34AM -0700, Guenter Roeck wrote: > > > On Tue, Mar 12, 2019 at 10:09:18AM -0700, Greg Kroah-Hartman wrote: > > > > This is the start of the stable review cycle for the 4.9.163 release. > > > > There are 96 patches in this series, all will be posted as a response > > > > to this one. If anyone has any issues with these being applied, please > > > > let me know. > > > > > > > > Responses should be made by Thu Mar 14 17:10:06 UTC 2019. > > > > Anything received after that time might be too late. > > > > > > > > > > Early results: > > > > > > Building x86_64:tools/perf ... failed > > > -- > > > Error log: > > > Warning: arch/x86/include/asm/cpufeatures.h differs from kernel > > > Warning: arch/x86/include/uapi/asm/kvm.h differs from kernel > > > PERF_VERSION = 4.9.162.g605129 > > > builtin-trace.c: In function ‘perf_evlist__add_vfs_getname’: > > > builtin-trace.c:2071:8: error: implicit declaration of function > > > ‘strstarts’ [-Werror=implicit-function-declaration] > > > builtin-trace.c:2071:3: error: nested extern declaration of ‘strstarts’ > > > [-Werror=nested-externs] > > > > > > Also affects v4.4.y-queue. > > > > Hm, at first I was worried about my backport, but if it hit 4.4 as well, > > that's not my fault :) > > > > I'll look at this after breakfast, thanks! > > I can't even get perf to build without any stable queue patches for > 4.9.y at the moment, nor for 4.4.y, so something is odd, or I just have > too "new" of a system. Let me go dig up a debian box to see if I can at > least find a way to start to reproduce this... Interesting. To add to the fun, just yesterday I tried building the Perf recipe from OpenEmbedded and it failed for these combinations: * 4.4.176 and x86_64: | CC /srv/oe/build/tmp-lkft-glibc/work/intel_corei7_64-linaro-linux/perf/1.0-r9/perf-1.0/bench/mem-memcpy-x86-64-asm.o | bench/mem-memcpy-x86-64-asm.S:4:10: fatal error: ../../../arch/x86/lib/memcpy_64.S: No such file or directory | #include "../../../arch/x86/lib/memcpy_64.S" | ^~~ | compilation terminated. * 4.14.105 and i386: | In file included from util/libunwind/x86_32.c:33:0: | util/libunwind/../../arch/x86/util/unwind-libunwind.c: In function 'libunwind__x86_reg_id': | util/libunwind/../../arch/x86/util/unwind-libunwind.c:110:11: error: 'EINVAL' undeclared (first use in this function); did you mean 'UNW_EINVAL'? |return -EINVAL; |^~ |UNW_EINVAL Other combinations that worked: * 4.4.176 with arm, arm64, i386 * 4.9.162 with arm, arm64, i386, x86_64 * 4.14.105 with arm, arm64, x86_64 * 4.19.28 with arm, arm64, i386, x86_64 * 4.20.15 with arm, arm64, i386, x86_64 * 5.0.1 with arm, arm64, i386, x86_64 I'll try again the failing combos to discard a problem with the OE build itself. Greetings! Daniel Díaz daniel.d...@linaro.org
Re: [PATCH 4.9 00/96] 4.9.163-stable review
On Wed, Mar 13, 2019 at 08:14:29AM -0700, Greg Kroah-Hartman wrote: > On Wed, Mar 13, 2019 at 07:44:34AM -0700, Guenter Roeck wrote: > > On Tue, Mar 12, 2019 at 10:09:18AM -0700, Greg Kroah-Hartman wrote: > > > This is the start of the stable review cycle for the 4.9.163 release. > > > There are 96 patches in this series, all will be posted as a response > > > to this one. If anyone has any issues with these being applied, please > > > let me know. > > > > > > Responses should be made by Thu Mar 14 17:10:06 UTC 2019. > > > Anything received after that time might be too late. > > > > > > > Early results: > > > > Building x86_64:tools/perf ... failed > > -- > > Error log: > > Warning: arch/x86/include/asm/cpufeatures.h differs from kernel > > Warning: arch/x86/include/uapi/asm/kvm.h differs from kernel > > PERF_VERSION = 4.9.162.g605129 > > builtin-trace.c: In function ‘perf_evlist__add_vfs_getname’: > > builtin-trace.c:2071:8: error: implicit declaration of function ‘strstarts’ > > [-Werror=implicit-function-declaration] > > builtin-trace.c:2071:3: error: nested extern declaration of ‘strstarts’ > > [-Werror=nested-externs] > > > > Also affects v4.4.y-queue. > > Hm, at first I was worried about my backport, but if it hit 4.4 as well, > that's not my fault :) > > I'll look at this after breakfast, thanks! I can't even get perf to build without any stable queue patches for 4.9.y at the moment, nor for 4.4.y, so something is odd, or I just have too "new" of a system. Let me go dig up a debian box to see if I can at least find a way to start to reproduce this... greg k-h
Re: [PATCH 4.9 00/96] 4.9.163-stable review
On 12/03/2019 17:09, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.163 release. > There are 96 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Thu Mar 14 17:10:06 UTC 2019. > Anything received after that time might be too late. > > The whole patch series can be found in one patch at: > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.163-rc1.gz > or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > linux-4.9.y > and the diffstat can be found below. > > thanks, > > greg k-h All tests passing for Tegra ... Test results for stable-v4.9: 8 builds: 8 pass, 0 fail 16 boots: 16 pass, 0 fail 20 tests: 20 pass, 0 fail Linux version: 4.9.163-rc1-g0384d1b Boards tested: tegra124-jetson-tk1, tegra20-ventana, tegra210-p2371-2180, tegra30-cardhu-a04 Cheers Jon -- nvpublic
Re: [PATCH 4.9 00/96] 4.9.163-stable review
On Wed, Mar 13, 2019 at 08:14:29AM -0700, Greg Kroah-Hartman wrote: > On Wed, Mar 13, 2019 at 07:44:34AM -0700, Guenter Roeck wrote: > > On Tue, Mar 12, 2019 at 10:09:18AM -0700, Greg Kroah-Hartman wrote: > > > This is the start of the stable review cycle for the 4.9.163 release. > > > There are 96 patches in this series, all will be posted as a response > > > to this one. If anyone has any issues with these being applied, please > > > let me know. > > > > > > Responses should be made by Thu Mar 14 17:10:06 UTC 2019. > > > Anything received after that time might be too late. > > > > > > > Early results: > > > > Building x86_64:tools/perf ... failed > > -- > > Error log: > > Warning: arch/x86/include/asm/cpufeatures.h differs from kernel > > Warning: arch/x86/include/uapi/asm/kvm.h differs from kernel > > PERF_VERSION = 4.9.162.g605129 > > builtin-trace.c: In function ‘perf_evlist__add_vfs_getname’: > > builtin-trace.c:2071:8: error: implicit declaration of function ‘strstarts’ > > [-Werror=implicit-function-declaration] > > builtin-trace.c:2071:3: error: nested extern declaration of ‘strstarts’ > > [-Werror=nested-externs] > > > > Also affects v4.4.y-queue. > > Hm, at first I was worried about my backport, but if it hit 4.4 as well, > that's not my fault :) > Actually, it turns out the build failure in 4.4.y is different: Building x86_64:tools/perf ... failed -- Error log: PERF_VERSION = 4.4.176.gbd5033 builtin-trace.c: In function ‘perf_evlist__add_vfs_getname’: builtin-trace.c:2414:2: error: implicit declaration of function ‘evlist__for_each_entry_safe’; did you mean ‘hlist_for_each_entry_safe’? builtin-trace.c:2414:2: error: nested extern declaration of ‘evlist__for_each_entry_safe’ [-Werror=nested-externs] builtin-trace.c:2414:50: error: expected ‘;’ before ‘{’ token evlist__for_each_entry_safe(evlist, evsel, tmp) { builtin-trace.c:2406:7: error: unused variable ‘found’ [-Werror=unused-variable] bool found = false; ^ builtin-trace.c:2430:1: error: control reaches end of non-void function so you are not entirely off the hook ... Guenter
Re: [PATCH 4.9 00/96] 4.9.163-stable review
On Wed, Mar 13, 2019 at 07:44:34AM -0700, Guenter Roeck wrote: > On Tue, Mar 12, 2019 at 10:09:18AM -0700, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.9.163 release. > > There are 96 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Thu Mar 14 17:10:06 UTC 2019. > > Anything received after that time might be too late. > > > > Early results: > > Building x86_64:tools/perf ... failed > -- > Error log: > Warning: arch/x86/include/asm/cpufeatures.h differs from kernel > Warning: arch/x86/include/uapi/asm/kvm.h differs from kernel > PERF_VERSION = 4.9.162.g605129 > builtin-trace.c: In function ‘perf_evlist__add_vfs_getname’: > builtin-trace.c:2071:8: error: implicit declaration of function ‘strstarts’ > [-Werror=implicit-function-declaration] > builtin-trace.c:2071:3: error: nested extern declaration of ‘strstarts’ > [-Werror=nested-externs] > > Also affects v4.4.y-queue. Hm, at first I was worried about my backport, but if it hit 4.4 as well, that's not my fault :) I'll look at this after breakfast, thanks! greg k-h
Re: [PATCH 4.9 00/96] 4.9.163-stable review
On Tue, Mar 12, 2019 at 10:09:18AM -0700, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.163 release. > There are 96 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Thu Mar 14 17:10:06 UTC 2019. > Anything received after that time might be too late. > Early results: Building x86_64:tools/perf ... failed -- Error log: Warning: arch/x86/include/asm/cpufeatures.h differs from kernel Warning: arch/x86/include/uapi/asm/kvm.h differs from kernel PERF_VERSION = 4.9.162.g605129 builtin-trace.c: In function ‘perf_evlist__add_vfs_getname’: builtin-trace.c:2071:8: error: implicit declaration of function ‘strstarts’ [-Werror=implicit-function-declaration] builtin-trace.c:2071:3: error: nested extern declaration of ‘strstarts’ [-Werror=nested-externs] Also affects v4.4.y-queue. Guenter
Re: [PATCH 4.9 00/96] 4.9.163-stable review
On Tue, 12 Mar 2019 at 22:48, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.9.163 release. > There are 96 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Thu Mar 14 17:10:06 UTC 2019. > Anything received after that time might be too late. > > The whole patch series can be found in one patch at: > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.163-rc1.gz > or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > linux-4.9.y > and the diffstat can be found below. > > thanks, > > greg k-h Results from Linaro’s test farm. No regressions on arm64, arm, x86_64, and i386. Summary kernel: 4.9.163-rc1 git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git branch: linux-4.9.y git commit: 605129cbbd389949c754d0a23ce49030adae8f17 git describe: v4.9.162-97-g605129cbbd38 Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.9-oe/build/v4.9.162-97-g605129cbbd38 No regressions (compared to build v4.9.162) No fixes (compared to build v4.9.162) Ran 22654 total tests in the following environments and test suites. Environments -- - dragonboard-410c - arm64 - hi6220-hikey - arm64 - i386 - juno-r2 - arm64 - qemu_arm - qemu_arm64 - qemu_i386 - qemu_x86_64 - x15 - arm - x86_64 Test Suites --- * boot * install-android-platform-tools-r2600 * kselftest * libhugetlbfs * ltp-cap_bounds-tests * ltp-commands-tests * ltp-containers-tests * ltp-cpuhotplug-tests * ltp-cve-tests * ltp-dio-tests * ltp-fcntl-locktests-tests * ltp-filecaps-tests * ltp-fs-tests * ltp-fs_bind-tests * ltp-fs_perms_simple-tests * ltp-fsx-tests * ltp-hugetlb-tests * ltp-io-tests * ltp-ipc-tests * ltp-math-tests * ltp-mm-tests * ltp-nptl-tests * ltp-pty-tests * ltp-sched-tests * ltp-securebits-tests * ltp-syscalls-tests * ltp-timers-tests * spectre-meltdown-checker-test * ltp-open-posix-tests * kselftest-vsyscall-mode-native * kselftest-vsyscall-mode-none -- Linaro LKFT https://lkft.linaro.org
Re: [PATCH 4.9 00/96] 4.9.163-stable review
stable-rc/linux-4.9.y boot: 92 boots: 1 failed, 91 passed (v4.9.162-97-g605129cbbd38) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.9.y/kernel/v4.9.162-97-g605129cbbd38/ Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.9.y/kernel/v4.9.162-97-g605129cbbd38/ Tree: stable-rc Branch: linux-4.9.y Git Describe: v4.9.162-97-g605129cbbd38 Git Commit: 605129cbbd389949c754d0a23ce49030adae8f17 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 47 unique boards, 21 SoC families, 13 builds out of 193 Boot Regressions Detected: arm: qcom_defconfig: gcc-7: qcom-apq8064-cm-qs600: lab-baylibre-seattle: new failure (last pass: v4.9.162-94-g0384d1b03fc9) Boot Failure Detected: arm: qcom_defconfig: gcc-7: qcom-apq8064-cm-qs600: 1 failed lab --- For more info write to
[PATCH 4.9 00/96] 4.9.163-stable review
This is the start of the stable review cycle for the 4.9.163 release. There are 96 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu Mar 14 17:10:06 UTC 2019. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.163-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h - Pseudo-Shortlog of commits: Greg Kroah-Hartman Linux 4.9.163-rc1 Peter Zijlstra (Intel) x86: Add TSX Force Abort CPUID/MSR Peter Zijlstra (Intel) perf/x86/intel: Generalize dynamic constraint creation Peter Zijlstra (Intel) perf/x86/intel: Make cpuc allocations consistent Krzysztof Kozlowski ARM: dts: exynos: Do not ignore real-world fuse values for thermal zone 0 on Exynos5420 Vincent Whitchurch ARM: 8781/1: Fix Thumb-2 syscall return for binutils 2.29+ Ard Biesheuvel drm: disable uncached DMA optimization for ARM and arm64 Marek Szyprowski ARM: dts: exynos: Add minimal clkout parameters to Exynos3250 PMU Marek Szyprowski ARM: dts: exynos: Fix pinctrl definition for eMMC RTSN line on Odroid X2/U3 Peter Zijlstra futex,rt_mutex: Restructure rt_mutex_finish_proxy_lock() Gustavo A. R. Silva scsi: aacraid: Fix missing break in switch statement Gustavo A. R. Silva iscsi_ibft: Fix missing break in switch statement Vincent Batts Input: elan_i2c - add id for touchpad found in Lenovo s21e-20 Jason Gerecke Input: wacom_serial4 - add support for Wacom ArtPad II tablet Tetsuo Handa fs: ratelimit __find_get_block_slow() failure message. Jun-Ru Chang MIPS: Remove function size check in get_frame_info() Huacai Chen MIPS: Loongson: Introduce and use loongson_llsc_mb() Arnaldo Carvalho de Melo perf trace: Support multiple "vfs_getname" probes Jiri Olsa perf symbols: Filter out hidden symbols from labels Julian Wiedmann s390/qeth: fix use-after-free in error path Martynas Pumputis netfilter: nf_nat: skip nat clash resolution for same-origin entries Florian Westphal selftests: netfilter: add simple masq/redirect test cases Naresh Kamboju selftests: netfilter: fix config fragment CONFIG_NF_TABLES_INET Andy Shevchenko dmaengine: dmatest: Abort test in case of mapping error Stefano Garzarella vsock/virtio: reset connected sockets on device removal Stefano Garzarella vsock/virtio: fix kernel panic after device hot-unplug Codrin Ciubotariu dmaengine: at_xdmac: Fix wrongfull report of a channel as in use Paul Kocialkowski drm/sun4i: tcon: Prepare and enable TCON channel 0 clock at init Lubomir Rintel irqchip/mmp: Only touch the PJ4 IRQ & FIQ bits on enable/disable Anders Roxell usb: phy: fix link errors Srinivas Kandagatla arm64: dts: add msm8996 compatible to gicv3 Peng Hao ARM: pxa: ssp: unneeded to free devm_ allocated data Madalin Bucur soc: fsl: qbman: avoid race in clearing QMan interrupt Ian Kent autofs: fix error return in autofs_fill_super() Pan Bian autofs: drop dentry reference only when it is never used Jan Kara fs/drop_caches.c: avoid softlockups in drop_pagecache_sb() Mikhail Zaslonko mm, memory_hotplug: test_pages_in_a_zone do not pass the end of zone Michal Hocko mm, memory_hotplug: is_mem_section_removable do not pass the end of a zone Qian Cai x86_64: increase stack size for KASAN_EXTRA Kairui Song x86/kexec: Don't setup EFI info if EFI runtime is not enabled James Morse arm64: kprobe: Always blacklist the KVM world-switch code Ronnie Sahlberg cifs: fix computation for MAX_SMB2_HDR_SIZE Sinan Kaya platform/x86: Fix unmet dependency warning for SAMSUNG_Q10 Ming Lu scsi: libfc: free skb when receiving invalid flogi resp Manish Chopra qed: Fix VF probe failure while FLR Yao Liu nfs: Fix NULL pointer dereference of dev_name Andrew Lunn gpio: vf610: Mask all GPIO interrupts Alexey Khoroshilov net: stmmac: dwmac-rk: fix error handling in rk_gmac_powerup() Yonglong Liu net: hns: Fix wrong read accesses via Clause 45 MDIO protocol Yonglong Liu net: hns: Fix for missing of_node_put() after of_parse_phandle() Tomonori Sakita net: altera_tse: fix msgdma_tx_completion on non-zero fill_level case Max Filippov xtensa: SMP: limit number of possible CPUs by NR_CPUS Max Filippov xtensa: SMP: mark each possible CPU as present Max Filippov xtensa: smp_lx200_defconfig: fix vectors clash Max Filippov xtensa: SMP: fix secondary CPU initialization Max Filippov xtensa: SMP: fix ccount_timer_shutdown Suravee Suthikulpanit iommu/amd: