Re: [PATCH 5/15] Make crypto API use seq_list_xxx helpers

2007-05-18 Thread Herbert Xu
On Fri, May 18, 2007 at 01:34:23PM +0400, Pavel Emelianov wrote:
> Simple and stupid - just use the same code from another
> place in the kernel.
> 
> Signed-off-by: Pavel Emelianov <[EMAIL PROTECTED]>

Ack.
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 5/15] Make crypto API use seq_list_xxx helpers

2007-05-18 Thread Pavel Emelianov
Simple and stupid - just use the same code from another
place in the kernel.

Signed-off-by: Pavel Emelianov <[EMAIL PROTECTED]>

---

diff --git a/crypto/proc.c b/crypto/proc.c
index 102c751..3d73323 100644
--- a/crypto/proc.c
+++ b/crypto/proc.c
@@ -23,24 +23,13 @@
 
 static void *c_start(struct seq_file *m, loff_t *pos)
 {
-   struct list_head *v;
-   loff_t n = *pos;
-
down_read(&crypto_alg_sem);
-   list_for_each(v, &crypto_alg_list)
-   if (!n--)
-   return list_entry(v, struct crypto_alg, cra_list);
-   return NULL;
+   return seq_list_start(&crypto_alg_list, *pos);
 }
 
 static void *c_next(struct seq_file *m, void *p, loff_t *pos)
 {
-   struct list_head *v = p;
-   
-   (*pos)++;
-   v = v->next;
-   return (v == &crypto_alg_list) ?
-   NULL : list_entry(v, struct crypto_alg, cra_list);
+   return seq_list_next(p, &crypto_alg_list, pos);
 }
 
 static void c_stop(struct seq_file *m, void *p)
@@ -50,7 +39,7 @@ static void c_stop(struct seq_file *m, v
 
 static int c_show(struct seq_file *m, void *p)
 {
-   struct crypto_alg *alg = (struct crypto_alg *)p;
+   struct crypto_alg *alg = list_entry(p, struct crypto_alg, cra_list);

seq_printf(m, "name : %s\n", alg->cra_name);
seq_printf(m, "driver   : %s\n", alg->cra_driver_name);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/