Re: [PATCH 5/16] CRIS architecture: Correct compile errors

2007-10-30 Thread Andrew Morton
On Tue, 30 Oct 2007 10:30:31 +0100
Jesper Nilsson <[EMAIL PROTECTED]> wrote:

> Include file linux/compiler.h is needed for 'likely'.
> 
> Signed-off-by: Jesper Nilsson <[EMAIL PROTECTED]>
> 
> ---
>  atomic.h |1 +
>  1 file changed, 1 insertion(+)
> 
> diff -urBb -X /h/jespern/.exclude_files 
> clean_linux-2.6.23/include/asm-cris/atomic.h 
> linux-2.6.23/include/asm-cris/atomic.h
> --- clean_linux-2.6.23/include/asm-cris/atomic.h  2007-10-09 
> 22:31:38.0 +0200
> +++ linux-2.6.23/include/asm-cris/atomic.h2007-10-22 10:32:54.0 
> +0200
> @@ -5,6 +5,7 @@
>  
>  #include 
>  #include 
> +#include 
>  
>  /*
>   * Atomic operations that C can't guarantee us.  Useful for
> /^JN - Jesper Nilsson
> --

We conventionally include the  headers before the 
headers, with a single blank line between them.  So:

#ifndef __ASM_CRIS_ATOMIC__
#define __ASM_CRIS_ATOMIC__

#include 

#include 
#include 

/*

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 5/16] CRIS architecture: Correct compile errors

2007-10-30 Thread Jesper Nilsson
Include file linux/compiler.h is needed for 'likely'.

Signed-off-by: Jesper Nilsson <[EMAIL PROTECTED]>

---
 atomic.h |1 +
 1 file changed, 1 insertion(+)

diff -urBb -X /h/jespern/.exclude_files 
clean_linux-2.6.23/include/asm-cris/atomic.h 
linux-2.6.23/include/asm-cris/atomic.h
--- clean_linux-2.6.23/include/asm-cris/atomic.h2007-10-09 
22:31:38.0 +0200
+++ linux-2.6.23/include/asm-cris/atomic.h  2007-10-22 10:32:54.0 
+0200
@@ -5,6 +5,7 @@
 
 #include 
 #include 
+#include 
 
 /*
  * Atomic operations that C can't guarantee us.  Useful for
/^JN - Jesper Nilsson
--
   Jesper Nilsson -- [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/