Re: [PATCH 5/8] at12: use pci_zalloc instead of pci_alloc

[Christoph Hellwig]

On Tue, Feb 26, 2019 at 10:09:52PM -0800, Robert Eshleman wrote:
> This patch replaces a pci_alloc and memset(,0) call
> with a single call to pci_zalloc.

Please don't move from one deprecated API to another one.  If you feel
like cleaning up DMA API calls please move to dma_alloc_coherent,
and do that for the whole DMA API usage.

[PATCH 5/8] at12: use pci_zalloc instead of pci_alloc

[Robert Eshleman]

This patch replaces a pci_alloc and memset(,0) call
with a single call to pci_zalloc.

Signed-off-by: Robert Eshleman 
---
 drivers/net/ethernet/atheros/atlx/atl2.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c 
b/drivers/net/ethernet/atheros/atlx/atl2.c
index bb41becb6609..a145c2d1b1d2 100644
--- a/drivers/net/ethernet/atheros/atlx/atl2.c
+++ b/drivers/net/ethernet/atheros/atlx/atl2.c
@@ -300,11 +300,10 @@ static s32 atl2_setup_ring_resources(struct atl2_adapter 
*adapter)
adapter->txs_ring_size * 4 + 7 +/* dword align */
adapter->rxd_ring_size * 1536 + 127;/* 128bytes align */
 
-   adapter->ring_vir_addr = pci_alloc_consistent(pdev, size,
-   &adapter->ring_dma);
+   adapter->ring_vir_addr = pci_zalloc_consistent(pdev, size,
+  &adapter->ring_dma);
if (!adapter->ring_vir_addr)
return -ENOMEM;
-   memset(adapter->ring_vir_addr, 0, adapter->ring_size);
 
/* Init TXD Ring */
adapter->txd_dma = adapter->ring_dma ;
-- 
2.20.1