Re: [PATCH 6/7] interconnect: qcom: qcs404: Add regmaps and more bus descriptions
Hi Adam,
kernel test robot noticed the following build errors:
[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v6.10-rc3 next-20240607]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Adam-Skladowski/dt-bindings-interconnect-Add-Qualcomm-MSM8976-DT-bindings/20240610-022416
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:
https://lore.kernel.org/r/20240609182112.13032-7-a39.skl%40gmail.com
patch subject: [PATCH 6/7] interconnect: qcom: qcs404: Add regmaps and more bus
descriptions
config: arm64-allmodconfig
(https://download.01.org/0day-ci/archive/20240610/202406102141.1kh3lxfy-...@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project
4403cdbaf01379de96f8d0d6ea4f51a085e37766)
reproduce (this is a W=1 build):
(https://download.01.org/0day-ci/archive/20240610/202406102141.1kh3lxfy-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202406102141.1kh3lxfy-...@intel.com/
All errors (new ones prefixed by >>):
>> drivers/interconnect/qcom/qcs404.c:1070:35: error: variable has incomplete
>> type 'const struct regmap_config'
1070 | static const struct regmap_config qcs404_bimc_regmap_config = {
| ^
drivers/interconnect/qcom/icc-rpm.h:136:15: note: forward declaration of
'struct regmap_config'
136 | const struct regmap_config *regmap_cfg;
| ^
drivers/interconnect/qcom/qcs404.c:1137:35: error: variable has incomplete
type 'const struct regmap_config'
1137 | static const struct regmap_config qcs404_pcnoc_regmap_config = {
| ^
drivers/interconnect/qcom/icc-rpm.h:136:15: note: forward declaration of
'struct regmap_config'
136 | const struct regmap_config *regmap_cfg;
| ^
drivers/interconnect/qcom/qcs404.c:1178:35: error: variable has incomplete
type 'const struct regmap_config'
1178 | static const struct regmap_config qcs404_snoc_regmap_config = {
| ^
drivers/interconnect/qcom/icc-rpm.h:136:15: note: forward declaration of
'struct regmap_config'
136 | const struct regmap_config *regmap_cfg;
| ^
3 errors generated.
vim +1070 drivers/interconnect/qcom/qcs404.c
1069
> 1070 static const struct regmap_config qcs404_bimc_regmap_config = {
1071 .reg_bits = 32,
1072 .reg_stride = 4,
1073 .val_bits = 32,
1074 .max_register = 0x8,
1075 .fast_io = true,
1076 };
1077
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Re: [PATCH 6/7] interconnect: qcom: qcs404: Add regmaps and more bus descriptions
Hi Adam,
kernel test robot noticed the following build errors:
[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v6.10-rc3 next-20240607]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Adam-Skladowski/dt-bindings-interconnect-Add-Qualcomm-MSM8976-DT-bindings/20240610-022416
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:
https://lore.kernel.org/r/20240609182112.13032-7-a39.skl%40gmail.com
patch subject: [PATCH 6/7] interconnect: qcom: qcs404: Add regmaps and more bus
descriptions
config: arm64-defconfig
(https://download.01.org/0day-ci/archive/20240610/202406101715.amp9vwkx-...@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build):
(https://download.01.org/0day-ci/archive/20240610/202406101715.amp9vwkx-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202406101715.amp9vwkx-...@intel.com/
All error/warnings (new ones prefixed by >>):
>> drivers/interconnect/qcom/qcs404.c:1070:21: error: variable
>> 'qcs404_bimc_regmap_config' has initializer but incomplete type
1070 | static const struct regmap_config qcs404_bimc_regmap_config = {
| ^
>> drivers/interconnect/qcom/qcs404.c:1071:10: error: 'const struct
>> regmap_config' has no member named 'reg_bits'
1071 | .reg_bits = 32,
| ^~~~
>> drivers/interconnect/qcom/qcs404.c:1071:21: warning: excess elements in
>> struct initializer
1071 | .reg_bits = 32,
| ^~
drivers/interconnect/qcom/qcs404.c:1071:21: note: (near initialization for
'qcs404_bimc_regmap_config')
>> drivers/interconnect/qcom/qcs404.c:1072:10: error: 'const struct
>> regmap_config' has no member named 'reg_stride'
1072 | .reg_stride = 4,
| ^~
drivers/interconnect/qcom/qcs404.c:1072:23: warning: excess elements in
struct initializer
1072 | .reg_stride = 4,
| ^
drivers/interconnect/qcom/qcs404.c:1072:23: note: (near initialization for
'qcs404_bimc_regmap_config')
>> drivers/interconnect/qcom/qcs404.c:1073:10: error: 'const struct
>> regmap_config' has no member named 'val_bits'
1073 | .val_bits = 32,
| ^~~~
drivers/interconnect/qcom/qcs404.c:1073:21: warning: excess elements in
struct initializer
1073 | .val_bits = 32,
| ^~
drivers/interconnect/qcom/qcs404.c:1073:21: note: (near initialization for
'qcs404_bimc_regmap_config')
>> drivers/interconnect/qcom/qcs404.c:1074:10: error: 'const struct
>> regmap_config' has no member named 'max_register'
1074 | .max_register = 0x8,
| ^~~~
drivers/interconnect/qcom/qcs404.c:1074:25: warning: excess elements in
struct initializer
1074 | .max_register = 0x8,
| ^~~
drivers/interconnect/qcom/qcs404.c:1074:25: note: (near initialization for
'qcs404_bimc_regmap_config')
>> drivers/interconnect/qcom/qcs404.c:1075:10: error: 'const struct
>> regmap_config' has no member named 'fast_io'
1075 | .fast_io = true,
| ^~~
drivers/interconnect/qcom/qcs404.c:1075:20: warning: excess elements in
struct initializer
1075 | .fast_io = true,
|^~~~
drivers/interconnect/qcom/qcs404.c:1075:20: note: (near initialization for
'qcs404_bimc_regmap_config')
>> drivers/interconnect/qcom/qcs404.c:1137:21: error: variable
>> 'qcs404_pcnoc_regmap_config' has initializer but incomplete type
1137 | static const struct regmap_config qcs404_pcnoc_regmap_config = {
| ^
drivers/interconnect/qcom/qcs404.c:1138:10: error: 'const struct
regmap_config' has no member named 'reg_bits'
1138 | .reg_bits = 32,
| ^~~~
drivers/interconnect/qcom/qcs404.c:1138:21: warning: excess elements in
struct initializer
1138 | .reg_bits = 32,
| ^~
drivers/interconnect/qcom/qcs404.c:1138:21: note: (near initialization for
'qcs404_pcnoc_regmap_config')
drivers/interconnect/qcom/qcs404.c:1139:10: error: 'const struct
regmap_config' has no member named 'reg_stride'
1139 | .reg_stride = 4,
| ^~
drivers/interconnect/qco
[PATCH 6/7] interconnect: qcom: qcs404: Add regmaps and more bus descriptions
Currently we are lacking descriptions of regmaps and buses,
provide them.
Signed-off-by: Adam Skladowski
---
drivers/interconnect/qcom/qcs404.c | 41 +++---
1 file changed, 38 insertions(+), 3 deletions(-)
diff --git a/drivers/interconnect/qcom/qcs404.c
b/drivers/interconnect/qcom/qcs404.c
index 91b2ccc56a33..f9b508a56588 100644
--- a/drivers/interconnect/qcom/qcs404.c
+++ b/drivers/interconnect/qcom/qcs404.c
@@ -1067,10 +1067,22 @@ static struct qcom_icc_node * const qcs404_bimc_nodes[]
= {
[SLAVE_BIMC_SNOC] = _bimc_snoc,
};
+static const struct regmap_config qcs404_bimc_regmap_config = {
+ .reg_bits = 32,
+ .reg_stride = 4,
+ .val_bits = 32,
+ .max_register = 0x8,
+ .fast_io = true,
+};
+
static const struct qcom_icc_desc qcs404_bimc = {
- .bus_clk_desc = _clk,
+ .type = QCOM_ICC_BIMC,
.nodes = qcs404_bimc_nodes,
.num_nodes = ARRAY_SIZE(qcs404_bimc_nodes),
+ .bus_clk_desc = _clk,
+ .regmap_cfg = _bimc_regmap_config,
+ .qos_offset = 0x8000,
+ .ab_coeff = 153,
};
static struct qcom_icc_node * const qcs404_pcnoc_nodes[] = {
@@ -1122,10 +1134,22 @@ static struct qcom_icc_node * const
qcs404_pcnoc_nodes[] = {
[SLAVE_PCNOC_SNOC] = _pcnoc_snoc,
};
+static const struct regmap_config qcs404_pcnoc_regmap_config = {
+ .reg_bits = 32,
+ .reg_stride = 4,
+ .val_bits = 32,
+ .max_register = 0x15080,
+ .fast_io = true,
+};
+
static const struct qcom_icc_desc qcs404_pcnoc = {
- .bus_clk_desc = _0_clk,
+ .type = QCOM_ICC_NOC,
.nodes = qcs404_pcnoc_nodes,
.num_nodes = ARRAY_SIZE(qcs404_pcnoc_nodes),
+ .bus_clk_desc = _0_clk,
+ .qos_offset = 0x7000,
+ .keep_alive = true,
+ .regmap_cfg = _pcnoc_regmap_config,
};
static struct qcom_icc_node * const qcs404_snoc_nodes[] = {
@@ -1151,10 +1175,21 @@ static struct qcom_icc_node * const qcs404_snoc_nodes[]
= {
[SLAVE_LPASS] = _lpass,
};
+static const struct regmap_config qcs404_snoc_regmap_config = {
+ .reg_bits = 32,
+ .reg_stride = 4,
+ .val_bits = 32,
+ .max_register = 0x23080,
+ .fast_io = true,
+};
+
static const struct qcom_icc_desc qcs404_snoc = {
- .bus_clk_desc = _1_clk,
+ .type = QCOM_ICC_NOC,
.nodes = qcs404_snoc_nodes,
.num_nodes = ARRAY_SIZE(qcs404_snoc_nodes),
+ .bus_clk_desc = _1_clk,
+ .qos_offset = 0x11000,
+ .regmap_cfg = _snoc_regmap_config,
};
--
2.45.1
