Re: [PATCH 6/8] sched: rename load_balance_tmpmask to load_balance_cpu_active
On Tue, Mar 19, 2013 at 04:01:01PM +0100, Peter Zijlstra wrote: > On Thu, 2013-02-14 at 14:48 +0900, Joonsoo Kim wrote: > > This name doesn't represent specific meaning. > > So rename it to imply it's purpose. > > > > Signed-off-by: Joonsoo Kim > > > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > index 26058d0..e6f8783 100644 > > --- a/kernel/sched/core.c > > +++ b/kernel/sched/core.c > > @@ -6814,7 +6814,7 @@ struct task_group root_task_group; > > LIST_HEAD(task_groups); > > #endif > > > > -DECLARE_PER_CPU(cpumask_var_t, load_balance_tmpmask); > > +DECLARE_PER_CPU(cpumask_var_t, load_balance_cpu_active); > > That's not much better; how about we call it: load_balance_mask. Okay, in next spin, I will call it as load_balance_mask. Thanks. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] sched: rename load_balance_tmpmask to load_balance_cpu_active
On Tue, Mar 19, 2013 at 04:01:01PM +0100, Peter Zijlstra wrote: On Thu, 2013-02-14 at 14:48 +0900, Joonsoo Kim wrote: This name doesn't represent specific meaning. So rename it to imply it's purpose. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 26058d0..e6f8783 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -6814,7 +6814,7 @@ struct task_group root_task_group; LIST_HEAD(task_groups); #endif -DECLARE_PER_CPU(cpumask_var_t, load_balance_tmpmask); +DECLARE_PER_CPU(cpumask_var_t, load_balance_cpu_active); That's not much better; how about we call it: load_balance_mask. Okay, in next spin, I will call it as load_balance_mask. Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] sched: rename load_balance_tmpmask to load_balance_cpu_active
On Thu, 2013-02-14 at 14:48 +0900, Joonsoo Kim wrote: > This name doesn't represent specific meaning. > So rename it to imply it's purpose. > > Signed-off-by: Joonsoo Kim > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 26058d0..e6f8783 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -6814,7 +6814,7 @@ struct task_group root_task_group; > LIST_HEAD(task_groups); > #endif > > -DECLARE_PER_CPU(cpumask_var_t, load_balance_tmpmask); > +DECLARE_PER_CPU(cpumask_var_t, load_balance_cpu_active); That's not much better; how about we call it: load_balance_mask. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] sched: rename load_balance_tmpmask to load_balance_cpu_active
On Thu, 2013-02-14 at 14:48 +0900, Joonsoo Kim wrote: This name doesn't represent specific meaning. So rename it to imply it's purpose. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 26058d0..e6f8783 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -6814,7 +6814,7 @@ struct task_group root_task_group; LIST_HEAD(task_groups); #endif -DECLARE_PER_CPU(cpumask_var_t, load_balance_tmpmask); +DECLARE_PER_CPU(cpumask_var_t, load_balance_cpu_active); That's not much better; how about we call it: load_balance_mask. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 6/8] sched: rename load_balance_tmpmask to load_balance_cpu_active
This name doesn't represent specific meaning.
So rename it to imply it's purpose.
Signed-off-by: Joonsoo Kim
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 26058d0..e6f8783 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6814,7 +6814,7 @@ struct task_group root_task_group;
LIST_HEAD(task_groups);
#endif
-DECLARE_PER_CPU(cpumask_var_t, load_balance_tmpmask);
+DECLARE_PER_CPU(cpumask_var_t, load_balance_cpu_active);
void __init sched_init(void)
{
@@ -6851,7 +6851,7 @@ void __init sched_init(void)
#endif /* CONFIG_RT_GROUP_SCHED */
#ifdef CONFIG_CPUMASK_OFFSTACK
for_each_possible_cpu(i) {
- per_cpu(load_balance_tmpmask, i) = (void *)ptr;
+ per_cpu(load_balance_cpu_active, i) = (void *)ptr;
ptr += cpumask_size();
}
#endif /* CONFIG_CPUMASK_OFFSTACK */
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index bb373f4..7382fa5 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -4974,7 +4974,7 @@ static struct rq *find_busiest_queue(struct lb_env *env,
#define MAX_PINNED_INTERVAL512
/* Working cpumask for load_balance and load_balance_newidle. */
-DEFINE_PER_CPU(cpumask_var_t, load_balance_tmpmask);
+DEFINE_PER_CPU(cpumask_var_t, load_balance_cpu_active);
static int need_active_balance(struct lb_env *env)
{
@@ -5009,7 +5009,7 @@ static int load_balance(int this_cpu, struct rq *this_rq,
struct sched_group *group;
struct rq *busiest;
unsigned long flags;
- struct cpumask *cpus = __get_cpu_var(load_balance_tmpmask);
+ struct cpumask *cpus = __get_cpu_var(load_balance_cpu_active);
struct lb_env env = {
.sd = sd,
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 6/8] sched: rename load_balance_tmpmask to load_balance_cpu_active
This name doesn't represent specific meaning.
So rename it to imply it's purpose.
Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 26058d0..e6f8783 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6814,7 +6814,7 @@ struct task_group root_task_group;
LIST_HEAD(task_groups);
#endif
-DECLARE_PER_CPU(cpumask_var_t, load_balance_tmpmask);
+DECLARE_PER_CPU(cpumask_var_t, load_balance_cpu_active);
void __init sched_init(void)
{
@@ -6851,7 +6851,7 @@ void __init sched_init(void)
#endif /* CONFIG_RT_GROUP_SCHED */
#ifdef CONFIG_CPUMASK_OFFSTACK
for_each_possible_cpu(i) {
- per_cpu(load_balance_tmpmask, i) = (void *)ptr;
+ per_cpu(load_balance_cpu_active, i) = (void *)ptr;
ptr += cpumask_size();
}
#endif /* CONFIG_CPUMASK_OFFSTACK */
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index bb373f4..7382fa5 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -4974,7 +4974,7 @@ static struct rq *find_busiest_queue(struct lb_env *env,
#define MAX_PINNED_INTERVAL512
/* Working cpumask for load_balance and load_balance_newidle. */
-DEFINE_PER_CPU(cpumask_var_t, load_balance_tmpmask);
+DEFINE_PER_CPU(cpumask_var_t, load_balance_cpu_active);
static int need_active_balance(struct lb_env *env)
{
@@ -5009,7 +5009,7 @@ static int load_balance(int this_cpu, struct rq *this_rq,
struct sched_group *group;
struct rq *busiest;
unsigned long flags;
- struct cpumask *cpus = __get_cpu_var(load_balance_tmpmask);
+ struct cpumask *cpus = __get_cpu_var(load_balance_cpu_active);
struct lb_env env = {
.sd = sd,
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
