[PATCH 7/9] irq_work: Warn if there's still work on cpu_down

2012-11-17 Thread Frederic Weisbecker
From: Steven Rostedt 

If we are in nohz and there's still irq_work to be done when the idle
task is about to go offline, give a nasty warning. Everything should
have been flushed from the CPU_DYING notifier already. Further attempts
to enqueue an irq_work are buggy because irqs are disabled by
__cpu_disable(). The best we can do is to report the issue to the user.

Signed-off-by: Steven Rostedt 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Cc: Ingo Molnar 
Cc: Andrew Morton 
Cc: Paul Gortmaker 
Signed-off-by: Frederic Weisbecker 
---
 kernel/irq_work.c |3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/kernel/irq_work.c b/kernel/irq_work.c
index 4ed1749..480f747 100644
--- a/kernel/irq_work.c
+++ b/kernel/irq_work.c
@@ -109,6 +109,9 @@ bool irq_work_needs_cpu(void)
if (llist_empty(this_list))
return false;
 
+   /* All work should have been flushed before going offline */
+   WARN_ON_ONCE(cpu_is_offline(smp_processor_id()));
+
return true;
 }
 
-- 
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 7/9] irq_work: Warn if there's still work on cpu_down

2012-11-15 Thread Frederic Weisbecker
From: Steven Rostedt 

If we are in nohz and there's still irq_work to be done when the idle
task is about to go offline, give a nasty warning. Everything should
have been flushed from the CPU_DYING notifier already. Further attempts
to enqueue an irq_work are buggy because irqs are disabled by
__cpu_disable(). The best we can do is to report the issue to the user.

Signed-off-by: Steven Rostedt 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Cc: Ingo Molnar 
Cc: Andrew Morton 
Cc: Paul Gortmaker 
Signed-off-by: Frederic Weisbecker 
---
 kernel/irq_work.c |3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/kernel/irq_work.c b/kernel/irq_work.c
index cf8b657..fcaadae 100644
--- a/kernel/irq_work.c
+++ b/kernel/irq_work.c
@@ -108,6 +108,9 @@ bool irq_work_needs_cpu(void)
if (llist_empty(this_list))
return false;
 
+   /* All work should have been flushed before going offline */
+   WARN_ON_ONCE(cpu_is_offline(smp_processor_id()));
+
return true;
 }
 
-- 
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/