Re: [PATCH 7/9] staging: sm750fb: fix block comment style issues in ddk750_chip.c
Will do. Thanks On 30 August 2016 at 22:19, Joe Percheswrote: > On Tue, 2016-08-30 at 22:05 +0300, Moshe Green wrote: >> Fix block comment * prefix and trailing */ warnings found >> by the checkpatch.pl tool in ddk750_chip.c. > [] >> diff --git a/drivers/staging/sm750fb/ddk750_chip.c >> b/drivers/staging/sm750fb/ddk750_chip.c > [] >> @@ -320,8 +320,10 @@ unsigned int calcPllValue(unsigned int request_orig, >> pll_value_t *pll) >> int max_d = 6; >> >> if (getChipType() == SM750LE) { >> - /* SM750LE don't have prgrammable PLL and M/N values to work >> on. >> - Just return the requested clock. */ >> + /* SM750LE don't have >> + * prgrammable PLL and M/N values to work on > > Might as well fix the programmable typo too. >
Re: [PATCH 7/9] staging: sm750fb: fix block comment style issues in ddk750_chip.c
Will do. Thanks On 30 August 2016 at 22:19, Joe Perches wrote: > On Tue, 2016-08-30 at 22:05 +0300, Moshe Green wrote: >> Fix block comment * prefix and trailing */ warnings found >> by the checkpatch.pl tool in ddk750_chip.c. > [] >> diff --git a/drivers/staging/sm750fb/ddk750_chip.c >> b/drivers/staging/sm750fb/ddk750_chip.c > [] >> @@ -320,8 +320,10 @@ unsigned int calcPllValue(unsigned int request_orig, >> pll_value_t *pll) >> int max_d = 6; >> >> if (getChipType() == SM750LE) { >> - /* SM750LE don't have prgrammable PLL and M/N values to work >> on. >> - Just return the requested clock. */ >> + /* SM750LE don't have >> + * prgrammable PLL and M/N values to work on > > Might as well fix the programmable typo too. >
Re: [PATCH 7/9] staging: sm750fb: fix block comment style issues in ddk750_chip.c
On Tue, 2016-08-30 at 22:05 +0300, Moshe Green wrote: > Fix block comment * prefix and trailing */ warnings found > by the checkpatch.pl tool in ddk750_chip.c. [] > diff --git a/drivers/staging/sm750fb/ddk750_chip.c > b/drivers/staging/sm750fb/ddk750_chip.c [] > @@ -320,8 +320,10 @@ unsigned int calcPllValue(unsigned int request_orig, > pll_value_t *pll) > int max_d = 6; > > if (getChipType() == SM750LE) { > - /* SM750LE don't have prgrammable PLL and M/N values to work on. > - Just return the requested clock. */ > + /* SM750LE don't have > + * prgrammable PLL and M/N values to work on Might as well fix the programmable typo too.
Re: [PATCH 7/9] staging: sm750fb: fix block comment style issues in ddk750_chip.c
On Tue, 2016-08-30 at 22:05 +0300, Moshe Green wrote: > Fix block comment * prefix and trailing */ warnings found > by the checkpatch.pl tool in ddk750_chip.c. [] > diff --git a/drivers/staging/sm750fb/ddk750_chip.c > b/drivers/staging/sm750fb/ddk750_chip.c [] > @@ -320,8 +320,10 @@ unsigned int calcPllValue(unsigned int request_orig, > pll_value_t *pll) > int max_d = 6; > > if (getChipType() == SM750LE) { > - /* SM750LE don't have prgrammable PLL and M/N values to work on. > - Just return the requested clock. */ > + /* SM750LE don't have > + * prgrammable PLL and M/N values to work on Might as well fix the programmable typo too.
[PATCH 7/9] staging: sm750fb: fix block comment style issues in ddk750_chip.c
Fix block comment * prefix and trailing */ warnings found by the checkpatch.pl tool in ddk750_chip.c. Signed-off-by: Moshe Green--- drivers/staging/sm750fb/ddk750_chip.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index 5e954ea..c59fe22 100644 --- a/drivers/staging/sm750fb/ddk750_chip.c +++ b/drivers/staging/sm750fb/ddk750_chip.c @@ -320,8 +320,10 @@ unsigned int calcPllValue(unsigned int request_orig, pll_value_t *pll) int max_d = 6; if (getChipType() == SM750LE) { - /* SM750LE don't have prgrammable PLL and M/N values to work on. - Just return the requested clock. */ + /* SM750LE don't have +* prgrammable PLL and M/N values to work on. +* Just return the requested clock. +*/ return request_orig; } -- 2.7.4
[PATCH 7/9] staging: sm750fb: fix block comment style issues in ddk750_chip.c
Fix block comment * prefix and trailing */ warnings found by the checkpatch.pl tool in ddk750_chip.c. Signed-off-by: Moshe Green --- drivers/staging/sm750fb/ddk750_chip.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index 5e954ea..c59fe22 100644 --- a/drivers/staging/sm750fb/ddk750_chip.c +++ b/drivers/staging/sm750fb/ddk750_chip.c @@ -320,8 +320,10 @@ unsigned int calcPllValue(unsigned int request_orig, pll_value_t *pll) int max_d = 6; if (getChipType() == SM750LE) { - /* SM750LE don't have prgrammable PLL and M/N values to work on. - Just return the requested clock. */ + /* SM750LE don't have +* prgrammable PLL and M/N values to work on. +* Just return the requested clock. +*/ return request_orig; } -- 2.7.4