Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash
On 2013/5/28 23:29, Andy Shevchenko wrote: > This is good fix, but I rather prefer not to see it in this shape. > See comments below. > > On Wed, May 22, 2013 at 6:51 AM, Libo Chen > wrote: >> >> mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not >> its member. >> >> Signed-off-by: Libo Chen >> Acked-by: Rafał Miłecki >> --- >> drivers/mtd/devices/bcm47xxsflash.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> * add Acked-by: Rafał Miłecki >> * change send list >> >> diff --git a/drivers/mtd/devices/bcm47xxsflash.c >> b/drivers/mtd/devices/bcm47xxsflash.c >> index 9526628..4aa9141 100644 >> --- a/drivers/mtd/devices/bcm47xxsflash.c >> +++ b/drivers/mtd/devices/bcm47xxsflash.c >> @@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device >> *pdev) >> return 0; >> >> err_dev_reg: >> - kfree(>mtd); >> + kfree(b47s); >> out: >> return err; >> } > > What about to switch to devm_* and remove those labels and kfrees at all? > > Additionally you can add another patch to use module_platform_driver() > macro instead of module_init/exit. > ok, I will update later. thanks, Libo > -- > With Best Regards, > Andy Shevchenko > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash
This is good fix, but I rather prefer not to see it in this shape. See comments below. On Wed, May 22, 2013 at 6:51 AM, Libo Chen wrote: > > mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its > member. > > Signed-off-by: Libo Chen > Acked-by: Rafał Miłecki > --- > drivers/mtd/devices/bcm47xxsflash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > * add Acked-by: Rafał Miłecki > * change send list > > diff --git a/drivers/mtd/devices/bcm47xxsflash.c > b/drivers/mtd/devices/bcm47xxsflash.c > index 9526628..4aa9141 100644 > --- a/drivers/mtd/devices/bcm47xxsflash.c > +++ b/drivers/mtd/devices/bcm47xxsflash.c > @@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device > *pdev) > return 0; > > err_dev_reg: > - kfree(>mtd); > + kfree(b47s); > out: > return err; > } What about to switch to devm_* and remove those labels and kfrees at all? Additionally you can add another patch to use module_platform_driver() macro instead of module_init/exit. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash
2013/5/28 Libo Chen : > ping... It takes a lot of time for someone to pick up mtd patches, just be patient ;) -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash
ping... On 2013/5/22 11:51, Libo Chen wrote: > > mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its > member. > > Signed-off-by: Libo Chen > Acked-by: Rafał Miłecki > --- > drivers/mtd/devices/bcm47xxsflash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > * add Acked-by: Rafał Miłecki > * change send list > > diff --git a/drivers/mtd/devices/bcm47xxsflash.c > b/drivers/mtd/devices/bcm47xxsflash.c > index 9526628..4aa9141 100644 > --- a/drivers/mtd/devices/bcm47xxsflash.c > +++ b/drivers/mtd/devices/bcm47xxsflash.c > @@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device > *pdev) > return 0; > > err_dev_reg: > - kfree(>mtd); > + kfree(b47s); > out: > return err; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash
ping... On 2013/5/22 11:51, Libo Chen wrote: mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. Signed-off-by: Libo Chen libo.c...@huawei.com Acked-by: Rafał Miłecki zaj...@gmail.com --- drivers/mtd/devices/bcm47xxsflash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) * add Acked-by: Rafał Miłecki zaj...@gmail.com * change send list diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c index 9526628..4aa9141 100644 --- a/drivers/mtd/devices/bcm47xxsflash.c +++ b/drivers/mtd/devices/bcm47xxsflash.c @@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev) return 0; err_dev_reg: - kfree(b47s-mtd); + kfree(b47s); out: return err; } -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash
2013/5/28 Libo Chen clbchenlibo.c...@huawei.com: ping... It takes a lot of time for someone to pick up mtd patches, just be patient ;) -- Rafał -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash
This is good fix, but I rather prefer not to see it in this shape. See comments below. On Wed, May 22, 2013 at 6:51 AM, Libo Chen clbchenlibo.c...@huawei.com wrote: mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. Signed-off-by: Libo Chen libo.c...@huawei.com Acked-by: Rafał Miłecki zaj...@gmail.com --- drivers/mtd/devices/bcm47xxsflash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) * add Acked-by: Rafał Miłecki zaj...@gmail.com * change send list diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c index 9526628..4aa9141 100644 --- a/drivers/mtd/devices/bcm47xxsflash.c +++ b/drivers/mtd/devices/bcm47xxsflash.c @@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev) return 0; err_dev_reg: - kfree(b47s-mtd); + kfree(b47s); out: return err; } What about to switch to devm_* and remove those labels and kfrees at all? Additionally you can add another patch to use module_platform_driver() macro instead of module_init/exit. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash
On 2013/5/28 23:29, Andy Shevchenko wrote: This is good fix, but I rather prefer not to see it in this shape. See comments below. On Wed, May 22, 2013 at 6:51 AM, Libo Chen clbchenlibo.c...@huawei.com wrote: mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. Signed-off-by: Libo Chen libo.c...@huawei.com Acked-by: Rafał Miłecki zaj...@gmail.com --- drivers/mtd/devices/bcm47xxsflash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) * add Acked-by: Rafał Miłecki zaj...@gmail.com * change send list diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c index 9526628..4aa9141 100644 --- a/drivers/mtd/devices/bcm47xxsflash.c +++ b/drivers/mtd/devices/bcm47xxsflash.c @@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev) return 0; err_dev_reg: - kfree(b47s-mtd); + kfree(b47s); out: return err; } What about to switch to devm_* and remove those labels and kfrees at all? Additionally you can add another patch to use module_platform_driver() macro instead of module_init/exit. ok, I will update later. thanks, Libo -- With Best Regards, Andy Shevchenko . -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash
2013/5/22 Libo Chen : > mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its > member. Thanks! -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH RESEND] mtd: fix kfree bcm47xxsflash
mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. Signed-off-by: Libo Chen Acked-by: Rafał Miłecki --- drivers/mtd/devices/bcm47xxsflash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) * add Acked-by: Rafał Miłecki * change send list diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c index 9526628..4aa9141 100644 --- a/drivers/mtd/devices/bcm47xxsflash.c +++ b/drivers/mtd/devices/bcm47xxsflash.c @@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev) return 0; err_dev_reg: - kfree(>mtd); + kfree(b47s); out: return err; } -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH RESEND] mtd: fix kfree bcm47xxsflash
mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. Signed-off-by: Libo Chen libo.c...@huawei.com Acked-by: Rafał Miłecki zaj...@gmail.com --- drivers/mtd/devices/bcm47xxsflash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) * add Acked-by: Rafał Miłecki zaj...@gmail.com * change send list diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c index 9526628..4aa9141 100644 --- a/drivers/mtd/devices/bcm47xxsflash.c +++ b/drivers/mtd/devices/bcm47xxsflash.c @@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev) return 0; err_dev_reg: - kfree(b47s-mtd); + kfree(b47s); out: return err; } -- 1.8.1.2 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash
2013/5/22 Libo Chen clbchenlibo.c...@huawei.com: mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. Thanks! -- Rafał -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
