Re: [PATCH RESEND 0/8] use platform_{get,set}_drvdata()
On 08/14/2013 07:36 AM, Libo Chen wrote: We can use the wrapper functions platform_{get,set}_drvdata() instead of dev_{get,set}_drvdata() with >dev, it is convenient for user. Also, unnecessary dev_set_drvdata() is removed, because the driver core clears the driver data to NULL after device_release or on probe failure. Saying "also" in the changelog is usually a good sign that the patch should be split. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RESEND 0/8] use platform_{get,set}_drvdata()
On 08/14/2013 07:36 AM, Libo Chen wrote: We can use the wrapper functions platform_{get,set}_drvdata() instead of dev_{get,set}_drvdata() with pdev-dev, it is convenient for user. Also, unnecessary dev_set_drvdata() is removed, because the driver core clears the driver data to NULL after device_release or on probe failure. Saying also in the changelog is usually a good sign that the patch should be split. WBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH RESEND 0/8] use platform_{get,set}_drvdata()
We can use the wrapper functions platform_{get,set}_drvdata() instead of dev_{get,set}_drvdata() with >dev, it is convenient for user. Also, unnecessary dev_set_drvdata() is removed, because the driver core clears the driver data to NULL after device_release or on probe failure. changelog: this version add modify record about dev_set_drvdata(). Libo Chen (8): net: fsl_pq_mdio: use platform_{get,set}_drvdata() net: ucc_geth: use platform_{get,set}_drvdata() net: fec_mpc52xx_phy: use platform_{get,set}_drvdata() net: fs_enet: remove unnecessary dev_set_drvdata() net: sunbmac: use platform_{get,set}_drvdata() net: sunhme: use platform_{get,set}_drvdata() net: xilinx_emaclite: use platform_{get,set}_drvdata() net: davinci_mdio: use platform_{get,set}_drvdata() drivers/net/ethernet/freescale/fec_mpc52xx_phy.c |4 +--- drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c |1 - drivers/net/ethernet/freescale/fsl_pq_mdio.c |3 +-- drivers/net/ethernet/freescale/ucc_geth.c |4 +--- drivers/net/ethernet/sun/sunbmac.c |3 +-- drivers/net/ethernet/sun/sunhme.c |8 +++- drivers/net/ethernet/ti/davinci_mdio.c |4 +--- drivers/net/ethernet/xilinx/xilinx_emaclite.c |4 +--- 8 files changed, 9 insertions(+), 22 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH RESEND 0/8] use platform_{get,set}_drvdata()
We can use the wrapper functions platform_{get,set}_drvdata() instead of dev_{get,set}_drvdata() with pdev-dev, it is convenient for user. Also, unnecessary dev_set_drvdata() is removed, because the driver core clears the driver data to NULL after device_release or on probe failure. changelog: this version add modify record about dev_set_drvdata(). Libo Chen (8): net: fsl_pq_mdio: use platform_{get,set}_drvdata() net: ucc_geth: use platform_{get,set}_drvdata() net: fec_mpc52xx_phy: use platform_{get,set}_drvdata() net: fs_enet: remove unnecessary dev_set_drvdata() net: sunbmac: use platform_{get,set}_drvdata() net: sunhme: use platform_{get,set}_drvdata() net: xilinx_emaclite: use platform_{get,set}_drvdata() net: davinci_mdio: use platform_{get,set}_drvdata() drivers/net/ethernet/freescale/fec_mpc52xx_phy.c |4 +--- drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c |1 - drivers/net/ethernet/freescale/fsl_pq_mdio.c |3 +-- drivers/net/ethernet/freescale/ucc_geth.c |4 +--- drivers/net/ethernet/sun/sunbmac.c |3 +-- drivers/net/ethernet/sun/sunhme.c |8 +++- drivers/net/ethernet/ti/davinci_mdio.c |4 +--- drivers/net/ethernet/xilinx/xilinx_emaclite.c |4 +--- 8 files changed, 9 insertions(+), 22 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/