RE: [EXT] Re: [PATCH RESEND V11 4/4] arm64: dts: imx: add i.MX8QXP thermal support

2019-04-15 Thread Anson Huang 
Hi, Daniel

Best Regards!
Anson Huang

> -Original Message-
> 
> 
> On 10/04/2019 09:43, Anson Huang wrote:
> > Add i.MX8QXP CPU thermal zone support.
> >
> > Signed-off-by: Anson Huang 
> > ---
> > Changes since V10:
> >   - remove property "imx,sensor-resource-id" and put HW resource ID
> inside each
> > thermal-sensors' phandle argument.
> > ---
> >  arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 33
> > ++
> >  1 file changed, 33 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > index 70ef3db..cc1d877 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > @@ -10,6 +10,7 @@
> >  #include 
> >  #include 
> >  #include 
> > +#include 
> >
> >  / {
> >   interrupt-parent = <&gic>;
> > @@ -149,6 +150,11 @@
> >   rtc: rtc {
> >   compatible = "fsl,imx8qxp-sc-rtc";
> >   };
> > +
> > + tsens: thermal-sensor {
> > + compatible = "fsl,imx8qxp-sc-thermal", 
> > "fsl,imx-sc-thermal";
> > + #thermal-sensor-cells = <1>;
> > + };
> >   };
> >
> >   timer {
> > @@ -484,4 +490,31 @@
> >   power-domains = <&pd IMX_SC_R_GPIO_7>;
> >   };
> >   };
> > +
> > + thermal_zones: thermal-zones {
> > + cpu-thermal0 {
> > + polling-delay-passive = <250>;
> > + polling-delay = <2000>;
> > + thermal-sensors = <&tsens IMX_SC_R_SYSTEM>;
> > + trips {
> > + cpu_alert0: trip0 {
> > + temperature = <107000>;
> > + hysteresis = <2000>;
> > + type = "passive";
> > + };
> > + cpu_crit0: trip1 {
> > + temperature = <127000>;
> > + hysteresis = <2000>;
> > + type = "critical";
> > + };
> > + };
> > + cooling-maps {
> > + map0 {
> > + trip = <&cpu_alert0>;
> > + cooling-device =
> > + <&A35_0 THERMAL_NO_LIMIT
> > + THERMAL_NO_LIMIT>;
> 
> <&A35_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&A35_1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&A35_2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&A35_3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> 

Fix it in V12, thanks.

Anson.

> 
> > + };
> > + };
> > + };
> > + };
> >  };
> >
> 
> 
> --
> 
>  linaro.org%2F&data=02%7C01%7Canson.huang%40nxp.com%7Cfca87d
> aa526949586d3608d6c1def467%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C
> 0%7C0%7C636909560658582260&sdata=zJ9pZFVN94TN3tci4sut9A%2Bz
> bnDklZjxy9dwEXCssHk%3D&reserved=0> Linaro.org │ Open source
> software for ARM SoCs
> 
> Follow Linaro:
>  facebook.com%2Fpages%2FLinaro&data=02%7C01%7Canson.huang%4
> 0nxp.com%7Cfca87daa526949586d3608d6c1def467%7C686ea1d3bc2b4c6fa9
> 2cd99c5c301635%7C0%7C0%7C636909560658582260&sdata=8U9ZV3uL
> dMfzRitq1cl4tvxpFakxFNGW0TDZ42wDuEc%3D&reserved=0> Facebook
> |
>  r.com%2F%23!%2Flinaroorg&data=02%7C01%7Canson.huang%40nxp.c
> om%7Cfca87daa526949586d3608d6c1def467%7C686ea1d3bc2b4c6fa92cd99
> c5c301635%7C0%7C0%7C636909560658582260&sdata=lJ5yngMoW3ELI
> xYQaASAtvGXdNVDxH5BWoKSLwRL0mM%3D&reserved=0> Twitter |
>  linaro.org%2Flinaro-
> blog%2F&data=02%7C01%7Canson.huang%40nxp.com%7Cfca87daa526
> 949586d3608d6c1def467%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C
> 0%7C636909560658582260&sdata=hBTpeBSg7JGk0qHbC7DEp2JgN7sVq
> yhC2uzBAG%2BP01s%3D&reserved=0> Blog

Re: [PATCH RESEND V11 4/4] arm64: dts: imx: add i.MX8QXP thermal support

2019-04-15 Thread Daniel Lezcano 
On 10/04/2019 09:43, Anson Huang wrote:
> Add i.MX8QXP CPU thermal zone support.
> 
> Signed-off-by: Anson Huang 
> ---
> Changes since V10:
>   - remove property "imx,sensor-resource-id" and put HW resource ID 
> inside each
> thermal-sensors' phandle argument.
> ---
>  arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 33 
> ++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi 
> b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 70ef3db..cc1d877 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -10,6 +10,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  
>  / {
>   interrupt-parent = <&gic>;
> @@ -149,6 +150,11 @@
>   rtc: rtc {
>   compatible = "fsl,imx8qxp-sc-rtc";
>   };
> +
> + tsens: thermal-sensor {
> + compatible = "fsl,imx8qxp-sc-thermal", 
> "fsl,imx-sc-thermal";
> + #thermal-sensor-cells = <1>;
> + };
>   };
>  
>   timer {
> @@ -484,4 +490,31 @@
>   power-domains = <&pd IMX_SC_R_GPIO_7>;
>   };
>   };
> +
> + thermal_zones: thermal-zones {
> + cpu-thermal0 {
> + polling-delay-passive = <250>;
> + polling-delay = <2000>;
> + thermal-sensors = <&tsens IMX_SC_R_SYSTEM>;
> + trips {
> + cpu_alert0: trip0 {
> + temperature = <107000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> + cpu_crit0: trip1 {
> + temperature = <127000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> + cooling-maps {
> + map0 {
> + trip = <&cpu_alert0>;
> + cooling-device =
> + <&A35_0 THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>;

<&A35_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
<&A35_1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
<&A35_2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
<&A35_3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;


> + };
> + };
> + };
> + };
>  };
> 


-- 
  Linaro.org │ Open source software for ARM SoCs

Follow Linaro:   Facebook |
 Twitter |
 Blog

Re: [PATCH RESEND V11 4/4] arm64: dts: imx: add i.MX8QXP thermal support

2019-04-10 Thread Rob Herring 
:u?w]

[PATCH RESEND V11 4/4] arm64: dts: imx: add i.MX8QXP thermal support

2019-04-10 Thread Anson Huang 
Add i.MX8QXP CPU thermal zone support.

Signed-off-by: Anson Huang 
---
Changes since V10:
- remove property "imx,sensor-resource-id" and put HW resource ID 
inside each
  thermal-sensors' phandle argument.
---
 arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 33 ++
 1 file changed, 33 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi 
b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
index 70ef3db..cc1d877 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
@@ -10,6 +10,7 @@
 #include 
 #include 
 #include 
+#include 
 
 / {
interrupt-parent = <&gic>;
@@ -149,6 +150,11 @@
rtc: rtc {
compatible = "fsl,imx8qxp-sc-rtc";
};
+
+   tsens: thermal-sensor {
+   compatible = "fsl,imx8qxp-sc-thermal", 
"fsl,imx-sc-thermal";
+   #thermal-sensor-cells = <1>;
+   };
};
 
timer {
@@ -484,4 +490,31 @@
power-domains = <&pd IMX_SC_R_GPIO_7>;
};
};
+
+   thermal_zones: thermal-zones {
+   cpu-thermal0 {
+   polling-delay-passive = <250>;
+   polling-delay = <2000>;
+   thermal-sensors = <&tsens IMX_SC_R_SYSTEM>;
+   trips {
+   cpu_alert0: trip0 {
+   temperature = <107000>;
+   hysteresis = <2000>;
+   type = "passive";
+   };
+   cpu_crit0: trip1 {
+   temperature = <127000>;
+   hysteresis = <2000>;
+   type = "critical";
+   };
+   };
+   cooling-maps {
+   map0 {
+   trip = <&cpu_alert0>;
+   cooling-device =
+   <&A35_0 THERMAL_NO_LIMIT 
THERMAL_NO_LIMIT>;
+   };
+   };
+   };
+   };
 };
-- 
2.7.4