Re: [PATCH RFC v3 05/35] mm: cma: Don't append newline when generating CMA area name
Hi, On Mon, Jan 29, 2024 at 02:43:08PM +0530, Anshuman Khandual wrote: > > On 1/25/24 22:12, Alexandru Elisei wrote: > > cma->name is displayed in several CMA messages. When the name is generated > > by the CMA code, don't append a newline to avoid breaking the text across > > two lines. > > An example of such mis-formatted CMA output from dmesg could be added > here in the commit message to demonstrate the problem better. > > > > > Signed-off-by: Alexandru Elisei > > --- > > Regardless, LGTM. > > Reviewed-by: Anshuman Khandual Thanks! > > > > > Changes since rfc v2: > > > > * New patch. This is a fix, and can be merged independently of the other > > patches. > > Right, need not be part of this series. Hence please send it separately to > the MM list. Will do! Alex > > > > > mm/cma.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/cma.c b/mm/cma.c > > index 7c09c47e530b..f49c95f8ee37 100644 > > --- a/mm/cma.c > > +++ b/mm/cma.c > > @@ -204,7 +204,7 @@ int __init cma_init_reserved_mem(phys_addr_t base, > > phys_addr_t size, > > if (name) > > snprintf(cma->name, CMA_MAX_NAME, name); > > else > > - snprintf(cma->name, CMA_MAX_NAME, "cma%d\n", cma_area_count); > > + snprintf(cma->name, CMA_MAX_NAME, "cma%d", cma_area_count); > > > > cma->base_pfn = PFN_DOWN(base); > > cma->count = size >> PAGE_SHIFT;
Re: [PATCH RFC v3 05/35] mm: cma: Don't append newline when generating CMA area name
On 1/25/24 22:12, Alexandru Elisei wrote: > cma->name is displayed in several CMA messages. When the name is generated > by the CMA code, don't append a newline to avoid breaking the text across > two lines. An example of such mis-formatted CMA output from dmesg could be added here in the commit message to demonstrate the problem better. > > Signed-off-by: Alexandru Elisei > --- Regardless, LGTM. Reviewed-by: Anshuman Khandual > > Changes since rfc v2: > > * New patch. This is a fix, and can be merged independently of the other > patches. Right, need not be part of this series. Hence please send it separately to the MM list. > > mm/cma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/cma.c b/mm/cma.c > index 7c09c47e530b..f49c95f8ee37 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -204,7 +204,7 @@ int __init cma_init_reserved_mem(phys_addr_t base, > phys_addr_t size, > if (name) > snprintf(cma->name, CMA_MAX_NAME, name); > else > - snprintf(cma->name, CMA_MAX_NAME, "cma%d\n", cma_area_count); > + snprintf(cma->name, CMA_MAX_NAME, "cma%d", cma_area_count); > > cma->base_pfn = PFN_DOWN(base); > cma->count = size >> PAGE_SHIFT;
[PATCH RFC v3 05/35] mm: cma: Don't append newline when generating CMA area name
cma->name is displayed in several CMA messages. When the name is generated by the CMA code, don't append a newline to avoid breaking the text across two lines. Signed-off-by: Alexandru Elisei --- Changes since rfc v2: * New patch. This is a fix, and can be merged independently of the other patches. mm/cma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/cma.c b/mm/cma.c index 7c09c47e530b..f49c95f8ee37 100644 --- a/mm/cma.c +++ b/mm/cma.c @@ -204,7 +204,7 @@ int __init cma_init_reserved_mem(phys_addr_t base, phys_addr_t size, if (name) snprintf(cma->name, CMA_MAX_NAME, name); else - snprintf(cma->name, CMA_MAX_NAME, "cma%d\n", cma_area_count); + snprintf(cma->name, CMA_MAX_NAME, "cma%d", cma_area_count); cma->base_pfn = PFN_DOWN(base); cma->count = size >> PAGE_SHIFT; -- 2.43.0
