Re: [PATCH Resend v0 0/6] Mediatek pinctrl patch on mt8195
On Mon, Mar 29, 2021 at 2:49 PM zhiyong tao wrote: > On Mon, 2021-03-29 at 14:35 +0300, Andy Shevchenko wrote: > > On Mon, Mar 29, 2021 at 2:32 PM Zhiyong Tao > > wrote: > > > > > > This series includes 6 patches: > > > 1.add pinctrl file on mt8195. > > > 2.add pinctrl binding document on mt8195. > > > 3.add pinctrl device node on mt8195. > > > 4.add pinctrl driver on MT8195. > > > 5.add pinctrl drive for I2C related pins on MT8195. > > > 6.add pinctrl rsel setting on MT8195. > > > > Patch series w/o version is de facto v1. > > Dropping to v0 seems not right. > > You missed changelog. > > > > So, send v2 properly. > > > > Material to study: > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html > > > > Hi Andy, > > There is not any change between v0 and v1. so we send "Resend v0" as v2 > in this time.Is it also properly? and we send the version which is v3 in > next time. Sounds good to me, just make sure you put a changelog explaining all these history twists. -- With Best Regards, Andy Shevchenko
Re: [PATCH Resend v0 0/6] Mediatek pinctrl patch on mt8195
On Mon, 2021-03-29 at 14:35 +0300, Andy Shevchenko wrote: > On Mon, Mar 29, 2021 at 2:32 PM Zhiyong Tao wrote: > > > > This series includes 6 patches: > > 1.add pinctrl file on mt8195. > > 2.add pinctrl binding document on mt8195. > > 3.add pinctrl device node on mt8195. > > 4.add pinctrl driver on MT8195. > > 5.add pinctrl drive for I2C related pins on MT8195. > > 6.add pinctrl rsel setting on MT8195. > > Patch series w/o version is de facto v1. > Dropping to v0 seems not right. > You missed changelog. > > So, send v2 properly. > > Material to study: > https://www.kernel.org/doc/html/latest/process/submitting-patches.html > Hi Andy, There is not any change between v0 and v1. so we send "Resend v0" as v2 in this time.Is it also properly? and we send the version which is v3 in next time. Thanks.
Re: [PATCH Resend v0 0/6] Mediatek pinctrl patch on mt8195
On Mon, Mar 29, 2021 at 2:32 PM Zhiyong Tao wrote: > > This series includes 6 patches: > 1.add pinctrl file on mt8195. > 2.add pinctrl binding document on mt8195. > 3.add pinctrl device node on mt8195. > 4.add pinctrl driver on MT8195. > 5.add pinctrl drive for I2C related pins on MT8195. > 6.add pinctrl rsel setting on MT8195. Patch series w/o version is de facto v1. Dropping to v0 seems not right. You missed changelog. So, send v2 properly. Material to study: https://www.kernel.org/doc/html/latest/process/submitting-patches.html -- With Best Regards, Andy Shevchenko
[PATCH Resend v0 0/6] Mediatek pinctrl patch on mt8195
This series includes 6 patches: 1.add pinctrl file on mt8195. 2.add pinctrl binding document on mt8195. 3.add pinctrl device node on mt8195. 4.add pinctrl driver on MT8195. 5.add pinctrl drive for I2C related pins on MT8195. 6.add pinctrl rsel setting on MT8195. Zhiyong Tao (6): dt-bindings: pinctrl: mt8195: add pinctrl file dt-bindings: pinctrl: mt8195: add binding document arm64: dts: mt8195: add pinctrl device node pinctrl: add pinctrl driver on mt8195 pinctrl: add drive for I2C related pins on MT8195 pinctrl: add rsel setting on MT8195 .../bindings/pinctrl/pinctrl-mt8195.yaml | 152 ++ arch/arm64/boot/dts/mediatek/mt8195.dtsi | 21 + drivers/pinctrl/mediatek/Kconfig |6 + drivers/pinctrl/mediatek/Makefile |1 + drivers/pinctrl/mediatek/pinctrl-mt8195.c | 872 + .../pinctrl/mediatek/pinctrl-mtk-common-v2.c | 29 + .../pinctrl/mediatek/pinctrl-mtk-common-v2.h | 14 + drivers/pinctrl/mediatek/pinctrl-mtk-mt8195.h | 1669 + drivers/pinctrl/mediatek/pinctrl-paris.c | 16 + include/dt-bindings/pinctrl/mt8195-pinfunc.h | 961 ++ 10 files changed, 3741 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt8195.c create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt8195.h create mode 100644 include/dt-bindings/pinctrl/mt8195-pinfunc.h -- 2.18.0
