Re: [PATCH V1 00/12] LP0 entry and exit support for Tegra210
Hi, By the looks of this you configure wake events but the pmc driver still only configures lp1, which is the same as linux 4 tegra 4.4+ which also doesn't support lp0, if its selected in dts it'll just change it to LP1/SC7 (both have same code path and neither set any lp0 stuff trm says). What confuses me further is that l4t and this ptachset both configure wake events, which I think should only work in LP0 and not LP1 and yet neither have lp0 entry code for t210. I also looked at ATF, whis sets the flags to wake the cpu on interrupts, which would suggest that it only supports lp1 (in deep sleep I dont think them flags would work). Am I missing some important detail here? Two other things, will you be adding full lp0 in later patchets and will they use the bpmp or not?
Re: [PATCH V1 00/12] LP0 entry and exit support for Tegra210
HI All Sorry. Please ignore this as it was sent out accidentally thanks sowjanya On 5/22/19 6:28 PM, Sowjanya Komatineni wrote: This patch series includes Tegra210 deepsleep or LP0 support with deep sleep exit through RTC alarm wake and power button wake events. This series also includes save and restore of PLLs, clocks, OSC contexts for basic LP0 exit. This patch series is doesn't support for 100% suspend/resume to fully functional state and we are working on some more drivers suspend and resume implementations. Sowjanya Komatineni (12): irqchip: tegra: do not disable COP IRQ during suspend pinctrl: tegra: add suspend and resume support clk: tegra: save and restore PLLs state for system clk: tegra: add support for peripheral clock suspend and resume clk: tegra: add support for OSC clock resume clk: tegra: add suspend resume support for DFLL clock clk: tegra: support for Tegra210 clocks suspend-resume soc/tegra: pmc: allow support for more tegra wake models soc/tegra: pmc: add pmc wake support for tegra210 gpio: tegra: implement wake event support for Tegra210 and prior GPIO soc/tegra: pmc: configure tegra deep sleep control settings arm64: tegra: enable wake from deep sleep on RTC alarm. arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 7 + arch/arm64/boot/dts/nvidia/tegra210.dtsi | 5 +- drivers/clk/tegra/clk-dfll.c | 82 ++ drivers/clk/tegra/clk-dfll.h | 2 + drivers/clk/tegra/clk-divider.c| 19 ++ drivers/clk/tegra/clk-pll-out.c| 25 ++ drivers/clk/tegra/clk-pll.c| 220 -- drivers/clk/tegra/clk-tegra-fixed.c| 15 + drivers/clk/tegra/clk-tegra210.c | 382 + drivers/clk/tegra/clk.c| 74 - drivers/clk/tegra/clk.h| 18 ++ drivers/gpio/gpio-tegra.c | 109 ++- drivers/irqchip/irq-tegra.c| 10 +- drivers/pinctrl/tegra/pinctrl-tegra.c | 68 - drivers/pinctrl/tegra/pinctrl-tegra.h | 3 + drivers/pinctrl/tegra/pinctrl-tegra114.c | 1 + drivers/pinctrl/tegra/pinctrl-tegra124.c | 1 + drivers/pinctrl/tegra/pinctrl-tegra20.c| 1 + drivers/pinctrl/tegra/pinctrl-tegra210.c | 1 + drivers/pinctrl/tegra/pinctrl-tegra30.c| 1 + drivers/soc/tegra/pmc.c| 159 +- 21 files changed, 1167 insertions(+), 36 deletions(-)
[PATCH V1 00/12] LP0 entry and exit support for Tegra210
This patch series includes Tegra210 deepsleep or LP0 support with deep sleep exit through RTC alarm wake and power button wake events. This series also includes save and restore of PLLs, clocks, OSC contexts for basic LP0 exit. This patch series is doesn't support for 100% suspend/resume to fully functional state and we are working on some more drivers suspend and resume implementations. Sowjanya Komatineni (12): irqchip: tegra: do not disable COP IRQ during suspend pinctrl: tegra: add suspend and resume support clk: tegra: save and restore PLLs state for system clk: tegra: add support for peripheral clock suspend and resume clk: tegra: add support for OSC clock resume clk: tegra: add suspend resume support for DFLL clock clk: tegra: support for Tegra210 clocks suspend-resume soc/tegra: pmc: allow support for more tegra wake models soc/tegra: pmc: add pmc wake support for tegra210 gpio: tegra: implement wake event support for Tegra210 and prior GPIO soc/tegra: pmc: configure tegra deep sleep control settings arm64: tegra: enable wake from deep sleep on RTC alarm. arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 7 + arch/arm64/boot/dts/nvidia/tegra210.dtsi | 5 +- drivers/clk/tegra/clk-dfll.c | 82 ++ drivers/clk/tegra/clk-dfll.h | 2 + drivers/clk/tegra/clk-divider.c| 19 ++ drivers/clk/tegra/clk-pll-out.c| 25 ++ drivers/clk/tegra/clk-pll.c| 220 -- drivers/clk/tegra/clk-tegra-fixed.c| 15 + drivers/clk/tegra/clk-tegra210.c | 382 + drivers/clk/tegra/clk.c| 74 - drivers/clk/tegra/clk.h| 18 ++ drivers/gpio/gpio-tegra.c | 109 ++- drivers/irqchip/irq-tegra.c| 10 +- drivers/pinctrl/tegra/pinctrl-tegra.c | 68 - drivers/pinctrl/tegra/pinctrl-tegra.h | 3 + drivers/pinctrl/tegra/pinctrl-tegra114.c | 1 + drivers/pinctrl/tegra/pinctrl-tegra124.c | 1 + drivers/pinctrl/tegra/pinctrl-tegra20.c| 1 + drivers/pinctrl/tegra/pinctrl-tegra210.c | 1 + drivers/pinctrl/tegra/pinctrl-tegra30.c| 1 + drivers/soc/tegra/pmc.c| 159 +- 21 files changed, 1167 insertions(+), 36 deletions(-) -- 2.7.4
Re: [PATCH V1 00/12] LP0 entry and exit support for Tegra210
On Tue, May 21, 2019 at 04:31:11PM -0700, Sowjanya Komatineni wrote: > This patch series includes Tegra210 deepsleep or LP0 support with > deep sleep exit through RTC alarm wake and power button wake events. There doesn't seem to be support for waking up from a power button press. Is that in a patch that you didn't send out yet, or are you still working on that? The recipient list on this is very trimmed. I'm not sure if this was on purpose. I'm fine if you want to keep it that way until things settle down a bit, but eventually the subsystem maintainers will need to see these, so make sure to Cc them when you think the patches are ready. Thierry > > This series also includes save and restore of PLLs, clocks, OSC contexts > for basic LP0 exit. > > This patch series is doesn't support for 100% suspend/resume to fully > functional state and we are working on some more drivers suspend and > resume implementations. > > Sowjanya Komatineni (12): > irqchip: tegra: do not disable COP IRQ during suspend > pinctrl: tegra: add suspend and resume support > clk: tegra: save and restore PLLs state for system > clk: tegra: add support for peripheral clock suspend and resume > clk: tegra: add support for OSC clock resume > clk: tegra: add suspend resume support for DFLL clock > clk: tegra: support for Tegra210 clocks suspend-resume > soc/tegra: pmc: allow support for more tegra wake models > soc/tegra: pmc: add pmc wake support for tegra210 > gpio: tegra: implement wake event support for Tegra210 and prior GPIO > soc/tegra: pmc: configure tegra deep sleep control settings > arm64: tegra: enable wake from deep sleep on RTC alarm. > > arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 7 + > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 5 +- > drivers/clk/tegra/clk-dfll.c | 82 ++ > drivers/clk/tegra/clk-dfll.h | 2 + > drivers/clk/tegra/clk-divider.c| 19 ++ > drivers/clk/tegra/clk-pll-out.c| 25 ++ > drivers/clk/tegra/clk-pll.c| 220 -- > drivers/clk/tegra/clk-tegra-fixed.c| 15 + > drivers/clk/tegra/clk-tegra210.c | 382 > + > drivers/clk/tegra/clk.c| 74 - > drivers/clk/tegra/clk.h| 18 ++ > drivers/gpio/gpio-tegra.c | 109 ++- > drivers/irqchip/irq-tegra.c| 10 +- > drivers/pinctrl/tegra/pinctrl-tegra.c | 68 - > drivers/pinctrl/tegra/pinctrl-tegra.h | 3 + > drivers/pinctrl/tegra/pinctrl-tegra114.c | 1 + > drivers/pinctrl/tegra/pinctrl-tegra124.c | 1 + > drivers/pinctrl/tegra/pinctrl-tegra20.c| 1 + > drivers/pinctrl/tegra/pinctrl-tegra210.c | 1 + > drivers/pinctrl/tegra/pinctrl-tegra30.c| 1 + > drivers/soc/tegra/pmc.c| 159 +- > 21 files changed, 1167 insertions(+), 36 deletions(-) > > -- > 2.7.4 > signature.asc Description: PGP signature
[PATCH V1 00/12] LP0 entry and exit support for Tegra210
This patch series includes Tegra210 deepsleep or LP0 support with deep sleep exit through RTC alarm wake and power button wake events. This series also includes save and restore of PLLs, clocks, OSC contexts for basic LP0 exit. This patch series is doesn't support for 100% suspend/resume to fully functional state and we are working on some more drivers suspend and resume implementations. Sowjanya Komatineni (12): irqchip: tegra: do not disable COP IRQ during suspend pinctrl: tegra: add suspend and resume support clk: tegra: save and restore PLLs state for system clk: tegra: add support for peripheral clock suspend and resume clk: tegra: add support for OSC clock resume clk: tegra: add suspend resume support for DFLL clock clk: tegra: support for Tegra210 clocks suspend-resume soc/tegra: pmc: allow support for more tegra wake models soc/tegra: pmc: add pmc wake support for tegra210 gpio: tegra: implement wake event support for Tegra210 and prior GPIO soc/tegra: pmc: configure tegra deep sleep control settings arm64: tegra: enable wake from deep sleep on RTC alarm. arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 7 + arch/arm64/boot/dts/nvidia/tegra210.dtsi | 5 +- drivers/clk/tegra/clk-dfll.c | 82 ++ drivers/clk/tegra/clk-dfll.h | 2 + drivers/clk/tegra/clk-divider.c| 19 ++ drivers/clk/tegra/clk-pll-out.c| 25 ++ drivers/clk/tegra/clk-pll.c| 220 -- drivers/clk/tegra/clk-tegra-fixed.c| 15 + drivers/clk/tegra/clk-tegra210.c | 382 + drivers/clk/tegra/clk.c| 74 - drivers/clk/tegra/clk.h| 18 ++ drivers/gpio/gpio-tegra.c | 109 ++- drivers/irqchip/irq-tegra.c| 10 +- drivers/pinctrl/tegra/pinctrl-tegra.c | 68 - drivers/pinctrl/tegra/pinctrl-tegra.h | 3 + drivers/pinctrl/tegra/pinctrl-tegra114.c | 1 + drivers/pinctrl/tegra/pinctrl-tegra124.c | 1 + drivers/pinctrl/tegra/pinctrl-tegra20.c| 1 + drivers/pinctrl/tegra/pinctrl-tegra210.c | 1 + drivers/pinctrl/tegra/pinctrl-tegra30.c| 1 + drivers/soc/tegra/pmc.c| 159 +- 21 files changed, 1167 insertions(+), 36 deletions(-) -- 2.7.4
