Re: [PATCH V1 3/5] spmi: pmic-arb: replace the writel_relaxed with __raw_writel

2017-07-06 Thread Stephen Boyd 
On 07/03, Kiran Gunda wrote:
> Replace the writel_relaxed with __raw_writel to avoid byte swapping
> in pmic_arb_write_data() function. That way the code is independent
> of the CPU endianness.
> 
> Signed-off-by: Kiran Gunda 
> ---

Reviewed-by: Stephen Boyd 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH V1 3/5] spmi: pmic-arb: replace the writel_relaxed with __raw_writel

2017-07-06 Thread Stephen Boyd 
On 07/03, Kiran Gunda wrote:
> Replace the writel_relaxed with __raw_writel to avoid byte swapping
> in pmic_arb_write_data() function. That way the code is independent
> of the CPU endianness.
> 
> Signed-off-by: Kiran Gunda 
> ---

Reviewed-by: Stephen Boyd 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[PATCH V1 3/5] spmi: pmic-arb: replace the writel_relaxed with __raw_writel

2017-07-03 Thread Kiran Gunda 
Replace the writel_relaxed with __raw_writel to avoid byte swapping
in pmic_arb_write_data() function. That way the code is independent
of the CPU endianness.

Signed-off-by: Kiran Gunda 
---
 drivers/spmi/spmi-pmic-arb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index 1f2ab5c..d8c857a 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -231,7 +231,7 @@ static void pmic_arb_write_data(struct spmi_pmic_arb 
*pmic_arb, const u8 *buf,
u32 data = 0;
 
memcpy(, buf, (bc & 3) + 1);
-   pmic_arb_base_write(pmic_arb, reg, data);
+   __raw_writel(data, pmic_arb->wr_base + reg);
 }
 
 static int pmic_arb_wait_for_done(struct spmi_controller *ctrl,
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

[PATCH V1 3/5] spmi: pmic-arb: replace the writel_relaxed with __raw_writel

2017-07-03 Thread Kiran Gunda 
Replace the writel_relaxed with __raw_writel to avoid byte swapping
in pmic_arb_write_data() function. That way the code is independent
of the CPU endianness.

Signed-off-by: Kiran Gunda 
---
 drivers/spmi/spmi-pmic-arb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index 1f2ab5c..d8c857a 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -231,7 +231,7 @@ static void pmic_arb_write_data(struct spmi_pmic_arb 
*pmic_arb, const u8 *buf,
u32 data = 0;
 
memcpy(, buf, (bc & 3) + 1);
-   pmic_arb_base_write(pmic_arb, reg, data);
+   __raw_writel(data, pmic_arb->wr_base + reg);
 }
 
 static int pmic_arb_wait_for_done(struct spmi_controller *ctrl,
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project