Re: [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys

2017-01-30 Thread Florian Fainelli 
On 01/30/2017 01:08 AM, Aditya Xavier wrote:
> Would you require me to send the revised Patch ?
> 
> Or would this do ?

Will take care of it this time.

> 
> And thanks for guiding me through this process :)
> 
> 
>> On 29-Jan-2017, at 2:45 AM, Rafał Miłecki  wrote:
>>
>> On 28 January 2017 at 15:37, AdityaXavier  wrote:
>>> From: Aditya Xavier 
>>>
>>> Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
>>> V2: Updated subject, Power LED names, and WAN labels.
>>
>> Changelog (V2 ... part) should go into that /comments/ section (see below).
>> Florian: can you drop that line when applying this patch? Otherwise it
>> looks OK to me.
>>
>>
>>> Signed-off-by: Aditya Xavier 
>>
>> Acked-by: Rafał Miłecki 
>>
>> Thanks for the patch!
>>
>>
>>> ---
>>
>> Right here, below these 3 dashes is a place where you can add extra
>> comments (they won't go into log when doing "git am").
>>
>>> arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 --
>>> 1 file changed, 20 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts 
>>> b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>>> index 92f8a72..90d4420 100644
>>> --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>>> +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>>> @@ -27,18 +27,30 @@
>>>leds {
>>>compatible = "gpio-leds";
>>>
>>> -   power0 {
>>> +   power-white {
>>>label = "bcm53xx:white:power";
>>>gpios = < 2 GPIO_ACTIVE_LOW>;
>>>linux,default-trigger = "default-on";
>>>};
>>>
>>> -   power1 {
>>> +   power-amber {
>>>label = "bcm53xx:amber:power";
>>>gpios = < 3 GPIO_ACTIVE_LOW>;
>>>linux,default-trigger = "default-off";
>>>};
>>>
>>> +   wan-white {
>>> +   label = "bcm53xx:white:wan";
>>> +   gpios = < 8 GPIO_ACTIVE_LOW>;
>>> +   linux,default-trigger = "default-on";
>>> +   };
>>> +
>>> +   wan-amber {
>>> +   label = "bcm53xx:amber:wan";
>>> +   gpios = < 9 GPIO_ACTIVE_HIGH>;
>>> +   linux,default-trigger = "default-off";
>>> +   };
>>> +
>>>5ghz-1 {
>>>label = "bcm53xx:white:5ghz-1";
>>>gpios = < 12 GPIO_ACTIVE_LOW>;
>>> @@ -104,6 +116,12 @@
>>>linux,code = ;
>>>gpios = < 6 GPIO_ACTIVE_LOW>;
>>>};
>>> +
>>> +   brightness {
>>> +   label = "Backlight";
>>> +   linux,code = ;
>>> +   gpios = < 19 GPIO_ACTIVE_LOW>;
>>> +   };
>>>};
>>> };
>>>
>>> --
>>> 2.9.3
>>>
>>
>>
>>
>> -- 
>> Rafał
> 


-- 
Florian

Re: [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys

2017-01-30 Thread Florian Fainelli 
On 01/30/2017 01:08 AM, Aditya Xavier wrote:
> Would you require me to send the revised Patch ?
> 
> Or would this do ?

Will take care of it this time.

> 
> And thanks for guiding me through this process :)
> 
> 
>> On 29-Jan-2017, at 2:45 AM, Rafał Miłecki  wrote:
>>
>> On 28 January 2017 at 15:37, AdityaXavier  wrote:
>>> From: Aditya Xavier 
>>>
>>> Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
>>> V2: Updated subject, Power LED names, and WAN labels.
>>
>> Changelog (V2 ... part) should go into that /comments/ section (see below).
>> Florian: can you drop that line when applying this patch? Otherwise it
>> looks OK to me.
>>
>>
>>> Signed-off-by: Aditya Xavier 
>>
>> Acked-by: Rafał Miłecki 
>>
>> Thanks for the patch!
>>
>>
>>> ---
>>
>> Right here, below these 3 dashes is a place where you can add extra
>> comments (they won't go into log when doing "git am").
>>
>>> arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 --
>>> 1 file changed, 20 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts 
>>> b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>>> index 92f8a72..90d4420 100644
>>> --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>>> +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>>> @@ -27,18 +27,30 @@
>>>leds {
>>>compatible = "gpio-leds";
>>>
>>> -   power0 {
>>> +   power-white {
>>>label = "bcm53xx:white:power";
>>>gpios = < 2 GPIO_ACTIVE_LOW>;
>>>linux,default-trigger = "default-on";
>>>};
>>>
>>> -   power1 {
>>> +   power-amber {
>>>label = "bcm53xx:amber:power";
>>>gpios = < 3 GPIO_ACTIVE_LOW>;
>>>linux,default-trigger = "default-off";
>>>};
>>>
>>> +   wan-white {
>>> +   label = "bcm53xx:white:wan";
>>> +   gpios = < 8 GPIO_ACTIVE_LOW>;
>>> +   linux,default-trigger = "default-on";
>>> +   };
>>> +
>>> +   wan-amber {
>>> +   label = "bcm53xx:amber:wan";
>>> +   gpios = < 9 GPIO_ACTIVE_HIGH>;
>>> +   linux,default-trigger = "default-off";
>>> +   };
>>> +
>>>5ghz-1 {
>>>label = "bcm53xx:white:5ghz-1";
>>>gpios = < 12 GPIO_ACTIVE_LOW>;
>>> @@ -104,6 +116,12 @@
>>>linux,code = ;
>>>gpios = < 6 GPIO_ACTIVE_LOW>;
>>>};
>>> +
>>> +   brightness {
>>> +   label = "Backlight";
>>> +   linux,code = ;
>>> +   gpios = < 19 GPIO_ACTIVE_LOW>;
>>> +   };
>>>};
>>> };
>>>
>>> --
>>> 2.9.3
>>>
>>
>>
>>
>> -- 
>> Rafał
> 


-- 
Florian

Re: [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys

2017-01-30 Thread Aditya Xavier 
Would you require me to send the revised Patch ?

Or would this do ?

And thanks for guiding me through this process :)


> On 29-Jan-2017, at 2:45 AM, Rafał Miłecki  wrote:
> 
> On 28 January 2017 at 15:37, AdityaXavier  wrote:
>> From: Aditya Xavier 
>> 
>> Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
>> V2: Updated subject, Power LED names, and WAN labels.
> 
> Changelog (V2 ... part) should go into that /comments/ section (see below).
> Florian: can you drop that line when applying this patch? Otherwise it
> looks OK to me.
> 
> 
>> Signed-off-by: Aditya Xavier 
> 
> Acked-by: Rafał Miłecki 
> 
> Thanks for the patch!
> 
> 
>> ---
> 
> Right here, below these 3 dashes is a place where you can add extra
> comments (they won't go into log when doing "git am").
> 
>> arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 --
>> 1 file changed, 20 insertions(+), 2 deletions(-)
>> 
>> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts 
>> b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>> index 92f8a72..90d4420 100644
>> --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>> +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>> @@ -27,18 +27,30 @@
>>leds {
>>compatible = "gpio-leds";
>> 
>> -   power0 {
>> +   power-white {
>>label = "bcm53xx:white:power";
>>gpios = < 2 GPIO_ACTIVE_LOW>;
>>linux,default-trigger = "default-on";
>>};
>> 
>> -   power1 {
>> +   power-amber {
>>label = "bcm53xx:amber:power";
>>gpios = < 3 GPIO_ACTIVE_LOW>;
>>linux,default-trigger = "default-off";
>>};
>> 
>> +   wan-white {
>> +   label = "bcm53xx:white:wan";
>> +   gpios = < 8 GPIO_ACTIVE_LOW>;
>> +   linux,default-trigger = "default-on";
>> +   };
>> +
>> +   wan-amber {
>> +   label = "bcm53xx:amber:wan";
>> +   gpios = < 9 GPIO_ACTIVE_HIGH>;
>> +   linux,default-trigger = "default-off";
>> +   };
>> +
>>5ghz-1 {
>>label = "bcm53xx:white:5ghz-1";
>>gpios = < 12 GPIO_ACTIVE_LOW>;
>> @@ -104,6 +116,12 @@
>>linux,code = ;
>>gpios = < 6 GPIO_ACTIVE_LOW>;
>>};
>> +
>> +   brightness {
>> +   label = "Backlight";
>> +   linux,code = ;
>> +   gpios = < 19 GPIO_ACTIVE_LOW>;
>> +   };
>>};
>> };
>> 
>> --
>> 2.9.3
>> 
> 
> 
> 
> -- 
> Rafał

Re: [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys

2017-01-30 Thread Aditya Xavier 
Would you require me to send the revised Patch ?

Or would this do ?

And thanks for guiding me through this process :)


> On 29-Jan-2017, at 2:45 AM, Rafał Miłecki  wrote:
> 
> On 28 January 2017 at 15:37, AdityaXavier  wrote:
>> From: Aditya Xavier 
>> 
>> Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
>> V2: Updated subject, Power LED names, and WAN labels.
> 
> Changelog (V2 ... part) should go into that /comments/ section (see below).
> Florian: can you drop that line when applying this patch? Otherwise it
> looks OK to me.
> 
> 
>> Signed-off-by: Aditya Xavier 
> 
> Acked-by: Rafał Miłecki 
> 
> Thanks for the patch!
> 
> 
>> ---
> 
> Right here, below these 3 dashes is a place where you can add extra
> comments (they won't go into log when doing "git am").
> 
>> arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 --
>> 1 file changed, 20 insertions(+), 2 deletions(-)
>> 
>> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts 
>> b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>> index 92f8a72..90d4420 100644
>> --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>> +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>> @@ -27,18 +27,30 @@
>>leds {
>>compatible = "gpio-leds";
>> 
>> -   power0 {
>> +   power-white {
>>label = "bcm53xx:white:power";
>>gpios = < 2 GPIO_ACTIVE_LOW>;
>>linux,default-trigger = "default-on";
>>};
>> 
>> -   power1 {
>> +   power-amber {
>>label = "bcm53xx:amber:power";
>>gpios = < 3 GPIO_ACTIVE_LOW>;
>>linux,default-trigger = "default-off";
>>};
>> 
>> +   wan-white {
>> +   label = "bcm53xx:white:wan";
>> +   gpios = < 8 GPIO_ACTIVE_LOW>;
>> +   linux,default-trigger = "default-on";
>> +   };
>> +
>> +   wan-amber {
>> +   label = "bcm53xx:amber:wan";
>> +   gpios = < 9 GPIO_ACTIVE_HIGH>;
>> +   linux,default-trigger = "default-off";
>> +   };
>> +
>>5ghz-1 {
>>label = "bcm53xx:white:5ghz-1";
>>gpios = < 12 GPIO_ACTIVE_LOW>;
>> @@ -104,6 +116,12 @@
>>linux,code = ;
>>gpios = < 6 GPIO_ACTIVE_LOW>;
>>};
>> +
>> +   brightness {
>> +   label = "Backlight";
>> +   linux,code = ;
>> +   gpios = < 19 GPIO_ACTIVE_LOW>;
>> +   };
>>};
>> };
>> 
>> --
>> 2.9.3
>> 
> 
> 
> 
> -- 
> Rafał

Re: [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys

2017-01-28 Thread Rafał Miłecki 
On 28 January 2017 at 15:37, AdityaXavier  wrote:
> From: Aditya Xavier 
>
> Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
> V2: Updated subject, Power LED names, and WAN labels.

Changelog (V2 ... part) should go into that /comments/ section (see below).
Florian: can you drop that line when applying this patch? Otherwise it
looks OK to me.


> Signed-off-by: Aditya Xavier 

Acked-by: Rafał Miłecki 

Thanks for the patch!


> ---

Right here, below these 3 dashes is a place where you can add extra
comments (they won't go into log when doing "git am").

>  arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 --
>  1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts 
> b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
> index 92f8a72..90d4420 100644
> --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
> +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
> @@ -27,18 +27,30 @@
> leds {
> compatible = "gpio-leds";
>
> -   power0 {
> +   power-white {
> label = "bcm53xx:white:power";
> gpios = < 2 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "default-on";
> };
>
> -   power1 {
> +   power-amber {
> label = "bcm53xx:amber:power";
> gpios = < 3 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "default-off";
> };
>
> +   wan-white {
> +   label = "bcm53xx:white:wan";
> +   gpios = < 8 GPIO_ACTIVE_LOW>;
> +   linux,default-trigger = "default-on";
> +   };
> +
> +   wan-amber {
> +   label = "bcm53xx:amber:wan";
> +   gpios = < 9 GPIO_ACTIVE_HIGH>;
> +   linux,default-trigger = "default-off";
> +   };
> +
> 5ghz-1 {
> label = "bcm53xx:white:5ghz-1";
> gpios = < 12 GPIO_ACTIVE_LOW>;
> @@ -104,6 +116,12 @@
> linux,code = ;
> gpios = < 6 GPIO_ACTIVE_LOW>;
> };
> +
> +   brightness {
> +   label = "Backlight";
> +   linux,code = ;
> +   gpios = < 19 GPIO_ACTIVE_LOW>;
> +   };
> };
>  };
>
> --
> 2.9.3
>



-- 
Rafał

Re: [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys

2017-01-28 Thread Rafał Miłecki 
On 28 January 2017 at 15:37, AdityaXavier  wrote:
> From: Aditya Xavier 
>
> Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
> V2: Updated subject, Power LED names, and WAN labels.

Changelog (V2 ... part) should go into that /comments/ section (see below).
Florian: can you drop that line when applying this patch? Otherwise it
looks OK to me.


> Signed-off-by: Aditya Xavier 

Acked-by: Rafał Miłecki 

Thanks for the patch!


> ---

Right here, below these 3 dashes is a place where you can add extra
comments (they won't go into log when doing "git am").

>  arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 --
>  1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts 
> b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
> index 92f8a72..90d4420 100644
> --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
> +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
> @@ -27,18 +27,30 @@
> leds {
> compatible = "gpio-leds";
>
> -   power0 {
> +   power-white {
> label = "bcm53xx:white:power";
> gpios = < 2 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "default-on";
> };
>
> -   power1 {
> +   power-amber {
> label = "bcm53xx:amber:power";
> gpios = < 3 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "default-off";
> };
>
> +   wan-white {
> +   label = "bcm53xx:white:wan";
> +   gpios = < 8 GPIO_ACTIVE_LOW>;
> +   linux,default-trigger = "default-on";
> +   };
> +
> +   wan-amber {
> +   label = "bcm53xx:amber:wan";
> +   gpios = < 9 GPIO_ACTIVE_HIGH>;
> +   linux,default-trigger = "default-off";
> +   };
> +
> 5ghz-1 {
> label = "bcm53xx:white:5ghz-1";
> gpios = < 12 GPIO_ACTIVE_LOW>;
> @@ -104,6 +116,12 @@
> linux,code = ;
> gpios = < 6 GPIO_ACTIVE_LOW>;
> };
> +
> +   brightness {
> +   label = "Backlight";
> +   linux,code = ;
> +   gpios = < 19 GPIO_ACTIVE_LOW>;
> +   };
> };
>  };
>
> --
> 2.9.3
>



-- 
Rafał

[PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys

2017-01-28 Thread AdityaXavier 
From: Aditya Xavier 

Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
V2: Updated subject, Power LED names, and WAN labels.

Signed-off-by: Aditya Xavier 
---
 arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 --
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts 
b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
index 92f8a72..90d4420 100644
--- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
+++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
@@ -27,18 +27,30 @@
leds {
compatible = "gpio-leds";
 
-   power0 {
+   power-white {
label = "bcm53xx:white:power";
gpios = < 2 GPIO_ACTIVE_LOW>;
linux,default-trigger = "default-on";
};
 
-   power1 {
+   power-amber {
label = "bcm53xx:amber:power";
gpios = < 3 GPIO_ACTIVE_LOW>;
linux,default-trigger = "default-off";
};
 
+   wan-white {
+   label = "bcm53xx:white:wan";
+   gpios = < 8 GPIO_ACTIVE_LOW>;
+   linux,default-trigger = "default-on";
+   };
+
+   wan-amber {
+   label = "bcm53xx:amber:wan";
+   gpios = < 9 GPIO_ACTIVE_HIGH>;
+   linux,default-trigger = "default-off";
+   };
+
5ghz-1 {
label = "bcm53xx:white:5ghz-1";
gpios = < 12 GPIO_ACTIVE_LOW>;
@@ -104,6 +116,12 @@
linux,code = ;
gpios = < 6 GPIO_ACTIVE_LOW>;
};
+
+   brightness {
+   label = "Backlight";
+   linux,code = ;
+   gpios = < 19 GPIO_ACTIVE_LOW>;
+   };
};
 };
 
-- 
2.9.3

[PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys

2017-01-28 Thread AdityaXavier 
From: Aditya Xavier 

Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
V2: Updated subject, Power LED names, and WAN labels.

Signed-off-by: Aditya Xavier 
---
 arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 --
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts 
b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
index 92f8a72..90d4420 100644
--- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
+++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
@@ -27,18 +27,30 @@
leds {
compatible = "gpio-leds";
 
-   power0 {
+   power-white {
label = "bcm53xx:white:power";
gpios = < 2 GPIO_ACTIVE_LOW>;
linux,default-trigger = "default-on";
};
 
-   power1 {
+   power-amber {
label = "bcm53xx:amber:power";
gpios = < 3 GPIO_ACTIVE_LOW>;
linux,default-trigger = "default-off";
};
 
+   wan-white {
+   label = "bcm53xx:white:wan";
+   gpios = < 8 GPIO_ACTIVE_LOW>;
+   linux,default-trigger = "default-on";
+   };
+
+   wan-amber {
+   label = "bcm53xx:amber:wan";
+   gpios = < 9 GPIO_ACTIVE_HIGH>;
+   linux,default-trigger = "default-off";
+   };
+
5ghz-1 {
label = "bcm53xx:white:5ghz-1";
gpios = < 12 GPIO_ACTIVE_LOW>;
@@ -104,6 +116,12 @@
linux,code = ;
gpios = < 6 GPIO_ACTIVE_LOW>;
};
+
+   brightness {
+   label = "Backlight";
+   linux,code = ;
+   gpios = < 19 GPIO_ACTIVE_LOW>;
+   };
};
 };
 
-- 
2.9.3