Re: [PATCH V2] drm: Remove unnecessary drm_panel_attach and drm_panel_detach
Hi Joe. On Sun, Aug 02, 2020 at 07:34:13PM +0200, Sam Ravnborg wrote: > Hi Joe. > > On Sun, Aug 02, 2020 at 09:43:59AM -0700, Joe Perches wrote: > > These functions are now empty and no longer > > useful so remove the functions and their uses. > > > > Signed-off-by: Joe Perches > > --- > > > > > > It's too tedious to break apart into multiple patches. > > > > Done with coccinelle and typing. > > > > > > > > Compiled allyesconfig x86-64 only. > > > > V2: Removed 3 additional lines > > > > drivers/gpu/drm/omapdrm/omap_drv.c:390:27: warning: unused variable ‘priv’ > > [-Wunused-variable] > > drivers/gpu/drm/exynos/exynos_drm_dpi.c:45:21: warning: unused variable > > ‘ctx’ [-Wunused-variable] > > drivers/gpu/drm/sun4i/sun4i_lvds.c:57:21: warning: unused variable ‘lvds’ > > [-Wunused-variable] > > Thanks, better now. > > I had to fix a few warnings and a build error to get it going on > drm-misc-next. I will keep it locally just to let anyone speak up. > I you do not see any mail from me until friday that it is applied please > ping me. Thanks, Now applied to drm-misc-next. Will show up in -next sometimes after the current merge window closes. Sam
Re: [PATCH V2] drm: Remove unnecessary drm_panel_attach and drm_panel_detach
Hi Joe.
On Sun, Aug 02, 2020 at 09:43:59AM -0700, Joe Perches wrote:
> These functions are now empty and no longer
> useful so remove the functions and their uses.
>
> Signed-off-by: Joe Perches
> ---
>
> > > It's too tedious to break apart into multiple patches.
> > > Done with coccinelle and typing.
> > >
> > > Compiled allyesconfig x86-64 only.
>
> V2: Removed 3 additional lines
>
> drivers/gpu/drm/omapdrm/omap_drv.c:390:27: warning: unused variable ‘priv’
> [-Wunused-variable]
> drivers/gpu/drm/exynos/exynos_drm_dpi.c:45:21: warning: unused variable ‘ctx’
> [-Wunused-variable]
> drivers/gpu/drm/sun4i/sun4i_lvds.c:57:21: warning: unused variable ‘lvds’
> [-Wunused-variable]
Thanks, better now.
I had to fix a few warnings and a build error to get it going on
drm-misc-next. I will keep it locally just to let anyone speak up.
I you do not see any mail from me until friday that it is applied please
ping me.
Sam
>
> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 12
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 9 --
> drivers/gpu/drm/bridge/nxp-ptn3460.c | 3 --
> drivers/gpu/drm/bridge/panel.c | 7 -
> drivers/gpu/drm/bridge/parade-ps8622.c | 3 --
> drivers/gpu/drm/bridge/tc358764.c | 2 --
> drivers/gpu/drm/bridge/tc358767.c | 3 --
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 3 --
> drivers/gpu/drm/drm_panel.c| 36
> --
> drivers/gpu/drm/exynos/exynos_drm_dpi.c| 8 -
> drivers/gpu/drm/exynos/exynos_drm_dsi.c| 7 ++---
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 7 -
> drivers/gpu/drm/imx/imx-ldb.c | 10 --
> drivers/gpu/drm/imx/parallel-display.c | 6
> .../gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c| 7 +
> drivers/gpu/drm/msm/dsi/dsi_manager.c | 1 -
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 7 +
> drivers/gpu/drm/mxsfb/mxsfb_out.c | 6
> drivers/gpu/drm/omapdrm/omap_drv.c | 17 --
> drivers/gpu/drm/rcar-du/rcar_lvds.c| 6 +---
> drivers/gpu/drm/rockchip/rockchip_lvds.c | 9 --
> drivers/gpu/drm/sti/sti_dvo.c | 2 --
> drivers/gpu/drm/sun4i/sun4i_lvds.c | 9 --
> drivers/gpu/drm/sun4i/sun4i_rgb.c | 7 -
> drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 2 --
> drivers/gpu/drm/tegra/dsi.c| 4 +--
> drivers/gpu/drm/tegra/output.c | 10 --
> include/drm/drm_panel.h| 3 --
> 28 files changed, 6 insertions(+), 200 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> index f082b4ed4878..d9164fab044d 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> @@ -507,10 +507,6 @@ static const struct drm_connector_helper_funcs
> anx6345_connector_helper_funcs =
> static void
> anx6345_connector_destroy(struct drm_connector *connector)
> {
> - struct anx6345 *anx6345 = connector_to_anx6345(connector);
> -
> - if (anx6345->panel)
> - drm_panel_detach(anx6345->panel);
> drm_connector_cleanup(connector);
> }
>
> @@ -575,14 +571,6 @@ static int anx6345_bridge_attach(struct drm_bridge
> *bridge,
> return err;
> }
>
> - if (anx6345->panel) {
> - err = drm_panel_attach(anx6345->panel, >connector);
> - if (err) {
> - DRM_ERROR("Failed to attach panel: %d\n", err);
> - return err;
> - }
> - }
> -
> return 0;
> }
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 76736fb8ed94..aa1bb86293fd 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1265,14 +1265,6 @@ static int analogix_dp_bridge_attach(struct drm_bridge
> *bridge,
> }
> }
>
> - if (dp->plat_data->panel) {
> - ret = drm_panel_attach(dp->plat_data->panel, >connector);
> - if (ret) {
> - DRM_ERROR("Failed to attach panel\n");
> - return ret;
> - }
> - }
> -
> return 0;
> }
>
> @@ -1803,7 +1795,6 @@ void analogix_dp_unbind(struct analogix_dp_device *dp)
> if (dp->plat_data->panel) {
> if (drm_panel_unprepare(dp->plat_data->panel))
> DRM_ERROR("failed to turnoff the panel\n");
> - drm_panel_detach(dp->plat_data->panel);
> }
>
> drm_dp_aux_unregister(>aux);
> diff --git
[PATCH V2] drm: Remove unnecessary drm_panel_attach and drm_panel_detach
These functions are now empty and no longer
useful so remove the functions and their uses.
Signed-off-by: Joe Perches
---
> > It's too tedious to break apart into multiple patches.
> > Done with coccinelle and typing.
> >
> > Compiled allyesconfig x86-64 only.
V2: Removed 3 additional lines
drivers/gpu/drm/omapdrm/omap_drv.c:390:27: warning: unused variable ‘priv’
[-Wunused-variable]
drivers/gpu/drm/exynos/exynos_drm_dpi.c:45:21: warning: unused variable ‘ctx’
[-Wunused-variable]
drivers/gpu/drm/sun4i/sun4i_lvds.c:57:21: warning: unused variable ‘lvds’
[-Wunused-variable]
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 12
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 9 --
drivers/gpu/drm/bridge/nxp-ptn3460.c | 3 --
drivers/gpu/drm/bridge/panel.c | 7 -
drivers/gpu/drm/bridge/parade-ps8622.c | 3 --
drivers/gpu/drm/bridge/tc358764.c | 2 --
drivers/gpu/drm/bridge/tc358767.c | 3 --
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 3 --
drivers/gpu/drm/drm_panel.c| 36 --
drivers/gpu/drm/exynos/exynos_drm_dpi.c| 8 -
drivers/gpu/drm/exynos/exynos_drm_dsi.c| 7 ++---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 7 -
drivers/gpu/drm/imx/imx-ldb.c | 10 --
drivers/gpu/drm/imx/parallel-display.c | 6
.../gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c| 7 +
drivers/gpu/drm/msm/dsi/dsi_manager.c | 1 -
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 7 +
drivers/gpu/drm/mxsfb/mxsfb_out.c | 6
drivers/gpu/drm/omapdrm/omap_drv.c | 17 --
drivers/gpu/drm/rcar-du/rcar_lvds.c| 6 +---
drivers/gpu/drm/rockchip/rockchip_lvds.c | 9 --
drivers/gpu/drm/sti/sti_dvo.c | 2 --
drivers/gpu/drm/sun4i/sun4i_lvds.c | 9 --
drivers/gpu/drm/sun4i/sun4i_rgb.c | 7 -
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 2 --
drivers/gpu/drm/tegra/dsi.c| 4 +--
drivers/gpu/drm/tegra/output.c | 10 --
include/drm/drm_panel.h| 3 --
28 files changed, 6 insertions(+), 200 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
index f082b4ed4878..d9164fab044d 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
@@ -507,10 +507,6 @@ static const struct drm_connector_helper_funcs
anx6345_connector_helper_funcs =
static void
anx6345_connector_destroy(struct drm_connector *connector)
{
- struct anx6345 *anx6345 = connector_to_anx6345(connector);
-
- if (anx6345->panel)
- drm_panel_detach(anx6345->panel);
drm_connector_cleanup(connector);
}
@@ -575,14 +571,6 @@ static int anx6345_bridge_attach(struct drm_bridge *bridge,
return err;
}
- if (anx6345->panel) {
- err = drm_panel_attach(anx6345->panel, >connector);
- if (err) {
- DRM_ERROR("Failed to attach panel: %d\n", err);
- return err;
- }
- }
-
return 0;
}
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index 76736fb8ed94..aa1bb86293fd 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1265,14 +1265,6 @@ static int analogix_dp_bridge_attach(struct drm_bridge
*bridge,
}
}
- if (dp->plat_data->panel) {
- ret = drm_panel_attach(dp->plat_data->panel, >connector);
- if (ret) {
- DRM_ERROR("Failed to attach panel\n");
- return ret;
- }
- }
-
return 0;
}
@@ -1803,7 +1795,6 @@ void analogix_dp_unbind(struct analogix_dp_device *dp)
if (dp->plat_data->panel) {
if (drm_panel_unprepare(dp->plat_data->panel))
DRM_ERROR("failed to turnoff the panel\n");
- drm_panel_detach(dp->plat_data->panel);
}
drm_dp_aux_unregister(>aux);
diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c
b/drivers/gpu/drm/bridge/nxp-ptn3460.c
index 438e566ce0a4..d433902d97e5 100644
--- a/drivers/gpu/drm/bridge/nxp-ptn3460.c
+++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c
@@ -265,9 +265,6 @@ static int ptn3460_bridge_attach(struct drm_bridge *bridge,
drm_connector_attach_encoder(_bridge->connector,
bridge->encoder);
- if (ptn_bridge->panel)
- drm_panel_attach(ptn_bridge->panel,
