Re: [PATCH V2] dt-bindings: clock: Convert imx7ulp clock to json-schema

2020-06-15 Thread Rob Herring
On Thu, 04 Jun 2020 09:33:07 +0800, Anson Huang wrote:
> Convert the i.MX7ULP clock binding to DT schema format using json-schema,
> the original binding doc is actually for two clock modules(SCG and PCC),
> so split it to two binding docs, and the MPLL(mipi PLL) is NOT supposed
> to be in clock module, so remove it from binding doc as well.
> 
> Signed-off-by: Anson Huang 
> ---
> Changes since V1:
>   - add "additionalProperties: false".
> ---
>  .../devicetree/bindings/clock/imx7ulp-clock.txt| 103 --
>  .../bindings/clock/imx7ulp-pcc-clock.yaml  | 121 
> +
>  .../bindings/clock/imx7ulp-scg-clock.yaml  |  99 +
>  3 files changed, 220 insertions(+), 103 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/clock/imx7ulp-clock.txt
>  create mode 100644 
> Documentation/devicetree/bindings/clock/imx7ulp-pcc-clock.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/clock/imx7ulp-scg-clock.yaml
> 

Applied, thanks!


RE: [PATCH V2] dt-bindings: clock: Convert imx7ulp clock to json-schema

2020-06-04 Thread Aisheng Dong
> From: Anson Huang 
> Sent: Thursday, June 4, 2020 9:33 AM
> 
> Convert the i.MX7ULP clock binding to DT schema format using json-schema,
> the original binding doc is actually for two clock modules(SCG and PCC), so 
> split
> it to two binding docs, and the MPLL(mipi PLL) is NOT supposed to be in clock
> module, so remove it from binding doc as well.
> 
> Signed-off-by: Anson Huang 

Reviewed-by: Dong Aisheng 

Regards
Aisheng



Re: [PATCH V2] dt-bindings: clock: Convert imx7ulp clock to json-schema

2020-06-03 Thread Stephen Boyd
Quoting Anson Huang (2020-06-03 18:33:07)
> Convert the i.MX7ULP clock binding to DT schema format using json-schema,
> the original binding doc is actually for two clock modules(SCG and PCC),
> so split it to two binding docs, and the MPLL(mipi PLL) is NOT supposed
> to be in clock module, so remove it from binding doc as well.
> 
> Signed-off-by: Anson Huang 
> ---

Reviewed-by: Stephen Boyd 


[PATCH V2] dt-bindings: clock: Convert imx7ulp clock to json-schema

2020-06-03 Thread Anson Huang
Convert the i.MX7ULP clock binding to DT schema format using json-schema,
the original binding doc is actually for two clock modules(SCG and PCC),
so split it to two binding docs, and the MPLL(mipi PLL) is NOT supposed
to be in clock module, so remove it from binding doc as well.

Signed-off-by: Anson Huang 
---
Changes since V1:
- add "additionalProperties: false".
---
 .../devicetree/bindings/clock/imx7ulp-clock.txt| 103 --
 .../bindings/clock/imx7ulp-pcc-clock.yaml  | 121 +
 .../bindings/clock/imx7ulp-scg-clock.yaml  |  99 +
 3 files changed, 220 insertions(+), 103 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/imx7ulp-clock.txt
 create mode 100644 
Documentation/devicetree/bindings/clock/imx7ulp-pcc-clock.yaml
 create mode 100644 
Documentation/devicetree/bindings/clock/imx7ulp-scg-clock.yaml

diff --git a/Documentation/devicetree/bindings/clock/imx7ulp-clock.txt 
b/Documentation/devicetree/bindings/clock/imx7ulp-clock.txt
deleted file mode 100644
index 93d89ad..000
--- a/Documentation/devicetree/bindings/clock/imx7ulp-clock.txt
+++ /dev/null
@@ -1,103 +0,0 @@
-* Clock bindings for Freescale i.MX7ULP
-
-i.MX7ULP Clock functions are under joint control of the System
-Clock Generation (SCG) modules, Peripheral Clock Control (PCC)
-modules, and Core Mode Controller (CMC)1 blocks
-
-The clocking scheme provides clear separation between M4 domain
-and A7 domain. Except for a few clock sources shared between two
-domains, such as the System Oscillator clock, the Slow IRC (SIRC),
-and and the Fast IRC clock (FIRCLK), clock sources and clock
-management are separated and contained within each domain.
-
-M4 clock management consists of SCG0, PCC0, PCC1, and CMC0 modules.
-A7 clock management consists of SCG1, PCC2, PCC3, and CMC1 modules.
-
-Note: this binding doc is only for A7 clock domain.
-
-System Clock Generation (SCG) modules:
--
-The System Clock Generation (SCG) is responsible for clock generation
-and distribution across this device. Functions performed by the SCG
-include: clock reference selection, generation of clock used to derive
-processor, system, peripheral bus and external memory interface clocks,
-source selection for peripheral clocks and control of power saving
-clock gating mode.
-
-Required properties:
-
-- compatible:  Should be "fsl,imx7ulp-scg1".
-- reg :Should contain registers location and length.
-- #clock-cells:Should be <1>.
-- clocks:  Should contain the fixed input clocks.
-- clock-names:  Should contain the following clock names:
-   "rosc", "sosc", "sirc", "firc", "upll", "mpll".
-
-Peripheral Clock Control (PCC) modules:
--
-The Peripheral Clock Control (PCC) is responsible for clock selection,
-optional division and clock gating mode for peripherals in their
-respected power domain
-
-Required properties:
-- compatible:  Should be one of:
- "fsl,imx7ulp-pcc2",
- "fsl,imx7ulp-pcc3".
-- reg :Should contain registers location and length.
-- #clock-cells:Should be <1>.
-- clocks:  Should contain the fixed input clocks.
-- clock-names:  Should contain the following clock names:
-   "nic1_bus_clk", "nic1_clk", "ddr_clk", "apll_pfd2",
-   "apll_pfd1", "apll_pfd0", "upll", "sosc_bus_clk",
-   "mpll", "firc_bus_clk", "rosc", "spll_bus_clk";
-
-The clock consumer should specify the desired clock by having the clock
-ID in its "clocks" phandle cell.
-See include/dt-bindings/clock/imx7ulp-clock.h
-for the full list of i.MX7ULP clock IDs of each module.
-
-Examples:
-
-#include 
-
-scg1: scg1@403e {
-   compatible = "fsl,imx7ulp-scg1;
-   reg = <0x403e 0x1>;
-   clocks = <>, <>, <>,
-<>, <>, <>;
-   clock-names = "rosc", "sosc", "sirc",
- "firc", "upll", "mpll";
-   #clock-cells = <1>;
-};
-
-pcc2: pcc2@403f {
-   compatible = "fsl,imx7ulp-pcc2";
-   reg = <0x403f 0x1>;
-   #clock-cells = <1>;
-   clocks = < IMX7ULP_CLK_NIC1_BUS_DIV>,
-< IMX7ULP_CLK_NIC1_DIV>,
-< IMX7ULP_CLK_DDR_DIV>,
-< IMX7ULP_CLK_APLL_PFD2>,
-< IMX7ULP_CLK_APLL_PFD1>,
-< IMX7ULP_CLK_APLL_PFD0>,
-< IMX7ULP_CLK_UPLL>,
-< IMX7ULP_CLK_SOSC_BUS_CLK>,
-< IMX7ULP_CLK_FIRC_BUS_CLK>,
-< IMX7ULP_CLK_ROSC>,
-< IMX7ULP_CLK_SPLL_BUS_CLK>;
-   clock-names = "nic1_bus_clk", "nic1_clk", "ddr_clk",
- "apll_pfd2", "apll_pfd1", "apll_pfd0",
- "upll", "sosc_bus_clk", "mpll",
- "firc_bus_clk", "rosc", "spll_bus_clk";
-};
-
-usdhc1: usdhc@4038 {
-