Re: [PATCH V2] rtc: snvs: Use __maybe_unused instead of #if CONFIG_PM_SLEEP

[Alexandre Belloni]

On 30/04/2019 01:07:08+, Anson Huang wrote:
> Use __maybe_unused for power management related functions
> instead of #if CONFIG_PM_SLEEP to simply the code.
> 
> Signed-off-by: Anson Huang 
> Reviewed-by: Dong Aisheng 
> ---
> Changes since V1:
>   - use SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() to make sure snvs_rtc_pm_ops is 
> empty when PM is off.
> ---
>  drivers/rtc/rtc-snvs.c | 19 ---
>  1 file changed, 4 insertions(+), 15 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[PATCH V2] rtc: snvs: Use __maybe_unused instead of #if CONFIG_PM_SLEEP

[Anson Huang]

Use __maybe_unused for power management related functions
instead of #if CONFIG_PM_SLEEP to simply the code.

Signed-off-by: Anson Huang 
Reviewed-by: Dong Aisheng 
---
Changes since V1:
- use SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() to make sure snvs_rtc_pm_ops is 
empty when PM is off.
---
 drivers/rtc/rtc-snvs.c | 19 ---
 1 file changed, 4 insertions(+), 15 deletions(-)

diff --git a/drivers/rtc/rtc-snvs.c b/drivers/rtc/rtc-snvs.c
index e0edd594..7ee673a2 100644
--- a/drivers/rtc/rtc-snvs.c
+++ b/drivers/rtc/rtc-snvs.c
@@ -360,9 +360,7 @@ static int snvs_rtc_probe(struct platform_device *pdev)
return ret;
 }
 
-#ifdef CONFIG_PM_SLEEP
-
-static int snvs_rtc_suspend_noirq(struct device *dev)
+static int __maybe_unused snvs_rtc_suspend_noirq(struct device *dev)
 {
struct snvs_rtc_data *data = dev_get_drvdata(dev);
 
@@ -372,7 +370,7 @@ static int snvs_rtc_suspend_noirq(struct device *dev)
return 0;
 }
 
-static int snvs_rtc_resume_noirq(struct device *dev)
+static int __maybe_unused snvs_rtc_resume_noirq(struct device *dev)
 {
struct snvs_rtc_data *data = dev_get_drvdata(dev);
 
@@ -383,18 +381,9 @@ static int snvs_rtc_resume_noirq(struct device *dev)
 }
 
 static const struct dev_pm_ops snvs_rtc_pm_ops = {
-   .suspend_noirq = snvs_rtc_suspend_noirq,
-   .resume_noirq = snvs_rtc_resume_noirq,
+   SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(snvs_rtc_suspend_noirq, 
snvs_rtc_resume_noirq)
 };
 
-#define SNVS_RTC_PM_OPS(_rtc_pm_ops)
-
-#else
-
-#define SNVS_RTC_PM_OPSNULL
-
-#endif
-
 static const struct of_device_id snvs_dt_ids[] = {
{ .compatible = "fsl,sec-v4.0-mon-rtc-lp", },
{ /* sentinel */ }
@@ -404,7 +393,7 @@ MODULE_DEVICE_TABLE(of, snvs_dt_ids);
 static struct platform_driver snvs_rtc_driver = {
.driver = {
.name   = "snvs_rtc",
-   .pm = SNVS_RTC_PM_OPS,
+   .pm = _rtc_pm_ops,
.of_match_table = snvs_dt_ids,
},
.probe  = snvs_rtc_probe,
-- 
2.7.4