Re: [PATCH V2 0/5] Crypto Cleanup

2019-01-17 Thread Eric Biggers
On Thu, Jan 17, 2019 at 02:47:58PM +0800, Xiongfeng Wang wrote:
> The patchset introduce a helper to (un)register a array of crypto templates.
> The following patches use this helper to simplify the code. This is also
> a preparation for a coming patchset, which will register several crypto
> templates.
> 
> Changelog:
> v1 -> v2: 
>   rebased to cryptodev, fix some format issue
> 
> Xiongfeng Wang (5):
>   crypto: api - add a helper to (un)register a array of templates
>   crypto: ccm - use template array registering API to simplify the code
>   crypto: gcm - use template array registering API to simplify the code
>   crypto: ctr - use template array registering API to simplify the code
>   crypto: chacha20poly1305 - use template array registering API to
> simplify the code
> 
>  crypto/algapi.c   | 27 
>  crypto/ccm.c  | 78 
> ++-
>  crypto/chacha20poly1305.c | 37 +-
>  crypto/ctr.c  | 43 +-
>  crypto/gcm.c  | 73 ++--
>  include/crypto/algapi.h   |  2 ++
>  6 files changed, 104 insertions(+), 156 deletions(-)
> 
> -- 
> 1.7.12.4
> 

For all 5 patches:

Reviewed-by: Eric Biggers 

However, you need to fix your email address to be the same in the Author and
Signed-off-by.  Right now it's:

Author: Xiongfeng Wang 
Signed-off-by: Xiongfeng Wang 

(checkpatch.pl also warns about this.)

Thanks!

- Eric


[PATCH V2 0/5] Crypto Cleanup

2019-01-16 Thread Xiongfeng Wang
The patchset introduce a helper to (un)register a array of crypto templates.
The following patches use this helper to simplify the code. This is also
a preparation for a coming patchset, which will register several crypto
templates.

Changelog:
v1 -> v2: 
rebased to cryptodev, fix some format issue

Xiongfeng Wang (5):
  crypto: api - add a helper to (un)register a array of templates
  crypto: ccm - use template array registering API to simplify the code
  crypto: gcm - use template array registering API to simplify the code
  crypto: ctr - use template array registering API to simplify the code
  crypto: chacha20poly1305 - use template array registering API to
simplify the code

 crypto/algapi.c   | 27 
 crypto/ccm.c  | 78 ++-
 crypto/chacha20poly1305.c | 37 +-
 crypto/ctr.c  | 43 +-
 crypto/gcm.c  | 73 ++--
 include/crypto/algapi.h   |  2 ++
 6 files changed, 104 insertions(+), 156 deletions(-)

-- 
1.7.12.4