Re: [PATCH V2 1/5] cpufreq: Introduce cpufreq_notify_post_transition()

2014-01-05 Thread Rafael J. Wysocki
On Monday, December 02, 2013 11:04:12 AM Viresh Kumar wrote:
> This introduces another routine cpufreq_notify_post_transition() which can be
> used to send POSTCHANGE notification for new freq with or without both
> {PRE|POST}CHANGE notifications for last freq. This is useful at multiple 
> places,
> specially for sending transition failure notifications.
> 
> Signed-off-by: Viresh Kumar 

I've queued this series up for 3.14, but I folded patches [3-5/5] into [2/5]
(and needed to rebase the unicore2 changes).

Every time you want to copy-paste the changelog from one patch to another
(please don't do that any more) you should rather think about sending a
combination of the two as one patch.

Thanks!

> ---
> 
> V1->V2:
> - Not required to push it for 3.13 anymore and can go in 3.14.
> - Rebased over following patchset as there were conflicts in unicore2 driver 
> if
>   following patchset is applied first (which should be the case):
>   https://lkml.org/lkml/2013/10/30/553 (create cpufreq_generic_get() routine)
> 
>  drivers/cpufreq/cpufreq.c | 14 ++
>  include/linux/cpufreq.h   |  2 ++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 5e27def..3b877d4 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -338,6 +338,20 @@ void cpufreq_notify_transition(struct cpufreq_policy 
> *policy,
>  }
>  EXPORT_SYMBOL_GPL(cpufreq_notify_transition);
>  
> +/* Do post notifications when there are chances that transition has failed */
> +void cpufreq_notify_post_transition(struct cpufreq_policy *policy,
> + struct cpufreq_freqs *freqs, int transition_failed)
> +{
> + cpufreq_notify_transition(policy, freqs, CPUFREQ_POSTCHANGE);
> + if (!transition_failed)
> + return;
> +
> + swap(freqs->old, freqs->new);
> + cpufreq_notify_transition(policy, freqs, CPUFREQ_PRECHANGE);
> + cpufreq_notify_transition(policy, freqs, CPUFREQ_POSTCHANGE);
> +}
> +EXPORT_SYMBOL_GPL(cpufreq_notify_post_transition);
> +
>  
>  /*
>   *  SYSFS INTERFACE  *
> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> index 276e646..b26bfab 100644
> --- a/include/linux/cpufreq.h
> +++ b/include/linux/cpufreq.h
> @@ -316,6 +316,8 @@ int cpufreq_unregister_notifier(struct notifier_block 
> *nb, unsigned int list);
>  
>  void cpufreq_notify_transition(struct cpufreq_policy *policy,
>   struct cpufreq_freqs *freqs, unsigned int state);
> +void cpufreq_notify_post_transition(struct cpufreq_policy *policy,
> + struct cpufreq_freqs *freqs, int transition_failed);
>  
>  #else /* CONFIG_CPU_FREQ */
>  static inline int cpufreq_register_notifier(struct notifier_block *nb,
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH V2 1/5] cpufreq: Introduce cpufreq_notify_post_transition()

2013-12-01 Thread Viresh Kumar
This introduces another routine cpufreq_notify_post_transition() which can be
used to send POSTCHANGE notification for new freq with or without both
{PRE|POST}CHANGE notifications for last freq. This is useful at multiple places,
specially for sending transition failure notifications.

Signed-off-by: Viresh Kumar 
---

V1->V2:
- Not required to push it for 3.13 anymore and can go in 3.14.
- Rebased over following patchset as there were conflicts in unicore2 driver if
  following patchset is applied first (which should be the case):
  https://lkml.org/lkml/2013/10/30/553 (create cpufreq_generic_get() routine)

 drivers/cpufreq/cpufreq.c | 14 ++
 include/linux/cpufreq.h   |  2 ++
 2 files changed, 16 insertions(+)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 5e27def..3b877d4 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -338,6 +338,20 @@ void cpufreq_notify_transition(struct cpufreq_policy 
*policy,
 }
 EXPORT_SYMBOL_GPL(cpufreq_notify_transition);
 
+/* Do post notifications when there are chances that transition has failed */
+void cpufreq_notify_post_transition(struct cpufreq_policy *policy,
+   struct cpufreq_freqs *freqs, int transition_failed)
+{
+   cpufreq_notify_transition(policy, freqs, CPUFREQ_POSTCHANGE);
+   if (!transition_failed)
+   return;
+
+   swap(freqs->old, freqs->new);
+   cpufreq_notify_transition(policy, freqs, CPUFREQ_PRECHANGE);
+   cpufreq_notify_transition(policy, freqs, CPUFREQ_POSTCHANGE);
+}
+EXPORT_SYMBOL_GPL(cpufreq_notify_post_transition);
+
 
 /*
  *  SYSFS INTERFACE  *
diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
index 276e646..b26bfab 100644
--- a/include/linux/cpufreq.h
+++ b/include/linux/cpufreq.h
@@ -316,6 +316,8 @@ int cpufreq_unregister_notifier(struct notifier_block *nb, 
unsigned int list);
 
 void cpufreq_notify_transition(struct cpufreq_policy *policy,
struct cpufreq_freqs *freqs, unsigned int state);
+void cpufreq_notify_post_transition(struct cpufreq_policy *policy,
+   struct cpufreq_freqs *freqs, int transition_failed);
 
 #else /* CONFIG_CPU_FREQ */
 static inline int cpufreq_register_notifier(struct notifier_block *nb,
-- 
1.7.12.rc2.18.g61b472e

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/