Re: [PATCH V2 4/4] net: ethernet: ravb: Enable optional refclk

[Sergei Shtylyov]

Hello!

On 15.01.2021 23:19, Adam Ford wrote:


For devices that use a programmable clock for the avb reference clock,


   AVB.


the driver may need to enable them.  Add code to find the optional clock
and enable it when available.

Signed-off-by: Adam Ford 

[...]

diff --git a/drivers/net/ethernet/renesas/ravb_main.c 
b/drivers/net/ethernet/renesas/ravb_main.c
index bd30505fbc57..739e30f45daa 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -2148,6 +2148,14 @@ static int ravb_probe(struct platform_device *pdev)
goto out_release;
}
  
+	priv->refclk = devm_clk_get_optional(&pdev->dev, "refclk");

+   if (IS_ERR(priv->refclk)) {
+   error = PTR_ERR(priv->refclk);
+   goto out_release;
+   } else {


   No need for *else* after *goto*.


+   (void)clk_prepare_enable(priv->refclk);


   You can really omit (void)...
   Also, I'm not seeing where do you call clk_disable_unprepare()...

[...]

MBR, Sergei

[PATCH V2 4/4] net: ethernet: ravb: Enable optional refclk

[Adam Ford]

For devices that use a programmable clock for the avb reference clock,
the driver may need to enable them.  Add code to find the optional clock
and enable it when available.

Signed-off-by: Adam Ford 
---
 drivers/net/ethernet/renesas/ravb.h  | 1 +
 drivers/net/ethernet/renesas/ravb_main.c | 8 
 2 files changed, 9 insertions(+)

V2:  The previous patch to fetch the fclk was dropped.  In its place
 is code to enable the refclk

diff --git a/drivers/net/ethernet/renesas/ravb.h 
b/drivers/net/ethernet/renesas/ravb.h
index 7453b17a37a2..ff363797bd2b 100644
--- a/drivers/net/ethernet/renesas/ravb.h
+++ b/drivers/net/ethernet/renesas/ravb.h
@@ -994,6 +994,7 @@ struct ravb_private {
struct platform_device *pdev;
void __iomem *addr;
struct clk *clk;
+   struct clk *refclk;
struct mdiobb_ctrl mdiobb;
u32 num_rx_ring[NUM_RX_QUEUE];
u32 num_tx_ring[NUM_TX_QUEUE];
diff --git a/drivers/net/ethernet/renesas/ravb_main.c 
b/drivers/net/ethernet/renesas/ravb_main.c
index bd30505fbc57..739e30f45daa 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -2148,6 +2148,14 @@ static int ravb_probe(struct platform_device *pdev)
goto out_release;
}
 
+   priv->refclk = devm_clk_get_optional(&pdev->dev, "refclk");
+   if (IS_ERR(priv->refclk)) {
+   error = PTR_ERR(priv->refclk);
+   goto out_release;
+   } else {
+   (void)clk_prepare_enable(priv->refclk);
+   }
+
ndev->max_mtu = 2048 - (ETH_HLEN + VLAN_HLEN + ETH_FCS_LEN);
ndev->min_mtu = ETH_MIN_MTU;
 
-- 
2.25.1