Re: [PATCH V3] PM / OPP: Use - instead of @ for DT entries

2017-04-19 Thread Rafael J. Wysocki 
On Wednesday, April 19, 2017 07:22:15 AM Olof Johansson wrote:
> Hi Viresh,
> 
> On Tue, Apr 18, 2017 at 10:44:50AM +0530, Viresh Kumar wrote:
> > Compiling the DT file with W=1, DTC warns like follows:
> > 
> > Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a
> > unit name, but no reg property
> > 
> > Fix this by replacing '@' with '-' as the OPP nodes will never have a
> > "reg" property.
> > 
> > Reported-by: Krzysztof Kozlowski 
> > Reported-by: Masahiro Yamada 
> > Suggested-by: Mark Rutland 
> > Signed-off-by: Viresh Kumar 
> > Acked-by: Maxime Ripard  (sunxi)
> > Reviewed-by: Chanwoo Choi 
> > Reviewed-by: Krzysztof Kozlowski 
> > Acked-by: Masahiro Yamada  (uniphier)
> > Acked-by: Rob Herring 
> > Acked-by: Tony Lindgren 
> 
> We've already turned down other patches that does this in a sweeping manner
> like this, since they tend to be conflict prone with other DT changes.
> 
> Please split per platform and merge with each maintainer.

OK

So I'm assuming that you guys will take care of this going forward.

Thanks,
Rafael

Re: [PATCH V3] PM / OPP: Use - instead of @ for DT entries

2017-04-19 Thread Rafael J. Wysocki 
On Wednesday, April 19, 2017 07:22:15 AM Olof Johansson wrote:
> Hi Viresh,
> 
> On Tue, Apr 18, 2017 at 10:44:50AM +0530, Viresh Kumar wrote:
> > Compiling the DT file with W=1, DTC warns like follows:
> > 
> > Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a
> > unit name, but no reg property
> > 
> > Fix this by replacing '@' with '-' as the OPP nodes will never have a
> > "reg" property.
> > 
> > Reported-by: Krzysztof Kozlowski 
> > Reported-by: Masahiro Yamada 
> > Suggested-by: Mark Rutland 
> > Signed-off-by: Viresh Kumar 
> > Acked-by: Maxime Ripard  (sunxi)
> > Reviewed-by: Chanwoo Choi 
> > Reviewed-by: Krzysztof Kozlowski 
> > Acked-by: Masahiro Yamada  (uniphier)
> > Acked-by: Rob Herring 
> > Acked-by: Tony Lindgren 
> 
> We've already turned down other patches that does this in a sweeping manner
> like this, since they tend to be conflict prone with other DT changes.
> 
> Please split per platform and merge with each maintainer.

OK

So I'm assuming that you guys will take care of this going forward.

Thanks,
Rafael

Re: [PATCH V3] PM / OPP: Use - instead of @ for DT entries

2017-04-19 Thread Olof Johansson 
Hi Viresh,

On Tue, Apr 18, 2017 at 10:44:50AM +0530, Viresh Kumar wrote:
> Compiling the DT file with W=1, DTC warns like follows:
> 
> Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a
> unit name, but no reg property
> 
> Fix this by replacing '@' with '-' as the OPP nodes will never have a
> "reg" property.
> 
> Reported-by: Krzysztof Kozlowski 
> Reported-by: Masahiro Yamada 
> Suggested-by: Mark Rutland 
> Signed-off-by: Viresh Kumar 
> Acked-by: Maxime Ripard  (sunxi)
> Reviewed-by: Chanwoo Choi 
> Reviewed-by: Krzysztof Kozlowski 
> Acked-by: Masahiro Yamada  (uniphier)
> Acked-by: Rob Herring 
> Acked-by: Tony Lindgren 

We've already turned down other patches that does this in a sweeping manner
like this, since they tend to be conflict prone with other DT changes.

Please split per platform and merge with each maintainer.


Thanks,

-Olof

Re: [PATCH V3] PM / OPP: Use - instead of @ for DT entries

2017-04-19 Thread Olof Johansson 
Hi Viresh,

On Tue, Apr 18, 2017 at 10:44:50AM +0530, Viresh Kumar wrote:
> Compiling the DT file with W=1, DTC warns like follows:
> 
> Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a
> unit name, but no reg property
> 
> Fix this by replacing '@' with '-' as the OPP nodes will never have a
> "reg" property.
> 
> Reported-by: Krzysztof Kozlowski 
> Reported-by: Masahiro Yamada 
> Suggested-by: Mark Rutland 
> Signed-off-by: Viresh Kumar 
> Acked-by: Maxime Ripard  (sunxi)
> Reviewed-by: Chanwoo Choi 
> Reviewed-by: Krzysztof Kozlowski 
> Acked-by: Masahiro Yamada  (uniphier)
> Acked-by: Rob Herring 
> Acked-by: Tony Lindgren 

We've already turned down other patches that does this in a sweeping manner
like this, since they tend to be conflict prone with other DT changes.

Please split per platform and merge with each maintainer.


Thanks,

-Olof

[PATCH V3] PM / OPP: Use - instead of @ for DT entries

2017-04-17 Thread Viresh Kumar 
Compiling the DT file with W=1, DTC warns like follows:

Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a
unit name, but no reg property

Fix this by replacing '@' with '-' as the OPP nodes will never have a
"reg" property.

Reported-by: Krzysztof Kozlowski 
Reported-by: Masahiro Yamada 
Suggested-by: Mark Rutland 
Signed-off-by: Viresh Kumar 
Acked-by: Maxime Ripard  (sunxi)
Reviewed-by: Chanwoo Choi 
Reviewed-by: Krzysztof Kozlowski 
Acked-by: Masahiro Yamada  (uniphier)
Acked-by: Rob Herring 
Acked-by: Tony Lindgren 
---
V2->V3:
- Rebased over 4.11-rc7 and fixed a merge conflict for sun8i.

 .../devicetree/bindings/cpufreq/ti-cpufreq.txt | 20 +++
 .../devicetree/bindings/devfreq/exynos-bus.txt | 46 +++
 Documentation/devicetree/bindings/opp/opp.txt  | 38 ++---
 arch/arm/boot/dts/am4372.dtsi  | 10 ++--
 arch/arm/boot/dts/exynos3250.dtsi  | 46 +++
 arch/arm/boot/dts/exynos4210.dtsi  | 32 +--
 arch/arm/boot/dts/exynos4412-prime.dtsi|  4 +-
 arch/arm/boot/dts/exynos4412.dtsi  | 66 +++---
 arch/arm/boot/dts/exynos5420.dtsi  | 40 ++---
 arch/arm/boot/dts/exynos5800.dtsi  | 56 +-
 arch/arm/boot/dts/pxa25x.dtsi  |  8 +--
 arch/arm/boot/dts/pxa27x.dtsi  | 14 ++---
 arch/arm/boot/dts/sun8i-a33.dtsi   |  6 +-
 arch/arm/boot/dts/uniphier-pro5.dtsi   | 32 +--
 arch/arm/boot/dts/uniphier-pxs2.dtsi   | 16 +++---
 arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi | 48 
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 50 
 arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi   | 14 ++---
 arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi   | 32 +--
 arch/arm64/boot/dts/zte/zx296718.dtsi  | 10 ++--
 20 files changed, 294 insertions(+), 294 deletions(-)

diff --git a/Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt 
b/Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt
index ba0e15ad5bd9..0c38e4b8fc51 100644
--- a/Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt
+++ b/Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt
@@ -63,64 +63,64 @@ cpu0_opp_table: opp-table {
 * because they can not be enabled simultaneously on a
 * single SoC.
 */
-   opp50@3 {
+   opp50-3 {
opp-hz = /bits/ 64 <3>;
opp-microvolt = <95 931000 969000>;
opp-supported-hw = <0x06 0x0010>;
opp-suspend;
};
 
-   opp100@27500 {
+   opp100-27500 {
opp-hz = /bits/ 64 <27500>;
opp-microvolt = <110 1078000 1122000>;
opp-supported-hw = <0x01 0x00FF>;
opp-suspend;
};
 
-   opp100@3 {
+   opp100-3 {
opp-hz = /bits/ 64 <3>;
opp-microvolt = <110 1078000 1122000>;
opp-supported-hw = <0x06 0x0020>;
opp-suspend;
};
 
-   opp100@5 {
+   opp100-5 {
opp-hz = /bits/ 64 <5>;
opp-microvolt = <110 1078000 1122000>;
opp-supported-hw = <0x01 0x>;
};
 
-   opp100@6 {
+   opp100-6 {
opp-hz = /bits/ 64 <6>;
opp-microvolt = <110 1078000 1122000>;
opp-supported-hw = <0x06 0x0040>;
};
 
-   opp120@6 {
+   opp120-6 {
opp-hz = /bits/ 64 <6>;
opp-microvolt = <120 1176000 1224000>;
opp-supported-hw = <0x01 0x>;
};
 
-   opp120@72000 {
+   opp120-72000 {
opp-hz = /bits/ 64 <72000>;
opp-microvolt = <120 1176000 1224000>;
opp-supported-hw = <0x06 0x0080>;
};
 
-   oppturbo@72000 {
+   oppturbo-72000 {
opp-hz = /bits/ 64 <72000>;
opp-microvolt = <126 1234800 1285200>;
opp-supported-hw = <0x01 0x>;
};
 
-   oppturbo@8 {
+   oppturbo-8 {
opp-hz = /bits/ 64 <8>;
opp-microvolt = <126 1234800 1285200>;
opp-supported-hw = <0x06 0x0100>;
};
 
-   oppnitro@10 {
+   oppnitro-10 {
opp-hz = /bits/ 64 <10>;
opp-microvolt = <1325000 1298500 1351500>;

[PATCH V3] PM / OPP: Use - instead of @ for DT entries

2017-04-17 Thread Viresh Kumar 
Compiling the DT file with W=1, DTC warns like follows:

Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a
unit name, but no reg property

Fix this by replacing '@' with '-' as the OPP nodes will never have a
"reg" property.

Reported-by: Krzysztof Kozlowski 
Reported-by: Masahiro Yamada 
Suggested-by: Mark Rutland 
Signed-off-by: Viresh Kumar 
Acked-by: Maxime Ripard  (sunxi)
Reviewed-by: Chanwoo Choi 
Reviewed-by: Krzysztof Kozlowski 
Acked-by: Masahiro Yamada  (uniphier)
Acked-by: Rob Herring 
Acked-by: Tony Lindgren 
---
V2->V3:
- Rebased over 4.11-rc7 and fixed a merge conflict for sun8i.

 .../devicetree/bindings/cpufreq/ti-cpufreq.txt | 20 +++
 .../devicetree/bindings/devfreq/exynos-bus.txt | 46 +++
 Documentation/devicetree/bindings/opp/opp.txt  | 38 ++---
 arch/arm/boot/dts/am4372.dtsi  | 10 ++--
 arch/arm/boot/dts/exynos3250.dtsi  | 46 +++
 arch/arm/boot/dts/exynos4210.dtsi  | 32 +--
 arch/arm/boot/dts/exynos4412-prime.dtsi|  4 +-
 arch/arm/boot/dts/exynos4412.dtsi  | 66 +++---
 arch/arm/boot/dts/exynos5420.dtsi  | 40 ++---
 arch/arm/boot/dts/exynos5800.dtsi  | 56 +-
 arch/arm/boot/dts/pxa25x.dtsi  |  8 +--
 arch/arm/boot/dts/pxa27x.dtsi  | 14 ++---
 arch/arm/boot/dts/sun8i-a33.dtsi   |  6 +-
 arch/arm/boot/dts/uniphier-pro5.dtsi   | 32 +--
 arch/arm/boot/dts/uniphier-pxs2.dtsi   | 16 +++---
 arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi | 48 
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 50 
 arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi   | 14 ++---
 arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi   | 32 +--
 arch/arm64/boot/dts/zte/zx296718.dtsi  | 10 ++--
 20 files changed, 294 insertions(+), 294 deletions(-)

diff --git a/Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt 
b/Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt
index ba0e15ad5bd9..0c38e4b8fc51 100644
--- a/Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt
+++ b/Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt
@@ -63,64 +63,64 @@ cpu0_opp_table: opp-table {
 * because they can not be enabled simultaneously on a
 * single SoC.
 */
-   opp50@3 {
+   opp50-3 {
opp-hz = /bits/ 64 <3>;
opp-microvolt = <95 931000 969000>;
opp-supported-hw = <0x06 0x0010>;
opp-suspend;
};
 
-   opp100@27500 {
+   opp100-27500 {
opp-hz = /bits/ 64 <27500>;
opp-microvolt = <110 1078000 1122000>;
opp-supported-hw = <0x01 0x00FF>;
opp-suspend;
};
 
-   opp100@3 {
+   opp100-3 {
opp-hz = /bits/ 64 <3>;
opp-microvolt = <110 1078000 1122000>;
opp-supported-hw = <0x06 0x0020>;
opp-suspend;
};
 
-   opp100@5 {
+   opp100-5 {
opp-hz = /bits/ 64 <5>;
opp-microvolt = <110 1078000 1122000>;
opp-supported-hw = <0x01 0x>;
};
 
-   opp100@6 {
+   opp100-6 {
opp-hz = /bits/ 64 <6>;
opp-microvolt = <110 1078000 1122000>;
opp-supported-hw = <0x06 0x0040>;
};
 
-   opp120@6 {
+   opp120-6 {
opp-hz = /bits/ 64 <6>;
opp-microvolt = <120 1176000 1224000>;
opp-supported-hw = <0x01 0x>;
};
 
-   opp120@72000 {
+   opp120-72000 {
opp-hz = /bits/ 64 <72000>;
opp-microvolt = <120 1176000 1224000>;
opp-supported-hw = <0x06 0x0080>;
};
 
-   oppturbo@72000 {
+   oppturbo-72000 {
opp-hz = /bits/ 64 <72000>;
opp-microvolt = <126 1234800 1285200>;
opp-supported-hw = <0x01 0x>;
};
 
-   oppturbo@8 {
+   oppturbo-8 {
opp-hz = /bits/ 64 <8>;
opp-microvolt = <126 1234800 1285200>;
opp-supported-hw = <0x06 0x0100>;
};
 
-   oppnitro@10 {
+   oppnitro-10 {
opp-hz = /bits/ 64 <10>;
opp-microvolt = <1325000 1298500 1351500>;
opp-supported-hw = <0x04 0x0200>;
diff --git a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt 
b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt
index d085ef90d27c..f8e946471a58 100644
---