Re: [PATCH V3] checkpatch: Change format of --color argument to --color[=WHEN]

[John Brooks]

On Tue, Jun 06, 2017 at 06:50:06PM -0700, Joe Perches wrote:
> From: John Brooks 
> 
> The boolean --color argument did not offer the ability to force colourized
> output even if stdout is not a terminal. Change the format of the argument
> to the familiar --color[=WHEN] construct as seen in common Linux utilities
> such as git, ls and dmesg, which allows the user to specify whether to
> colourize output "always", "never", or "auto" when the output is a terminal.
> The default is "auto".
> 
> The old command-line uses of --color and --no-color are unchanged.
> 
> Signed-off-by: John Brooks 
> Signed-off-by: Joe Perches 

Thanks for doing the V3 for me :)
I was going to but had other work to do last night.

John

Re: [PATCH V3] checkpatch: Change format of --color argument to --color[=WHEN]

[John Brooks]

On Tue, Jun 06, 2017 at 06:50:06PM -0700, Joe Perches wrote:
> From: John Brooks 
> 
> The boolean --color argument did not offer the ability to force colourized
> output even if stdout is not a terminal. Change the format of the argument
> to the familiar --color[=WHEN] construct as seen in common Linux utilities
> such as git, ls and dmesg, which allows the user to specify whether to
> colourize output "always", "never", or "auto" when the output is a terminal.
> The default is "auto".
> 
> The old command-line uses of --color and --no-color are unchanged.
> 
> Signed-off-by: John Brooks 
> Signed-off-by: Joe Perches 

Thanks for doing the V3 for me :)
I was going to but had other work to do last night.

John

[PATCH V3] checkpatch: Change format of --color argument to --color[=WHEN]

[Joe Perches]

From: John Brooks 

The boolean --color argument did not offer the ability to force colourized
output even if stdout is not a terminal. Change the format of the argument
to the familiar --color[=WHEN] construct as seen in common Linux utilities
such as git, ls and dmesg, which allows the user to specify whether to
colourize output "always", "never", or "auto" when the output is a terminal.
The default is "auto".

The old command-line uses of --color and --no-color are unchanged.

Signed-off-by: John Brooks 
Signed-off-by: Joe Perches 
---
 scripts/checkpatch.pl | 35 +--
 1 file changed, 29 insertions(+), 6 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 7fcaf5ca997b..619851cfd872 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -57,7 +57,7 @@ my $codespell = 0;
 my $codespellfile = "/usr/share/codespell/dictionary.txt";
 my $conststructsfile = "$D/const_structs.checkpatch";
 my $typedefsfile = "";
-my $color = 1;
+my $color = "auto";
 my $allow_c99_comments = 1;
 
 sub help {
@@ -116,7 +116,8 @@ Options:
  (default:/usr/share/codespell/dictionary.txt)
   --codespellfileUse this codespell dictionary
   --typedefsfile Read additional types from this file
-  --colorUse colors when output is STDOUT (default: on)
+  --color[=WHEN] Use colors 'always', 'never', or only when output
+ is a terminal ('auto'). Default is 'auto'.
   -h, --help, --version  display this help and exit
 
 When FILE is - read standard input.
@@ -182,6 +183,14 @@ if (-f $conf) {
unshift(@ARGV, @conf_args) if @conf_args;
 }
 
+# Perl's Getopt::Long allows options to take optional arguments after a space.
+# Prevent --color by itself from consuming other arguments
+foreach (@ARGV) {
+   if ($_ eq "--color" || $_ eq "-color") {
+   $_ = "--color=$color";
+   }
+}
+
 GetOptions(
'q|quiet+'  => \$quiet,
'tree!' => \$tree,
@@ -212,7 +221,9 @@ GetOptions(
'codespell!'=> \$codespell,
'codespellfile=s'   => \$codespellfile,
'typedefsfile=s'=> \$typedefsfile,
-   'color!'=> \$color,
+   'color=s'   => \$color,
+   'no-color'  => \$color, #keep old behaviors of -nocolor
+   'nocolor'   => \$color, #keep old behaviors of -nocolor
'h|help'=> \$help,
'version'   => \$help
 ) or help(1);
@@ -238,6 +249,18 @@ if ($#ARGV < 0) {
push(@ARGV, '-');
 }
 
+if ($color =~ /^[01]$/) {
+   $color = !$color;
+} elsif ($color =~ /^always$/i) {
+   $color = 1;
+} elsif ($color =~ /^never$/i) {
+   $color = 0;
+} elsif ($color =~ /^auto$/i) {
+   $color = (-t STDOUT);
+} else {
+   die "Invalid color mode: $color\n";
+}
+
 sub hash_save_array_words {
my ($hashRef, $arrayRef) = @_;
 
@@ -1882,7 +1905,7 @@ sub report {
return 0;
}
my $output = '';
-   if (-t STDOUT && $color) {
+   if ($color) {
if ($level eq 'ERROR') {
$output .= RED;
} elsif ($level eq 'WARNING') {
@@ -1893,10 +1916,10 @@ sub report {
}
$output .= $prefix . $level . ':';
if ($show_types) {
-   $output .= BLUE if (-t STDOUT && $color);
+   $output .= BLUE if ($color);
$output .= "$type:";
}
-   $output .= RESET if (-t STDOUT && $color);
+   $output .= RESET if ($color);
$output .= ' ' . $msg . "\n";
 
if ($showfile) {
-- 
2.10.0.rc2.1.g053435c

[PATCH V3] checkpatch: Change format of --color argument to --color[=WHEN]

[Joe Perches]

From: John Brooks 

The boolean --color argument did not offer the ability to force colourized
output even if stdout is not a terminal. Change the format of the argument
to the familiar --color[=WHEN] construct as seen in common Linux utilities
such as git, ls and dmesg, which allows the user to specify whether to
colourize output "always", "never", or "auto" when the output is a terminal.
The default is "auto".

The old command-line uses of --color and --no-color are unchanged.

Signed-off-by: John Brooks 
Signed-off-by: Joe Perches 
---
 scripts/checkpatch.pl | 35 +--
 1 file changed, 29 insertions(+), 6 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 7fcaf5ca997b..619851cfd872 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -57,7 +57,7 @@ my $codespell = 0;
 my $codespellfile = "/usr/share/codespell/dictionary.txt";
 my $conststructsfile = "$D/const_structs.checkpatch";
 my $typedefsfile = "";
-my $color = 1;
+my $color = "auto";
 my $allow_c99_comments = 1;
 
 sub help {
@@ -116,7 +116,8 @@ Options:
  (default:/usr/share/codespell/dictionary.txt)
   --codespellfileUse this codespell dictionary
   --typedefsfile Read additional types from this file
-  --colorUse colors when output is STDOUT (default: on)
+  --color[=WHEN] Use colors 'always', 'never', or only when output
+ is a terminal ('auto'). Default is 'auto'.
   -h, --help, --version  display this help and exit
 
 When FILE is - read standard input.
@@ -182,6 +183,14 @@ if (-f $conf) {
unshift(@ARGV, @conf_args) if @conf_args;
 }
 
+# Perl's Getopt::Long allows options to take optional arguments after a space.
+# Prevent --color by itself from consuming other arguments
+foreach (@ARGV) {
+   if ($_ eq "--color" || $_ eq "-color") {
+   $_ = "--color=$color";
+   }
+}
+
 GetOptions(
'q|quiet+'  => \$quiet,
'tree!' => \$tree,
@@ -212,7 +221,9 @@ GetOptions(
'codespell!'=> \$codespell,
'codespellfile=s'   => \$codespellfile,
'typedefsfile=s'=> \$typedefsfile,
-   'color!'=> \$color,
+   'color=s'   => \$color,
+   'no-color'  => \$color, #keep old behaviors of -nocolor
+   'nocolor'   => \$color, #keep old behaviors of -nocolor
'h|help'=> \$help,
'version'   => \$help
 ) or help(1);
@@ -238,6 +249,18 @@ if ($#ARGV < 0) {
push(@ARGV, '-');
 }
 
+if ($color =~ /^[01]$/) {
+   $color = !$color;
+} elsif ($color =~ /^always$/i) {
+   $color = 1;
+} elsif ($color =~ /^never$/i) {
+   $color = 0;
+} elsif ($color =~ /^auto$/i) {
+   $color = (-t STDOUT);
+} else {
+   die "Invalid color mode: $color\n";
+}
+
 sub hash_save_array_words {
my ($hashRef, $arrayRef) = @_;
 
@@ -1882,7 +1905,7 @@ sub report {
return 0;
}
my $output = '';
-   if (-t STDOUT && $color) {
+   if ($color) {
if ($level eq 'ERROR') {
$output .= RED;
} elsif ($level eq 'WARNING') {
@@ -1893,10 +1916,10 @@ sub report {
}
$output .= $prefix . $level . ':';
if ($show_types) {
-   $output .= BLUE if (-t STDOUT && $color);
+   $output .= BLUE if ($color);
$output .= "$type:";
}
-   $output .= RESET if (-t STDOUT && $color);
+   $output .= RESET if ($color);
$output .= ' ' . $msg . "\n";
 
if ($showfile) {
-- 
2.10.0.rc2.1.g053435c