Re: [PATCH V3 3/4] cpufreq: Tegra: drop wrapper around tegra_update_cpu_speed()

2014-05-20 Thread Doug Anderson
Viresh,

On Fri, May 16, 2014 at 9:51 PM, Viresh Kumar  wrote:
> Tegra has implemented an unnecessary wrapper over tegra_update_cpu_speed(), 
> i.e.
> tegra_target(), which wasn't doing anything apart of calling
> tegra_update_cpu_speed(). Get rid of that and use tegra_target() directly.
>
> Tested-by: Stephen Warren 
> Signed-off-by: Viresh Kumar 
> ---
>  drivers/cpufreq/tegra-cpufreq.c | 9 ++---
>  1 file changed, 2 insertions(+), 7 deletions(-)

Reviewed-by: Doug Anderson 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH V3 3/4] cpufreq: Tegra: drop wrapper around tegra_update_cpu_speed()

2014-05-20 Thread Doug Anderson
Viresh,

On Fri, May 16, 2014 at 9:51 PM, Viresh Kumar viresh.ku...@linaro.org wrote:
 Tegra has implemented an unnecessary wrapper over tegra_update_cpu_speed(), 
 i.e.
 tegra_target(), which wasn't doing anything apart of calling
 tegra_update_cpu_speed(). Get rid of that and use tegra_target() directly.

 Tested-by: Stephen Warren swar...@nvidia.com
 Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
 ---
  drivers/cpufreq/tegra-cpufreq.c | 9 ++---
  1 file changed, 2 insertions(+), 7 deletions(-)

Reviewed-by: Doug Anderson diand...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH V3 3/4] cpufreq: Tegra: drop wrapper around tegra_update_cpu_speed()

2014-05-16 Thread Viresh Kumar
Tegra has implemented an unnecessary wrapper over tegra_update_cpu_speed(), i.e.
tegra_target(), which wasn't doing anything apart of calling
tegra_update_cpu_speed(). Get rid of that and use tegra_target() directly.

Tested-by: Stephen Warren 
Signed-off-by: Viresh Kumar 
---
 drivers/cpufreq/tegra-cpufreq.c | 9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/cpufreq/tegra-cpufreq.c b/drivers/cpufreq/tegra-cpufreq.c
index 63f0059..6e774c6 100644
--- a/drivers/cpufreq/tegra-cpufreq.c
+++ b/drivers/cpufreq/tegra-cpufreq.c
@@ -82,9 +82,9 @@ out:
return ret;
 }
 
-static int tegra_update_cpu_speed(struct cpufreq_policy *policy,
-   unsigned long rate)
+static int tegra_target(struct cpufreq_policy *policy, unsigned int index)
 {
+   unsigned long rate = freq_table[index].frequency;
int ret = 0;
 
/*
@@ -106,11 +106,6 @@ static int tegra_update_cpu_speed(struct cpufreq_policy 
*policy,
return ret;
 }
 
-static int tegra_target(struct cpufreq_policy *policy, unsigned int index)
-{
-   return tegra_update_cpu_speed(policy, freq_table[index].frequency);
-}
-
 static int tegra_cpu_init(struct cpufreq_policy *policy)
 {
int ret;
-- 
2.0.0.rc2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH V3 3/4] cpufreq: Tegra: drop wrapper around tegra_update_cpu_speed()

2014-05-16 Thread Viresh Kumar
Tegra has implemented an unnecessary wrapper over tegra_update_cpu_speed(), i.e.
tegra_target(), which wasn't doing anything apart of calling
tegra_update_cpu_speed(). Get rid of that and use tegra_target() directly.

Tested-by: Stephen Warren swar...@nvidia.com
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
 drivers/cpufreq/tegra-cpufreq.c | 9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/cpufreq/tegra-cpufreq.c b/drivers/cpufreq/tegra-cpufreq.c
index 63f0059..6e774c6 100644
--- a/drivers/cpufreq/tegra-cpufreq.c
+++ b/drivers/cpufreq/tegra-cpufreq.c
@@ -82,9 +82,9 @@ out:
return ret;
 }
 
-static int tegra_update_cpu_speed(struct cpufreq_policy *policy,
-   unsigned long rate)
+static int tegra_target(struct cpufreq_policy *policy, unsigned int index)
 {
+   unsigned long rate = freq_table[index].frequency;
int ret = 0;
 
/*
@@ -106,11 +106,6 @@ static int tegra_update_cpu_speed(struct cpufreq_policy 
*policy,
return ret;
 }
 
-static int tegra_target(struct cpufreq_policy *policy, unsigned int index)
-{
-   return tegra_update_cpu_speed(policy, freq_table[index].frequency);
-}
-
 static int tegra_cpu_init(struct cpufreq_policy *policy)
 {
int ret;
-- 
2.0.0.rc2

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/