Re: [PATCH V3 5/5] arm64: dts: renesas: beacon kits: Setup AVB refclk
Hi Adam,
On Sat, Apr 17, 2021 at 3:54 PM Adam Ford wrote:
> On Thu, Mar 4, 2021 at 2:04 AM Geert Uytterhoeven
> wrote:
> > On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote:
> > > The AVB refererence clock assumes an external clock that runs
> >
> > reference
> >
> > > automatically. Because the Versaclock is wired to provide the
> > > AVB refclock, the device tree needs to reference it in order for the
> > > driver to start the clock.
> > >
> > > Signed-off-by: Adam Ford
> >
> > Reviewed-by: Geert Uytterhoeven
> > i.e. will queue in renesas-devel (with the typo fixed) once the DT
> > bindings have been accepted.
>
> Geert,
>
> Since the refclk update and corresponding dt-bindings are in net-next,
> are you OK applying the rest of the DT changes so they can get into
> 5.13?
Queueing in renesas-devel for v5.14, as the soc deadline for v5.13
has already passed two weeks ago.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH V3 5/5] arm64: dts: renesas: beacon kits: Setup AVB refclk
On Thu, Mar 4, 2021 at 2:04 AM Geert Uytterhoeven wrote:
>
> On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote:
> > The AVB refererence clock assumes an external clock that runs
>
> reference
>
> > automatically. Because the Versaclock is wired to provide the
> > AVB refclock, the device tree needs to reference it in order for the
> > driver to start the clock.
> >
> > Signed-off-by: Adam Ford
>
> Reviewed-by: Geert Uytterhoeven
> i.e. will queue in renesas-devel (with the typo fixed) once the DT
> bindings have been accepted.
Geert,
Since the refclk update and corresponding dt-bindings are in net-next,
are you OK applying the rest of the DT changes so they can get into
5.13?
adam
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> ge...@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
Re: [PATCH V3 5/5] arm64: dts: renesas: beacon kits: Setup AVB refclk
On 18.03.2021 15:44, Adam Ford wrote: The AVB refererence clock assumes an external clock that runs reference automatically. Because the Versaclock is wired to provide the AVB refclock, the device tree needs to reference it in order for the driver to start the clock. Signed-off-by: Adam Ford Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-devel (with the typo fixed) once the DT bindings have been accepted. Who do I need to ping to get the DT bindings accepted? They have an acked-by from Rob. Normally, the bindings get picked up by a subsystem maintainer... or Rob :-) [...] MBR, Sergei
Re: [PATCH V3 5/5] arm64: dts: renesas: beacon kits: Setup AVB refclk
Hi Adam,
On Thu, Mar 18, 2021 at 1:44 PM Adam Ford wrote:
> On Thu, Mar 4, 2021 at 2:04 AM Geert Uytterhoeven
> wrote:
> > On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote:
> > > The AVB refererence clock assumes an external clock that runs
> >
> > reference
> >
> > > automatically. Because the Versaclock is wired to provide the
> > > AVB refclock, the device tree needs to reference it in order for the
> > > driver to start the clock.
> > >
> > > Signed-off-by: Adam Ford
> >
> > Reviewed-by: Geert Uytterhoeven
> > i.e. will queue in renesas-devel (with the typo fixed) once the DT
> > bindings have been accepted.
> >
>
> Who do I need to ping to get the DT bindings accepted? They have an
> acked-by from Rob.
Sergei, can you please have a look at the DT binding change?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH V3 5/5] arm64: dts: renesas: beacon kits: Setup AVB refclk
On Thu, Mar 4, 2021 at 2:04 AM Geert Uytterhoeven wrote:
>
> On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote:
> > The AVB refererence clock assumes an external clock that runs
>
> reference
>
> > automatically. Because the Versaclock is wired to provide the
> > AVB refclock, the device tree needs to reference it in order for the
> > driver to start the clock.
> >
> > Signed-off-by: Adam Ford
>
> Reviewed-by: Geert Uytterhoeven
> i.e. will queue in renesas-devel (with the typo fixed) once the DT
> bindings have been accepted.
>
Who do I need to ping to get the DT bindings accepted? They have an
acked-by from Rob.
adam
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> ge...@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
Re: [PATCH V3 5/5] arm64: dts: renesas: beacon kits: Setup AVB refclk
On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote:
> The AVB refererence clock assumes an external clock that runs
reference
> automatically. Because the Versaclock is wired to provide the
> AVB refclock, the device tree needs to reference it in order for the
> driver to start the clock.
>
> Signed-off-by: Adam Ford
Reviewed-by: Geert Uytterhoeven
i.e. will queue in renesas-devel (with the typo fixed) once the DT
bindings have been accepted.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[PATCH V3 5/5] arm64: dts: renesas: beacon kits: Setup AVB refclk
The AVB refererence clock assumes an external clock that runs
automatically. Because the Versaclock is wired to provide the
AVB refclock, the device tree needs to reference it in order for the
driver to start the clock.
Signed-off-by: Adam Ford
---
V3: New to series
diff --git a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
index 8d3a4d6ee885..75355c354c38 100644
--- a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
+++ b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
@@ -53,6 +53,8 @@ &avb {
phy-handle = <&phy0>;
rx-internal-delay-ps = <1800>;
tx-internal-delay-ps = <2000>;
+ clocks = <&cpg CPG_MOD 812>, <&versaclock5 4>;
+ clock-names = "fck", "refclk";
status = "okay";
phy0: ethernet-phy@0 {
--
2.25.1
