Re: [PATCH V4] arch: kernel: cpu: x86/resctrl: Takes a letter away and append a colon to match below struct member
On Wed, Jan 13, 2021 at 07:33:33AM +0530, Bhaskar Chowdhury wrote: > s/kernlfs/kernfs/ > s/@mon_data_kn/@mon_data_kn:/ May change the message to describe the problems like: Fix typo "kernlfs" and add missing ":" to match with other comments. > > Signed-off-by: Bhaskar Chowdhury > --- > Changes from V3: Fix the subject line typo stuc to struct and mention cpu > architecture > Please read Documentation/process/submitting-patches.rst. It talks about the subject, description of problem, changelog, etc for submitting a patch. Thanks. -Fenghua
Re: [PATCH V4] arch: kernel: cpu: x86/resctrl: Takes a letter away and append a colon to match below struct member
Hi Bhaskar,
The prefix in the subject line should be "x86/resctrl:" only. The
subject line could be (also taking liberty to shorten it here):
x86/resctrl: Fix typo and append a colon to match struct member
I would like to repeat my suggestion made in response to your previous
version, especially if you are planning cleanup in many areas of the
kernel: Use "git log" to take a look at the custom of patches in the
area you are contributing to. While the kernel may appear to be a single
code base there can be different customs in the various subsystems.
On 1/12/2021 6:03 PM, Bhaskar Chowdhury wrote:
s/kernlfs/kernfs/
s/@mon_data_kn/@mon_data_kn:/
Signed-off-by: Bhaskar Chowdhury
---
Changes from V3: Fix the subject line typo stuc to struct and mention cpu
architecture
arch/x86/kernel/cpu/resctrl/internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/resctrl/internal.h
b/arch/x86/kernel/cpu/resctrl/internal.h
index ee71c47844cb..ef9e2c0809b8 100644
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -142,7 +142,7 @@ enum rdtgrp_mode {
/**
* struct mongroup - store mon group's data in resctrl fs.
- * @mon_data_knkernlfs node for the mon_data directory
+ * @mon_data_kn: kernfs node for the mon_data directory
* @parent: parent rdtgrp
* @crdtgrp_list: child rdtgroup node list
* @rmid: rmid for this rdtgroup
--
2.20.1
Reinette
Re: [PATCH V4] arch: kernel: cpu: x86/resctrl: Takes a letter away and append a colon to match below struct member
On 00:27 Wed 13 Jan 2021, Gustavo A. R. Silva wrote: On 1/12/21 20:48, Bhaskar Chowdhury wrote: On 20:24 Tue 12 Jan 2021, Gustavo A. R. Silva wrote: On 1/12/21 20:03, Bhaskar Chowdhury wrote: s/kernlfs/kernfs/ s/@mon_data_kn/@mon_data_kn:/ Signed-off-by: Bhaskar Chowdhury --- Changes from V3: Fix the subject line typo stuc to struct and mention cpu architecture ...and what changed from v1 to v2 and from v2 to v3? Gustavo, it seems you are not following up properly could you please put little more effort for know it There were mailspls scan and read .. This is my point... this is exactly what maintainers and reviewers should not do: to go back and read emails, trying to understand why are you sending a version N of your patch, because you didn't include all the previous change logs in the most recent version of your patch. Thanks, will follow what you advice. -- Gustavo signature.asc Description: PGP signature
Re: [PATCH V4] arch: kernel: cpu: x86/resctrl: Takes a letter away and append a colon to match below struct member
On 18:51 Tue 12 Jan 2021, Randy Dunlap wrote: On 1/12/21 6:48 PM, Bhaskar Chowdhury wrote: On 20:24 Tue 12 Jan 2021, Gustavo A. R. Silva wrote: On 1/12/21 20:03, Bhaskar Chowdhury wrote: s/kernlfs/kernfs/ s/@mon_data_kn/@mon_data_kn:/ Signed-off-by: Bhaskar Chowdhury --- Changes from V3: Fix the subject line typo stuc to struct and mention cpu architecture ...and what changed from v1 to v2 and from v2 to v3? Gustavo, it seems you are not following up properly could you please put little more effort for know it There were mailspls scan and read .. All of these version change logs should be in this patch, under the "---" line. Point noted for future reference.Thanks. -- ~Randy You can't do anything without having to do something else first. -- Belefant's Law signature.asc Description: PGP signature
Re: [PATCH V4] arch: kernel: cpu: x86/resctrl: Takes a letter away and append a colon to match below struct member
On 1/12/21 6:48 PM, Bhaskar Chowdhury wrote: > On 20:24 Tue 12 Jan 2021, Gustavo A. R. Silva wrote: >> >> >> On 1/12/21 20:03, Bhaskar Chowdhury wrote: >>> s/kernlfs/kernfs/ >>> s/@mon_data_kn/@mon_data_kn:/ >>> >>> Signed-off-by: Bhaskar Chowdhury >>> --- >>> Changes from V3: Fix the subject line typo stuc to struct and mention cpu >>> architecture >> >> ...and what changed from v1 to v2 and from v2 to v3? >> > > Gustavo, it seems you are not following up properly could you please put > little more effort for know it > > There were mailspls scan and read .. All of these version change logs should be in this patch, under the "---" line. -- ~Randy You can't do anything without having to do something else first. -- Belefant's Law
Re: [PATCH V4] arch: kernel: cpu: x86/resctrl: Takes a letter away and append a colon to match below struct member
On 20:24 Tue 12 Jan 2021, Gustavo A. R. Silva wrote: On 1/12/21 20:03, Bhaskar Chowdhury wrote: s/kernlfs/kernfs/ s/@mon_data_kn/@mon_data_kn:/ Signed-off-by: Bhaskar Chowdhury --- Changes from V3: Fix the subject line typo stuc to struct and mention cpu architecture ...and what changed from v1 to v2 and from v2 to v3? Gustavo, it seems you are not following up properly could you please put little more effort for know it There were mailspls scan and read .. Bhaskar -- Gustavo signature.asc Description: PGP signature
[PATCH V4] arch: kernel: cpu: x86/resctrl: Takes a letter away and append a colon to match below struct member
s/kernlfs/kernfs/
s/@mon_data_kn/@mon_data_kn:/
Signed-off-by: Bhaskar Chowdhury
---
Changes from V3: Fix the subject line typo stuc to struct and mention cpu
architecture
arch/x86/kernel/cpu/resctrl/internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/resctrl/internal.h
b/arch/x86/kernel/cpu/resctrl/internal.h
index ee71c47844cb..ef9e2c0809b8 100644
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -142,7 +142,7 @@ enum rdtgrp_mode {
/**
* struct mongroup - store mon group's data in resctrl fs.
- * @mon_data_knkernlfs node for the mon_data directory
+ * @mon_data_kn: kernfs node for the mon_data directory
* @parent:parent rdtgrp
* @crdtgrp_list: child rdtgroup node list
* @rmid: rmid for this rdtgroup
--
2.20.1
