Re: [PATCH V5 2/4] thermal: imx_sc: add i.MX system controller thermal support
On Tue, Jan 22, 2019 at 06:54:30AM +, Anson Huang wrote: > Hi, Eduardo > > Best Regards! > Anson Huang > > > -Original Message- > > From: Anson Huang > > Sent: 2019年1月10日 17:28 > > To: 'Eduardo Valentin' > > Cc: 'robh...@kernel.org' ; 'mark.rutl...@arm.com' > > ; 'catalin.mari...@arm.com' > > ; 'will.dea...@arm.com' > > ; 'rui.zh...@intel.com' ; > > 'daniel.lezc...@linaro.org' ; Aisheng Dong > > ; 's.ha...@pengutronix.de' > > ; 'shawn...@kernel.org' ; > > Andy Gross ; 'a...@arndb.de' ; > > 'horms+rene...@verge.net.au' ; > > 'he...@sntech.de' ; 'bjorn.anders...@linaro.org' > > ; 'enric.balle...@collabora.com' > > ; 'amit.kuche...@linaro.org' > > ; 'ezequ...@collabora.com' > > ; 'o...@lixom.net' ; > > 'devicet...@vger.kernel.org' ; > > 'linux-kernel@vger.kernel.org' ; > > 'linux-arm-ker...@lists.infradead.org' > > ; > > 'linux...@vger.kernel.org' ; dl-linux-imx > > > > Subject: RE: [PATCH V5 2/4] thermal: imx_sc: add i.MX system controller > > thermal support > > > > Hi, Eduardo > > > > Best Regards! > > Anson Huang > > > > > -Original Message- > > > From: Anson Huang > > > Sent: 2018年12月26日 11:36 > > > To: 'Eduardo Valentin' > > > Cc: robh...@kernel.org; mark.rutl...@arm.com; > > catalin.mari...@arm.com; > > > will.dea...@arm.com; rui.zh...@intel.com; daniel.lezc...@linaro.org; > > > Aisheng Dong ; s.ha...@pengutronix.de; > > > shawn...@kernel.org; Andy Gross ; > > > a...@arndb.de; > > > horms+rene...@verge.net.au; he...@sntech.de; > > > horms+bjorn.anders...@linaro.org; > > > enric.balle...@collabora.com; amit.kuche...@linaro.org; > > > ezequ...@collabora.com; o...@lixom.net; devicet...@vger.kernel.org; > > > linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > > > linux...@vger.kernel.org; dl-linux-imx > > > Subject: RE: [PATCH V5 2/4] thermal: imx_sc: add i.MX system > > > controller thermal support > > > > > > Hi, Eduardo > > > > > > Best Regards! > > > Anson Huang > > > > > > > -Original Message- > > > > From: Eduardo Valentin [mailto:edubez...@gmail.com] > > > > Sent: 2018年12月26日 6:44 > > > > To: Anson Huang > > > > Cc: robh...@kernel.org; mark.rutl...@arm.com; > > > catalin.mari...@arm.com; > > > > will.dea...@arm.com; rui.zh...@intel.com; daniel.lezc...@linaro.org; > > > > Aisheng Dong ; s.ha...@pengutronix.de; > > > > shawn...@kernel.org; Andy Gross ; > > > > a...@arndb.de; > > > > horms+rene...@verge.net.au; he...@sntech.de; > > > > horms+bjorn.anders...@linaro.org; > > > > enric.balle...@collabora.com; amit.kuche...@linaro.org; > > > > ezequ...@collabora.com; o...@lixom.net; devicet...@vger.kernel.org; > > > > linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > > > > linux...@vger.kernel.org; dl-linux-imx > > > > Subject: Re: [PATCH V5 2/4] thermal: imx_sc: add i.MX system > > > > controller thermal support > > > > > > > > On Thu, Dec 20, 2018 at 09:08:32AM +, Anson Huang wrote: > > > > > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller > > > > > inside, the system controller is in charge of controlling power, > > > > > clock and thermal sensors etc.. > > > > > > > > > > This patch adds i.MX system controller thermal driver support, > > > > > Linux kernel has to communicate with system controller via MU > > > > > (message > > > > > unit) IPC to get each thermal sensor's temperature, it supports > > > > > multiple sensors which are passed from device tree, please see the > > > > > binding doc for details. > > > > > > > > > > Signed-off-by: Anson Huang > > > > > --- > > > > > ChangeLog since V4: > > > > > - Add driver dependency on IMX_SCU to avoid compile error when > > > > IMX_SCU is NOT selected; > > > > > - Remove unnecessary of different errors handle for > > > > imx_scu_get_handle, already included in API. > > > > > --- > > > > > drivers/thermal/Kconfig | 11 +++ > > > > > drivers/thermal/Makefile | 1 + > > > > > drivers/thermal/imx_sc_thermal.c | 200 > > > > >
Re: [PATCH V5 2/4] thermal: imx_sc: add i.MX system controller thermal support
On Tue, Jan 22, 2019 at 06:54:30AM +, Anson Huang wrote: > Hi, Eduardo > > Best Regards! > Anson Huang Taking a look > > > -Original Message- > > From: Anson Huang > > Sent: 2019年1月10日 17:28 > > To: 'Eduardo Valentin' > > Cc: 'robh...@kernel.org' ; 'mark.rutl...@arm.com' > > ; 'catalin.mari...@arm.com' > > ; 'will.dea...@arm.com' > > ; 'rui.zh...@intel.com' ; > > 'daniel.lezc...@linaro.org' ; Aisheng Dong > > ; 's.ha...@pengutronix.de' > > ; 'shawn...@kernel.org' ; > > Andy Gross ; 'a...@arndb.de' ; > > 'horms+rene...@verge.net.au' ; > > 'he...@sntech.de' ; 'bjorn.anders...@linaro.org' > > ; 'enric.balle...@collabora.com' > > ; 'amit.kuche...@linaro.org' > > ; 'ezequ...@collabora.com' > > ; 'o...@lixom.net' ; > > 'devicet...@vger.kernel.org' ; > > 'linux-kernel@vger.kernel.org' ; > > 'linux-arm-ker...@lists.infradead.org' > > ; > > 'linux...@vger.kernel.org' ; dl-linux-imx > > > > Subject: RE: [PATCH V5 2/4] thermal: imx_sc: add i.MX system controller > > thermal support > > > > Hi, Eduardo > > > > Best Regards! > > Anson Huang > > > > > -Original Message- > > > From: Anson Huang > > > Sent: 2018年12月26日 11:36 > > > To: 'Eduardo Valentin' > > > Cc: robh...@kernel.org; mark.rutl...@arm.com; > > catalin.mari...@arm.com; > > > will.dea...@arm.com; rui.zh...@intel.com; daniel.lezc...@linaro.org; > > > Aisheng Dong ; s.ha...@pengutronix.de; > > > shawn...@kernel.org; Andy Gross ; > > > a...@arndb.de; > > > horms+rene...@verge.net.au; he...@sntech.de; > > > horms+bjorn.anders...@linaro.org; > > > enric.balle...@collabora.com; amit.kuche...@linaro.org; > > > ezequ...@collabora.com; o...@lixom.net; devicet...@vger.kernel.org; > > > linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > > > linux...@vger.kernel.org; dl-linux-imx > > > Subject: RE: [PATCH V5 2/4] thermal: imx_sc: add i.MX system > > > controller thermal support > > > > > > Hi, Eduardo > > > > > > Best Regards! > > > Anson Huang > > > > > > > -Original Message- > > > > From: Eduardo Valentin [mailto:edubez...@gmail.com] > > > > Sent: 2018年12月26日 6:44 > > > > To: Anson Huang > > > > Cc: robh...@kernel.org; mark.rutl...@arm.com; > > > catalin.mari...@arm.com; > > > > will.dea...@arm.com; rui.zh...@intel.com; daniel.lezc...@linaro.org; > > > > Aisheng Dong ; s.ha...@pengutronix.de; > > > > shawn...@kernel.org; Andy Gross ; > > > > a...@arndb.de; > > > > horms+rene...@verge.net.au; he...@sntech.de; > > > > horms+bjorn.anders...@linaro.org; > > > > enric.balle...@collabora.com; amit.kuche...@linaro.org; > > > > ezequ...@collabora.com; o...@lixom.net; devicet...@vger.kernel.org; > > > > linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > > > > linux...@vger.kernel.org; dl-linux-imx > > > > Subject: Re: [PATCH V5 2/4] thermal: imx_sc: add i.MX system > > > > controller thermal support > > > > > > > > On Thu, Dec 20, 2018 at 09:08:32AM +, Anson Huang wrote: > > > > > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller > > > > > inside, the system controller is in charge of controlling power, > > > > > clock and thermal sensors etc.. > > > > > > > > > > This patch adds i.MX system controller thermal driver support, > > > > > Linux kernel has to communicate with system controller via MU > > > > > (message > > > > > unit) IPC to get each thermal sensor's temperature, it supports > > > > > multiple sensors which are passed from device tree, please see the > > > > > binding doc for details. > > > > > > > > > > Signed-off-by: Anson Huang > > > > > --- > > > > > ChangeLog since V4: > > > > > - Add driver dependency on IMX_SCU to avoid compile error when > > > > IMX_SCU is NOT selected; > > > > > - Remove unnecessary of different errors handle for > > > > imx_scu_get_handle, already included in API. > > > > > --- > > > > > drivers/thermal/Kconfig | 11 +++ > > > > > drivers/thermal/Makefile | 1 + > > > > > drivers/thermal/imx_sc_thermal.c | 200 > > > > >
RE: [PATCH V5 2/4] thermal: imx_sc: add i.MX system controller thermal support
Hi, Eduardo Best Regards! Anson Huang > -Original Message- > From: Anson Huang > Sent: 2019年1月10日 17:28 > To: 'Eduardo Valentin' > Cc: 'robh...@kernel.org' ; 'mark.rutl...@arm.com' > ; 'catalin.mari...@arm.com' > ; 'will.dea...@arm.com' > ; 'rui.zh...@intel.com' ; > 'daniel.lezc...@linaro.org' ; Aisheng Dong > ; 's.ha...@pengutronix.de' > ; 'shawn...@kernel.org' ; > Andy Gross ; 'a...@arndb.de' ; > 'horms+rene...@verge.net.au' ; > 'he...@sntech.de' ; 'bjorn.anders...@linaro.org' > ; 'enric.balle...@collabora.com' > ; 'amit.kuche...@linaro.org' > ; 'ezequ...@collabora.com' > ; 'o...@lixom.net' ; > 'devicet...@vger.kernel.org' ; > 'linux-kernel@vger.kernel.org' ; > 'linux-arm-ker...@lists.infradead.org' ; > 'linux...@vger.kernel.org' ; dl-linux-imx > > Subject: RE: [PATCH V5 2/4] thermal: imx_sc: add i.MX system controller > thermal support > > Hi, Eduardo > > Best Regards! > Anson Huang > > > -Original Message- > > From: Anson Huang > > Sent: 2018年12月26日 11:36 > > To: 'Eduardo Valentin' > > Cc: robh...@kernel.org; mark.rutl...@arm.com; > catalin.mari...@arm.com; > > will.dea...@arm.com; rui.zh...@intel.com; daniel.lezc...@linaro.org; > > Aisheng Dong ; s.ha...@pengutronix.de; > > shawn...@kernel.org; Andy Gross ; > > a...@arndb.de; > > horms+rene...@verge.net.au; he...@sntech.de; > > horms+bjorn.anders...@linaro.org; > > enric.balle...@collabora.com; amit.kuche...@linaro.org; > > ezequ...@collabora.com; o...@lixom.net; devicet...@vger.kernel.org; > > linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > > linux...@vger.kernel.org; dl-linux-imx > > Subject: RE: [PATCH V5 2/4] thermal: imx_sc: add i.MX system > > controller thermal support > > > > Hi, Eduardo > > > > Best Regards! > > Anson Huang > > > > > -Original Message- > > > From: Eduardo Valentin [mailto:edubez...@gmail.com] > > > Sent: 2018年12月26日 6:44 > > > To: Anson Huang > > > Cc: robh...@kernel.org; mark.rutl...@arm.com; > > catalin.mari...@arm.com; > > > will.dea...@arm.com; rui.zh...@intel.com; daniel.lezc...@linaro.org; > > > Aisheng Dong ; s.ha...@pengutronix.de; > > > shawn...@kernel.org; Andy Gross ; > > > a...@arndb.de; > > > horms+rene...@verge.net.au; he...@sntech.de; > > > horms+bjorn.anders...@linaro.org; > > > enric.balle...@collabora.com; amit.kuche...@linaro.org; > > > ezequ...@collabora.com; o...@lixom.net; devicet...@vger.kernel.org; > > > linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > > > linux...@vger.kernel.org; dl-linux-imx > > > Subject: Re: [PATCH V5 2/4] thermal: imx_sc: add i.MX system > > > controller thermal support > > > > > > On Thu, Dec 20, 2018 at 09:08:32AM +, Anson Huang wrote: > > > > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller > > > > inside, the system controller is in charge of controlling power, > > > > clock and thermal sensors etc.. > > > > > > > > This patch adds i.MX system controller thermal driver support, > > > > Linux kernel has to communicate with system controller via MU > > > > (message > > > > unit) IPC to get each thermal sensor's temperature, it supports > > > > multiple sensors which are passed from device tree, please see the > > > > binding doc for details. > > > > > > > > Signed-off-by: Anson Huang > > > > --- > > > > ChangeLog since V4: > > > > - Add driver dependency on IMX_SCU to avoid compile error when > > > IMX_SCU is NOT selected; > > > > - Remove unnecessary of different errors handle for > > > imx_scu_get_handle, already included in API. > > > > --- > > > > drivers/thermal/Kconfig | 11 +++ > > > > drivers/thermal/Makefile | 1 + > > > > drivers/thermal/imx_sc_thermal.c | 200 > > > > +++ > > > > 3 files changed, 212 insertions(+) create mode 100644 > > > > drivers/thermal/imx_sc_thermal.c > > > > > > > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > > > > index 0e69edc..8d4601d 100644 > > > > --- a/drivers/thermal/Kconfig > > > > +++ b/drivers/thermal/Kconfig > > > > @@ -222,6 +222,17 @@ config IMX_THERMAL > > > > cpufreq is used as the cooling device to throttle CPUs when > > > > the > > >
RE: [PATCH V5 2/4] thermal: imx_sc: add i.MX system controller thermal support
Hi, Eduardo Best Regards! Anson Huang > -Original Message- > From: Anson Huang > Sent: 2018年12月26日 11:36 > To: 'Eduardo Valentin' > Cc: robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com; > will.dea...@arm.com; rui.zh...@intel.com; daniel.lezc...@linaro.org; > Aisheng Dong ; s.ha...@pengutronix.de; > shawn...@kernel.org; Andy Gross ; a...@arndb.de; > horms+rene...@verge.net.au; he...@sntech.de; bjorn.anders...@linaro.org; > enric.balle...@collabora.com; amit.kuche...@linaro.org; > ezequ...@collabora.com; o...@lixom.net; devicet...@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > linux...@vger.kernel.org; dl-linux-imx > Subject: RE: [PATCH V5 2/4] thermal: imx_sc: add i.MX system controller > thermal support > > Hi, Eduardo > > Best Regards! > Anson Huang > > > -Original Message- > > From: Eduardo Valentin [mailto:edubez...@gmail.com] > > Sent: 2018年12月26日 6:44 > > To: Anson Huang > > Cc: robh...@kernel.org; mark.rutl...@arm.com; > catalin.mari...@arm.com; > > will.dea...@arm.com; rui.zh...@intel.com; daniel.lezc...@linaro.org; > > Aisheng Dong ; s.ha...@pengutronix.de; > > shawn...@kernel.org; Andy Gross ; > > a...@arndb.de; > > horms+rene...@verge.net.au; he...@sntech.de; > > horms+bjorn.anders...@linaro.org; > > enric.balle...@collabora.com; amit.kuche...@linaro.org; > > ezequ...@collabora.com; o...@lixom.net; devicet...@vger.kernel.org; > > linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > > linux...@vger.kernel.org; dl-linux-imx > > Subject: Re: [PATCH V5 2/4] thermal: imx_sc: add i.MX system > > controller thermal support > > > > On Thu, Dec 20, 2018 at 09:08:32AM +, Anson Huang wrote: > > > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller > > > inside, the system controller is in charge of controlling power, > > > clock and thermal sensors etc.. > > > > > > This patch adds i.MX system controller thermal driver support, Linux > > > kernel has to communicate with system controller via MU (message > > > unit) IPC to get each thermal sensor's temperature, it supports > > > multiple sensors which are passed from device tree, please see the > > > binding doc for details. > > > > > > Signed-off-by: Anson Huang > > > --- > > > ChangeLog since V4: > > > - Add driver dependency on IMX_SCU to avoid compile error when > > IMX_SCU is NOT selected; > > > - Remove unnecessary of different errors handle for > > imx_scu_get_handle, already included in API. > > > --- > > > drivers/thermal/Kconfig | 11 +++ > > > drivers/thermal/Makefile | 1 + > > > drivers/thermal/imx_sc_thermal.c | 200 > > > +++ > > > 3 files changed, 212 insertions(+) > > > create mode 100644 drivers/thermal/imx_sc_thermal.c > > > > > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index > > > 0e69edc..8d4601d 100644 > > > --- a/drivers/thermal/Kconfig > > > +++ b/drivers/thermal/Kconfig > > > @@ -222,6 +222,17 @@ config IMX_THERMAL > > > cpufreq is used as the cooling device to throttle CPUs when the > > > passive trip is crossed. > > > > > > +config IMX_SC_THERMAL > > > + tristate "Temperature sensor driver for NXP i.MX SoCs with System > > Controller" > > > + depends on (ARCH_MXC && IMX_SCU) || COMPILE_TEST > > > + depends on OF > > > + help > > > + Support for Temperature Monitor (TEMPMON) found on NXP i.MX SoCs > > with > > > + system controller inside, Linux kernel has to communicate with system > > > + controller via MU (message unit) IPC to get temperature from thermal > > > + sensor. It supports one critical trip point and one > > > + passive trip point for each thermal sensor. > > > + > > > config MAX77620_THERMAL > > > tristate "Temperature sensor driver for Maxim MAX77620 PMIC" > > > depends on MFD_MAX77620 > > > diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile > > > index 610344e..1b13f6a 100644 > > > --- a/drivers/thermal/Makefile > > > +++ b/drivers/thermal/Makefile > > > @@ -41,6 +41,7 @@ obj-$(CONFIG_DB8500_THERMAL)+= > > db8500_thermal.o > > > obj-$(CONFIG_ARMADA_THERMAL) += armada_thermal.o > > > obj-$(CONFIG_TANGO_THERMAL) += tango_thermal.o > > > obj-$(CONFIG_IMX_THERMA
RE: [PATCH V5 2/4] thermal: imx_sc: add i.MX system controller thermal support
Hi, Eduardo
Best Regards!
Anson Huang
> -Original Message-
> From: Eduardo Valentin [mailto:edubez...@gmail.com]
> Sent: 2018年12月26日 6:44
> To: Anson Huang
> Cc: robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com;
> will.dea...@arm.com; rui.zh...@intel.com; daniel.lezc...@linaro.org;
> Aisheng Dong ; s.ha...@pengutronix.de;
> shawn...@kernel.org; Andy Gross ; a...@arndb.de;
> horms+rene...@verge.net.au; he...@sntech.de; bjorn.anders...@linaro.org;
> enric.balle...@collabora.com; amit.kuche...@linaro.org;
> ezequ...@collabora.com; o...@lixom.net; devicet...@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
> linux...@vger.kernel.org; dl-linux-imx
> Subject: Re: [PATCH V5 2/4] thermal: imx_sc: add i.MX system controller
> thermal support
>
> On Thu, Dec 20, 2018 at 09:08:32AM +, Anson Huang wrote:
> > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
> > inside, the system controller is in charge of controlling power, clock
> > and thermal sensors etc..
> >
> > This patch adds i.MX system controller thermal driver support, Linux
> > kernel has to communicate with system controller via MU (message unit)
> > IPC to get each thermal sensor's temperature, it supports multiple
> > sensors which are passed from device tree, please see the binding doc
> > for details.
> >
> > Signed-off-by: Anson Huang
> > ---
> > ChangeLog since V4:
> > - Add driver dependency on IMX_SCU to avoid compile error when
> IMX_SCU is NOT selected;
> > - Remove unnecessary of different errors handle for
> imx_scu_get_handle, already included in API.
> > ---
> > drivers/thermal/Kconfig | 11 +++
> > drivers/thermal/Makefile | 1 +
> > drivers/thermal/imx_sc_thermal.c | 200
> > +++
> > 3 files changed, 212 insertions(+)
> > create mode 100644 drivers/thermal/imx_sc_thermal.c
> >
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index
> > 0e69edc..8d4601d 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -222,6 +222,17 @@ config IMX_THERMAL
> > cpufreq is used as the cooling device to throttle CPUs when the
> > passive trip is crossed.
> >
> > +config IMX_SC_THERMAL
> > + tristate "Temperature sensor driver for NXP i.MX SoCs with System
> Controller"
> > + depends on (ARCH_MXC && IMX_SCU) || COMPILE_TEST
> > + depends on OF
> > + help
> > + Support for Temperature Monitor (TEMPMON) found on NXP i.MX SoCs
> with
> > + system controller inside, Linux kernel has to communicate with system
> > + controller via MU (message unit) IPC to get temperature from thermal
> > + sensor. It supports one critical trip point and one
> > + passive trip point for each thermal sensor.
> > +
> > config MAX77620_THERMAL
> > tristate "Temperature sensor driver for Maxim MAX77620 PMIC"
> > depends on MFD_MAX77620
> > diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile index
> > 610344e..1b13f6a 100644
> > --- a/drivers/thermal/Makefile
> > +++ b/drivers/thermal/Makefile
> > @@ -41,6 +41,7 @@ obj-$(CONFIG_DB8500_THERMAL) +=
> db8500_thermal.o
> > obj-$(CONFIG_ARMADA_THERMAL) += armada_thermal.o
> > obj-$(CONFIG_TANGO_THERMAL)+= tango_thermal.o
> > obj-$(CONFIG_IMX_THERMAL) += imx_thermal.o
> > +obj-$(CONFIG_IMX_SC_THERMAL) += imx_sc_thermal.o
> > obj-$(CONFIG_MAX77620_THERMAL) += max77620_thermal.o
> > obj-$(CONFIG_QORIQ_THERMAL)+= qoriq_thermal.o
> > obj-$(CONFIG_DA9062_THERMAL) += da9062-thermal.o
> > diff --git a/drivers/thermal/imx_sc_thermal.c
> > b/drivers/thermal/imx_sc_thermal.c
> > new file mode 100644
> > index 000..1030a31
> > --- /dev/null
> > +++ b/drivers/thermal/imx_sc_thermal.c
> > @@ -0,0 +1,200 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright 2018 NXP.
> > + */
> > +
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +
> > +#include "thermal_core.h"
> > +
> > +#define IMX_SC_MISC_FUNC_GET_TEMP 13
> > +#define IMX_SC_C_TEMP 0
> > +
> > +static struct imx_sc_ipc *thermal_ipc_handle;
> > +
> > +struct imx_sc_sensor {
> > + struct thermal_zone_device *tzd;
> > + u32 resource_id;
> >
Re: [PATCH V5 2/4] thermal: imx_sc: add i.MX system controller thermal support
On Thu, Dec 20, 2018 at 09:08:32AM +, Anson Huang wrote:
> i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
> inside, the system controller is in charge of controlling power,
> clock and thermal sensors etc..
>
> This patch adds i.MX system controller thermal driver support,
> Linux kernel has to communicate with system controller via MU
> (message unit) IPC to get each thermal sensor's temperature,
> it supports multiple sensors which are passed from device tree,
> please see the binding doc for details.
>
> Signed-off-by: Anson Huang
> ---
> ChangeLog since V4:
> - Add driver dependency on IMX_SCU to avoid compile error when IMX_SCU is
> NOT selected;
> - Remove unnecessary of different errors handle for imx_scu_get_handle,
> already included in API.
> ---
> drivers/thermal/Kconfig | 11 +++
> drivers/thermal/Makefile | 1 +
> drivers/thermal/imx_sc_thermal.c | 200
> +++
> 3 files changed, 212 insertions(+)
> create mode 100644 drivers/thermal/imx_sc_thermal.c
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 0e69edc..8d4601d 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -222,6 +222,17 @@ config IMX_THERMAL
> cpufreq is used as the cooling device to throttle CPUs when the
> passive trip is crossed.
>
> +config IMX_SC_THERMAL
> + tristate "Temperature sensor driver for NXP i.MX SoCs with System
> Controller"
> + depends on (ARCH_MXC && IMX_SCU) || COMPILE_TEST
> + depends on OF
> + help
> + Support for Temperature Monitor (TEMPMON) found on NXP i.MX SoCs with
> + system controller inside, Linux kernel has to communicate with system
> + controller via MU (message unit) IPC to get temperature from thermal
> + sensor. It supports one critical trip point and one
> + passive trip point for each thermal sensor.
> +
> config MAX77620_THERMAL
> tristate "Temperature sensor driver for Maxim MAX77620 PMIC"
> depends on MFD_MAX77620
> diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile
> index 610344e..1b13f6a 100644
> --- a/drivers/thermal/Makefile
> +++ b/drivers/thermal/Makefile
> @@ -41,6 +41,7 @@ obj-$(CONFIG_DB8500_THERMAL)+= db8500_thermal.o
> obj-$(CONFIG_ARMADA_THERMAL) += armada_thermal.o
> obj-$(CONFIG_TANGO_THERMAL) += tango_thermal.o
> obj-$(CONFIG_IMX_THERMAL)+= imx_thermal.o
> +obj-$(CONFIG_IMX_SC_THERMAL) += imx_sc_thermal.o
> obj-$(CONFIG_MAX77620_THERMAL) += max77620_thermal.o
> obj-$(CONFIG_QORIQ_THERMAL) += qoriq_thermal.o
> obj-$(CONFIG_DA9062_THERMAL) += da9062-thermal.o
> diff --git a/drivers/thermal/imx_sc_thermal.c
> b/drivers/thermal/imx_sc_thermal.c
> new file mode 100644
> index 000..1030a31
> --- /dev/null
> +++ b/drivers/thermal/imx_sc_thermal.c
> @@ -0,0 +1,200 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright 2018 NXP.
> + */
> +
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +
> +#include "thermal_core.h"
> +
> +#define IMX_SC_MISC_FUNC_GET_TEMP13
> +#define IMX_SC_C_TEMP0
> +
> +static struct imx_sc_ipc *thermal_ipc_handle;
> +
> +struct imx_sc_sensor {
> + struct thermal_zone_device *tzd;
> + u32 resource_id;
> +};
> +
> +struct imx_sc_thermal_data {
> + struct imx_sc_sensor *sensor;
> +};
> +
> +struct req_get_temp {
> + u16 resource_id;
> + u8 type;
> +} __packed;
> +
> +struct resp_get_temp {
> + u16 celsius;
> + u8 tenths;
> +} __packed;
> +
> +struct imx_sc_msg_misc_get_temp {
> + struct imx_sc_rpc_msg hdr;
> + union {
> + struct req_get_temp req;
> + struct resp_get_temp resp;
> + } data;
> +} __packed;
> +
> +static int imx_sc_thermal_get_temp(void *data, int *temp)
> +{
> + struct imx_sc_msg_misc_get_temp msg;
> + struct imx_sc_rpc_msg *hdr =
> + struct imx_sc_sensor *sensor = data;
> + int ret;
> +
> + msg.data.req.resource_id = sensor->resource_id;
> + msg.data.req.type = IMX_SC_C_TEMP;
> +
> + hdr->ver = IMX_SC_RPC_VERSION;
> + hdr->svc = IMX_SC_RPC_SVC_MISC;
> + hdr->func = IMX_SC_MISC_FUNC_GET_TEMP;
> + hdr->size = 2;
> +
> + ret = imx_scu_call_rpc(thermal_ipc_handle, , true);
> + if (ret) {
> + pr_err("read temp sensor %d failed, ret %d\n",
> + sensor->resource_id, ret);
> + return ret;
> + }
> +
> + *temp = msg.data.resp.celsius * 1000 + msg.data.resp.tenths * 100;
> +
> + return 0;
> +}
> +
> +static const struct thermal_zone_of_device_ops imx_sc_thermal_ops = {
> + .get_temp = imx_sc_thermal_get_temp,
> +};
> +
> +static int imx_sc_thermal_register_sensor(struct platform_device *pdev,
> + struct imx_sc_sensor *sensor)
> +{
> + struct thermal_zone_device *tzd;
> +
> + tzd =
[PATCH V5 2/4] thermal: imx_sc: add i.MX system controller thermal support
i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
inside, the system controller is in charge of controlling power,
clock and thermal sensors etc..
This patch adds i.MX system controller thermal driver support,
Linux kernel has to communicate with system controller via MU
(message unit) IPC to get each thermal sensor's temperature,
it supports multiple sensors which are passed from device tree,
please see the binding doc for details.
Signed-off-by: Anson Huang
---
ChangeLog since V4:
- Add driver dependency on IMX_SCU to avoid compile error when IMX_SCU is
NOT selected;
- Remove unnecessary of different errors handle for imx_scu_get_handle,
already included in API.
---
drivers/thermal/Kconfig | 11 +++
drivers/thermal/Makefile | 1 +
drivers/thermal/imx_sc_thermal.c | 200 +++
3 files changed, 212 insertions(+)
create mode 100644 drivers/thermal/imx_sc_thermal.c
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 0e69edc..8d4601d 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -222,6 +222,17 @@ config IMX_THERMAL
cpufreq is used as the cooling device to throttle CPUs when the
passive trip is crossed.
+config IMX_SC_THERMAL
+ tristate "Temperature sensor driver for NXP i.MX SoCs with System
Controller"
+ depends on (ARCH_MXC && IMX_SCU) || COMPILE_TEST
+ depends on OF
+ help
+ Support for Temperature Monitor (TEMPMON) found on NXP i.MX SoCs with
+ system controller inside, Linux kernel has to communicate with system
+ controller via MU (message unit) IPC to get temperature from thermal
+ sensor. It supports one critical trip point and one
+ passive trip point for each thermal sensor.
+
config MAX77620_THERMAL
tristate "Temperature sensor driver for Maxim MAX77620 PMIC"
depends on MFD_MAX77620
diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile
index 610344e..1b13f6a 100644
--- a/drivers/thermal/Makefile
+++ b/drivers/thermal/Makefile
@@ -41,6 +41,7 @@ obj-$(CONFIG_DB8500_THERMAL) += db8500_thermal.o
obj-$(CONFIG_ARMADA_THERMAL) += armada_thermal.o
obj-$(CONFIG_TANGO_THERMAL)+= tango_thermal.o
obj-$(CONFIG_IMX_THERMAL) += imx_thermal.o
+obj-$(CONFIG_IMX_SC_THERMAL) += imx_sc_thermal.o
obj-$(CONFIG_MAX77620_THERMAL) += max77620_thermal.o
obj-$(CONFIG_QORIQ_THERMAL)+= qoriq_thermal.o
obj-$(CONFIG_DA9062_THERMAL) += da9062-thermal.o
diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
new file mode 100644
index 000..1030a31
--- /dev/null
+++ b/drivers/thermal/imx_sc_thermal.c
@@ -0,0 +1,200 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2018 NXP.
+ */
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "thermal_core.h"
+
+#define IMX_SC_MISC_FUNC_GET_TEMP 13
+#define IMX_SC_C_TEMP 0
+
+static struct imx_sc_ipc *thermal_ipc_handle;
+
+struct imx_sc_sensor {
+ struct thermal_zone_device *tzd;
+ u32 resource_id;
+};
+
+struct imx_sc_thermal_data {
+ struct imx_sc_sensor *sensor;
+};
+
+struct req_get_temp {
+ u16 resource_id;
+ u8 type;
+} __packed;
+
+struct resp_get_temp {
+ u16 celsius;
+ u8 tenths;
+} __packed;
+
+struct imx_sc_msg_misc_get_temp {
+ struct imx_sc_rpc_msg hdr;
+ union {
+ struct req_get_temp req;
+ struct resp_get_temp resp;
+ } data;
+} __packed;
+
+static int imx_sc_thermal_get_temp(void *data, int *temp)
+{
+ struct imx_sc_msg_misc_get_temp msg;
+ struct imx_sc_rpc_msg *hdr =
+ struct imx_sc_sensor *sensor = data;
+ int ret;
+
+ msg.data.req.resource_id = sensor->resource_id;
+ msg.data.req.type = IMX_SC_C_TEMP;
+
+ hdr->ver = IMX_SC_RPC_VERSION;
+ hdr->svc = IMX_SC_RPC_SVC_MISC;
+ hdr->func = IMX_SC_MISC_FUNC_GET_TEMP;
+ hdr->size = 2;
+
+ ret = imx_scu_call_rpc(thermal_ipc_handle, , true);
+ if (ret) {
+ pr_err("read temp sensor %d failed, ret %d\n",
+ sensor->resource_id, ret);
+ return ret;
+ }
+
+ *temp = msg.data.resp.celsius * 1000 + msg.data.resp.tenths * 100;
+
+ return 0;
+}
+
+static const struct thermal_zone_of_device_ops imx_sc_thermal_ops = {
+ .get_temp = imx_sc_thermal_get_temp,
+};
+
+static int imx_sc_thermal_register_sensor(struct platform_device *pdev,
+ struct imx_sc_sensor *sensor)
+{
+ struct thermal_zone_device *tzd;
+
+ tzd = devm_thermal_zone_of_sensor_register(>dev,
+ sensor->resource_id,
+ sensor,
+ _sc_thermal_ops);
+ if (IS_ERR(tzd)) {
+
