Re: [PATCH V6 21/21] arm64: dts: tegra210-p3450: Jetson nano SC7 timings

2019-07-21 Thread Dmitry Osipenko
21.07.2019 22:41, Sowjanya Komatineni пишет:
> This patch adds Jetson nano platform specific SC7 timing configuration
> in the device tree.

You should stat all names with a capital letter, hence "Jetson Nano" and
"Tegra" in all patches (commit title/message and code comments). When
unsure, just go to google and find how official name looks like.

> Signed-off-by: Sowjanya Komatineni 
> ---
>  arch/arm64/boot/dts/nvidia/tegra210-p3450-.dts | 7 +++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p3450-.dts 
> b/arch/arm64/boot/dts/nvidia/tegra210-p3450-.dts
> index 9d17ec707bce..b525e69c172a 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210-p3450-.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra210-p3450-.dts
> @@ -382,6 +382,13 @@
>  
>   pmc@7000e400 {
>   nvidia,invert-interrupt;
> + nvidia,suspend-mode = <0>;
> + nvidia,cpu-pwr-good-time = <0>;
> + nvidia,cpu-pwr-off-time = <0>;
> + nvidia,core-pwr-good-time = <4587 3876>;
> + nvidia,core-pwr-off-time = <39065>;
> + nvidia,core-power-req-active-high;
> + nvidia,sys-clock-req-active-high;
>   };
>  
>   hda@7003 {
> 



[PATCH V6 21/21] arm64: dts: tegra210-p3450: Jetson nano SC7 timings

2019-07-21 Thread Sowjanya Komatineni
This patch adds Jetson nano platform specific SC7 timing configuration
in the device tree.

Signed-off-by: Sowjanya Komatineni 
---
 arch/arm64/boot/dts/nvidia/tegra210-p3450-.dts | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p3450-.dts 
b/arch/arm64/boot/dts/nvidia/tegra210-p3450-.dts
index 9d17ec707bce..b525e69c172a 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-p3450-.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra210-p3450-.dts
@@ -382,6 +382,13 @@
 
pmc@7000e400 {
nvidia,invert-interrupt;
+   nvidia,suspend-mode = <0>;
+   nvidia,cpu-pwr-good-time = <0>;
+   nvidia,cpu-pwr-off-time = <0>;
+   nvidia,core-pwr-good-time = <4587 3876>;
+   nvidia,core-pwr-off-time = <39065>;
+   nvidia,core-power-req-active-high;
+   nvidia,sys-clock-req-active-high;
};
 
hda@7003 {
-- 
2.7.4