Re: [PATCH V7 01/13] dt-bindings: soc: Add dvfsrc driver bindings
On Mon, 2021-01-11 at 09:42 -0600, Rob Herring wrote: > On Sun, Jan 10, 2021 at 8:52 PM Henry Chen wrote: > > > > Hi Rob, > > > > On Fri, 2021-01-08 at 20:30 -0700, Rob Herring wrote: > > > On Fri, 08 Jan 2021 15:48:03 +0800, Henry Chen wrote: > > > > Document the binding for enabling dvfsrc on MediaTek SoC. > > > > > > > > Signed-off-by: Henry Chen > > > > --- > > > > .../devicetree/bindings/soc/mediatek/dvfsrc.yaml | 67 > > > > ++ > > > > 1 file changed, 67 insertions(+) > > > > create mode 100644 > > > > Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml > > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > yamllint warnings/errors: > > > > > > dtschema/dtc warnings/errors: > > > Documentation/devicetree/bindings/soc/mediatek/dvfsrc.example.dts:19:18: > > > fatal error: dt-bindings/interconnect/mtk,mt8183-emi.h: No such file or > > > directory > > >19 | #include > > > | ^~~ > > Sorry, because this header file is added on "[V7,07/13] dt-bindings: > > interconnect: add MT8183 interconnect dt-bindings". > > Should I change the order of the patchset (let the yaml pathc behind the > > header) to fixed that ? > > DT headers should be part of the binding schema patch. (Or at least come > first). OK, I will merge DT header and binding schema patch into a single patch. Henry > > Rob
Re: [PATCH V7 01/13] dt-bindings: soc: Add dvfsrc driver bindings
On Sun, Jan 10, 2021 at 8:52 PM Henry Chen wrote: > > Hi Rob, > > On Fri, 2021-01-08 at 20:30 -0700, Rob Herring wrote: > > On Fri, 08 Jan 2021 15:48:03 +0800, Henry Chen wrote: > > > Document the binding for enabling dvfsrc on MediaTek SoC. > > > > > > Signed-off-by: Henry Chen > > > --- > > > .../devicetree/bindings/soc/mediatek/dvfsrc.yaml | 67 > > > ++ > > > 1 file changed, 67 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Documentation/devicetree/bindings/soc/mediatek/dvfsrc.example.dts:19:18: > > fatal error: dt-bindings/interconnect/mtk,mt8183-emi.h: No such file or > > directory > >19 | #include > > | ^~~ > Sorry, because this header file is added on "[V7,07/13] dt-bindings: > interconnect: add MT8183 interconnect dt-bindings". > Should I change the order of the patchset (let the yaml pathc behind the > header) to fixed that ? DT headers should be part of the binding schema patch. (Or at least come first). Rob
Re: [PATCH V7 01/13] dt-bindings: soc: Add dvfsrc driver bindings
Hi Rob, On Fri, 2021-01-08 at 20:30 -0700, Rob Herring wrote: > On Fri, 08 Jan 2021 15:48:03 +0800, Henry Chen wrote: > > Document the binding for enabling dvfsrc on MediaTek SoC. > > > > Signed-off-by: Henry Chen > > --- > > .../devicetree/bindings/soc/mediatek/dvfsrc.yaml | 67 > > ++ > > 1 file changed, 67 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/soc/mediatek/dvfsrc.example.dts:19:18: > fatal error: dt-bindings/interconnect/mtk,mt8183-emi.h: No such file or > directory >19 | #include > | ^~~ Sorry, because this header file is added on "[V7,07/13] dt-bindings: interconnect: add MT8183 interconnect dt-bindings". Should I change the order of the patchset (let the yaml pathc behind the header) to fixed that ? Thanks, Henry > compilation terminated. > make[1]: *** [scripts/Makefile.lib:344: > Documentation/devicetree/bindings/soc/mediatek/dvfsrc.example.dt.yaml] Error 1 > make: *** [Makefile:1370: dt_binding_check] Error 2 > > See https://patchwork.ozlabs.org/patch/1423679 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. >
Re: [PATCH V7 01/13] dt-bindings: soc: Add dvfsrc driver bindings
On Fri, 08 Jan 2021 15:48:03 +0800, Henry Chen wrote: > Document the binding for enabling dvfsrc on MediaTek SoC. > > Signed-off-by: Henry Chen > --- > .../devicetree/bindings/soc/mediatek/dvfsrc.yaml | 67 > ++ > 1 file changed, 67 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/soc/mediatek/dvfsrc.example.dts:19:18: fatal error: dt-bindings/interconnect/mtk,mt8183-emi.h: No such file or directory 19 | #include | ^~~ compilation terminated. make[1]: *** [scripts/Makefile.lib:344: Documentation/devicetree/bindings/soc/mediatek/dvfsrc.example.dt.yaml] Error 1 make: *** [Makefile:1370: dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1423679 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
[PATCH V7 01/13] dt-bindings: soc: Add dvfsrc driver bindings
Document the binding for enabling dvfsrc on MediaTek SoC.
Signed-off-by: Henry Chen
---
.../devicetree/bindings/soc/mediatek/dvfsrc.yaml | 67 ++
1 file changed, 67 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml
diff --git a/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml
b/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml
new file mode 100644
index 000..0b746a8
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml
@@ -0,0 +1,67 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/mediatek/dvfsrc.yaml#;
+$schema: "http://devicetree.org/meta-schemas/core.yaml#;
+
+title: MediaTek dynamic voltage and frequency scaling resource collector
(DVFSRC)
+
+description: |
+ The Dynamic Voltage and Frequency Scaling Resource Collector (DVFSRC) is a
+ HW module which is used to collect all the requests from both software and
+ hardware and turn into the decision of minimum operating voltage and minimum
+ DRAM frequency to fulfill those requests.
+
+maintainers:
+ - henryc.chen
+
+properties:
+ reg:
+description: DVFSRC common register address and length.
+
+ compatible:
+enum:
+ - mediatek,mt6873-dvfsrc
+ - mediatek,mt8183-dvfsrc
+ - mediatek,mt8192-dvfsrc
+
+ '#interconnect-cells':
+const: 1
+
+patternProperties:
+ dvfsrc-vcore:
+type: object
+description:
+ The DVFSRC regulator is modelled as a subdevice of the DVFSRC.
+ Because DVFSRC can request power directly via register read/write, likes
+ vcore which is a core power of mt8183. As such, the DVFSRC regulator
+ requires that DVFSRC nodes be present.
+$ref: /schemas/regulator/regulator.yaml#
+
+required:
+ - compatible
+ - reg
+ - "#interconnect-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+#include
+
+soc {
+#address-cells = <2>;
+#size-cells = <2>;
+
+dvfsrc@10012000 {
+compatible = "mediatek,mt8183-dvfsrc";
+reg = <0 0x10012000 0 0x1000>;
+#interconnect-cells = <1>;
+dvfsrc_vcore: dvfsrc-vcore {
+regulator-name = "dvfsrc-vcore";
+regulator-min-microvolt = <725000>;
+regulator-max-microvolt = <80>;
+regulator-always-on;
+};
+};
+};
--
1.9.1
