Re: [PATCH char-misc-next 1/1] misc: mic: remove the MIC drivers
On Tue, Oct 27, 2020 at 08:14:15PM -0700, Sudeep Dutt wrote: > This patch removes the MIC drivers from the kernel tree > since the corresponding devices have been discontinued. Does "discontinued" mean "never shipped a device so no one has access to this hardware anymore", or does it mean "we stopped shipping devices and there are customers with this?" > Removing the dma and char-misc changes in one patch and > merging via the char-misc tree is best to avoid any > potential build breakage. > > Cc: Nikhil Rao > Reviewed-by: Ashutosh Dixit > Signed-off-by: Sudeep Dutt I like deleting code, can this go into 5.10-final? thanks, greg k-h
Re: [PATCH char-misc-next 1/1] misc: mic: remove the MIC drivers
On Wed, 2020-10-28 at 06:54 +0100, Greg Kroah-Hartman wrote: > On Tue, Oct 27, 2020 at 08:14:15PM -0700, Sudeep Dutt wrote: > > This patch removes the MIC drivers from the kernel tree > > since the corresponding devices have been discontinued. > > Does "discontinued" mean "never shipped a device so no one has access > to > this hardware anymore", or does it mean "we stopped shipping devices > and > there are customers with this?" Hi Greg, We are not aware of any customers of the upstreamed MIC drivers. The drivers were upstreamed primarily to lay a foundation for enabling the next generation MIC devices which did not ship. > > Removing the dma and char-misc changes in one patch and > > merging via the char-misc tree is best to avoid any > > potential build breakage. > > > > Cc: Nikhil Rao > > Reviewed-by: Ashutosh Dixit > > Signed-off-by: Sudeep Dutt > > I like deleting code, can this go into 5.10-final? Yes, we would prefer this goes into v5.10. I am hoping you can carry the Ack from Vinod and the Reviewed-by from Sherry but I can resend the patch with those updates in the commit message if required. I did verify that this patch passes allmodconfig and allyesconfig builds with your latest char-misc-next tree. Many thanks for your help with this subsystem Greg. Best Regards, Sudeep Dutt
Re: [PATCH char-misc-next 1/1] misc: mic: remove the MIC drivers
On 28-10-20, 06:54, Greg Kroah-Hartman wrote: > On Tue, Oct 27, 2020 at 08:14:15PM -0700, Sudeep Dutt wrote: > > This patch removes the MIC drivers from the kernel tree > > since the corresponding devices have been discontinued. > > Does "discontinued" mean "never shipped a device so no one has access to > this hardware anymore", or does it mean "we stopped shipping devices and > there are customers with this?" > > > Removing the dma and char-misc changes in one patch and > > merging via the char-misc tree is best to avoid any > > potential build breakage. > > > > Cc: Nikhil Rao > > Reviewed-by: Ashutosh Dixit > > Signed-off-by: Sudeep Dutt > > I like deleting code, can this go into 5.10-final? I would like that, if unused lets get it cleaned now rather than later :-) Said that, for all dmaengine bits: Acked-By: Vinod Koul -- ~Vinod
Re: [PATCH char-misc-next 1/1] misc: mic: remove the MIC drivers
On Wed, Oct 28, 2020 at 05:22:01PM +, Dutt, Sudeep wrote: > On Wed, 2020-10-28 at 06:54 +0100, Greg Kroah-Hartman wrote: > > On Tue, Oct 27, 2020 at 08:14:15PM -0700, Sudeep Dutt wrote: > > > This patch removes the MIC drivers from the kernel tree > > > since the corresponding devices have been discontinued. > > > > Does "discontinued" mean "never shipped a device so no one has access > > to > > this hardware anymore", or does it mean "we stopped shipping devices > > and > > there are customers with this?" > > Hi Greg, > > We are not aware of any customers of the upstreamed MIC drivers. The > drivers were upstreamed primarily to lay a foundation for enabling the > next generation MIC devices which did not ship. Ok, thanks for the explanation. > > > > Removing the dma and char-misc changes in one patch and > > > merging via the char-misc tree is best to avoid any > > > potential build breakage. > > > > > > Cc: Nikhil Rao > > > Reviewed-by: Ashutosh Dixit > > > Signed-off-by: Sudeep Dutt > > > > I like deleting code, can this go into 5.10-final? > > Yes, we would prefer this goes into v5.10. I am hoping you can carry > the Ack from Vinod and the Reviewed-by from Sherry but I can resend the > patch with those updates in the commit message if required. I did > verify that this patch passes allmodconfig and allyesconfig builds with > your latest char-misc-next tree. I can pick them up automatically, no worries, thanks! greg k-h
