From: Lijun Ou <ouli...@huawei.com> While the page size attribute of umem is illegal, we should release umem that get by ib_umem_get interface.
Also, we should return a non-zero value while pbl number is wrong. Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Dongdong Huang(Donald) <hdd.hu...@huawei.com> Reviewed-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Salil Mehta <salil.me...@huawei.com> --- drivers/infiniband/hw/hns/hns_roce_mr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/infiniband/hw/hns/hns_roce_mr.c b/drivers/infiniband/hw/hns/hns_roce_mr.c index 59f5e2b..fb87883 100644 --- a/drivers/infiniband/hw/hns/hns_roce_mr.c +++ b/drivers/infiniband/hw/hns/hns_roce_mr.c @@ -564,11 +564,14 @@ struct ib_mr *hns_roce_reg_user_mr(struct ib_pd *pd, u64 start, u64 length, if (mr->umem->page_size != HNS_ROCE_HEM_PAGE_SIZE) { dev_err(dev, "Just support 4K page size but is 0x%x now!\n", mr->umem->page_size); + ret = -EINVAL; + goto err_umem; } if (n > HNS_ROCE_MAX_MTPT_PBL_NUM) { dev_err(dev, " MR len %lld err. MR is limited to 4G at most!\n", length); + ret = -EINVAL; goto err_umem; } -- 1.7.9.5