[PATCH net-next] net: 3c509: mark expected switch fall-throughs

2019-01-22 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

This patch fixes the following warnings:

drivers/net/ethernet/3com/3c509.c:1265:8: warning: this statement may fall 
through [-Wimplicit-fallthrough=]
drivers/net/ethernet/3com/3c509.c:1271:8: warning: this statement may fall 
through [-Wimplicit-fallthrough=]

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enabling
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva 
---
 drivers/net/ethernet/3com/3c509.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/3com/3c509.c 
b/drivers/net/ethernet/3com/3c509.c
index b223769d6a5e..3da97996bdf3 100644
--- a/drivers/net/ethernet/3com/3c509.c
+++ b/drivers/net/ethernet/3com/3c509.c
@@ -1266,12 +1266,14 @@ el3_up(struct net_device *dev)
pr_cont("Forcing 3c5x9b full-duplex 
mode");
break;
}
+   /* fall through */
case 8:
/* set full-duplex mode based on eeprom config 
setting */
if ((sw_info & 0x000f) && (sw_info & 0x8000)) {
pr_cont("Setting 3c5x9b full-duplex 
mode (from EEPROM configuration bit)");
break;
}
+   /* fall through */
default:
/* xcvr=(0 || 4) OR user has an old 3c5x9 non 
"B" model */
pr_cont("Setting 3c5x9/3c5x9B half-duplex 
mode");
-- 
2.20.1



Re: [PATCH net-next] net: 3c509: mark expected switch fall-throughs

2019-01-23 Thread David Miller
From: "Gustavo A. R. Silva" 
Date: Wed, 23 Jan 2019 01:29:55 -0600

> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> This patch fixes the following warnings:
> 
> drivers/net/ethernet/3com/3c509.c:1265:8: warning: this statement may fall 
> through [-Wimplicit-fallthrough=]
> drivers/net/ethernet/3com/3c509.c:1271:8: warning: this statement may fall 
> through [-Wimplicit-fallthrough=]
> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 
> This patch is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough.
> 
> Signed-off-by: Gustavo A. R. Silva 

Applied.