Re: [PATCH net-next] net: dsa: Remove redundant NULL dst check

[David Miller]

From: Florian Fainelli 
Date: Thu, 20 Apr 2017 15:47:22 -0700

> tag_lan9303.c does check for a NULL dst but that's already checked by
> dsa_switch_rcv() one layer above.
> 
> Signed-off-by: Florian Fainelli 

Applied, thank you.

Re: [PATCH net-next] net: dsa: Remove redundant NULL dst check

[David Miller]

From: Florian Fainelli 
Date: Thu, 20 Apr 2017 15:47:22 -0700

> tag_lan9303.c does check for a NULL dst but that's already checked by
> dsa_switch_rcv() one layer above.
> 
> Signed-off-by: Florian Fainelli 

Applied, thank you.

Re: [PATCH net-next] net: dsa: Remove redundant NULL dst check

[Juergen Borleis]

Hi Florian,

On Friday 21 April 2017 00:47:22 Florian Fainelli wrote:
> tag_lan9303.c does check for a NULL dst but that's already checked by
> dsa_switch_rcv() one layer above.
>
> Signed-off-by: Florian Fainelli 
> ---
>  net/dsa/tag_lan9303.c | 5 -
>  1 file changed, 5 deletions(-)
>
> diff --git a/net/dsa/tag_lan9303.c b/net/dsa/tag_lan9303.c
> index 563b6c8fe445..70130ed5c21a 100644
> --- a/net/dsa/tag_lan9303.c
> +++ b/net/dsa/tag_lan9303.c
> @@ -79,11 +79,6 @@ static struct sk_buff *lan9303_rcv(struct sk_buff
> *skb, struct net_device *dev, struct dsa_switch *ds;
>   unsigned int source_port;
>
> - if (unlikely(!dst)) {
> - dev_warn_ratelimited(>dev, "Dropping packet, due to 
> missing switch tree device\n");
> - return NULL; 
> - }
> -
>   ds = dst->ds[0];
>
>   if (unlikely(!ds)) {

Thanks!

Acked-by: Juergen Borleis 

-- 
Pengutronix e.K.                             | Juergen Borleis             |
Industrial Linux Solutions                   | http://www.pengutronix.de/  |

Re: [PATCH net-next] net: dsa: Remove redundant NULL dst check

[Juergen Borleis]

Hi Florian,

On Friday 21 April 2017 00:47:22 Florian Fainelli wrote:
> tag_lan9303.c does check for a NULL dst but that's already checked by
> dsa_switch_rcv() one layer above.
>
> Signed-off-by: Florian Fainelli 
> ---
>  net/dsa/tag_lan9303.c | 5 -
>  1 file changed, 5 deletions(-)
>
> diff --git a/net/dsa/tag_lan9303.c b/net/dsa/tag_lan9303.c
> index 563b6c8fe445..70130ed5c21a 100644
> --- a/net/dsa/tag_lan9303.c
> +++ b/net/dsa/tag_lan9303.c
> @@ -79,11 +79,6 @@ static struct sk_buff *lan9303_rcv(struct sk_buff
> *skb, struct net_device *dev, struct dsa_switch *ds;
>   unsigned int source_port;
>
> - if (unlikely(!dst)) {
> - dev_warn_ratelimited(>dev, "Dropping packet, due to 
> missing switch tree device\n");
> - return NULL; 
> - }
> -
>   ds = dst->ds[0];
>
>   if (unlikely(!ds)) {

Thanks!

Acked-by: Juergen Borleis 

-- 
Pengutronix e.K.                             | Juergen Borleis             |
Industrial Linux Solutions                   | http://www.pengutronix.de/  |

[PATCH net-next] net: dsa: Remove redundant NULL dst check

[Florian Fainelli]

tag_lan9303.c does check for a NULL dst but that's already checked by
dsa_switch_rcv() one layer above.

Signed-off-by: Florian Fainelli 
---
 net/dsa/tag_lan9303.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/net/dsa/tag_lan9303.c b/net/dsa/tag_lan9303.c
index 563b6c8fe445..70130ed5c21a 100644
--- a/net/dsa/tag_lan9303.c
+++ b/net/dsa/tag_lan9303.c
@@ -79,11 +79,6 @@ static struct sk_buff *lan9303_rcv(struct sk_buff *skb, 
struct net_device *dev,
struct dsa_switch *ds;
unsigned int source_port;
 
-   if (unlikely(!dst)) {
-   dev_warn_ratelimited(>dev, "Dropping packet, due to 
missing switch tree device\n");
-   return NULL;
-   }
-
ds = dst->ds[0];
 
if (unlikely(!ds)) {
-- 
2.9.3

[PATCH net-next] net: dsa: Remove redundant NULL dst check

[Florian Fainelli]

tag_lan9303.c does check for a NULL dst but that's already checked by
dsa_switch_rcv() one layer above.

Signed-off-by: Florian Fainelli 
---
 net/dsa/tag_lan9303.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/net/dsa/tag_lan9303.c b/net/dsa/tag_lan9303.c
index 563b6c8fe445..70130ed5c21a 100644
--- a/net/dsa/tag_lan9303.c
+++ b/net/dsa/tag_lan9303.c
@@ -79,11 +79,6 @@ static struct sk_buff *lan9303_rcv(struct sk_buff *skb, 
struct net_device *dev,
struct dsa_switch *ds;
unsigned int source_port;
 
-   if (unlikely(!dst)) {
-   dev_warn_ratelimited(>dev, "Dropping packet, due to 
missing switch tree device\n");
-   return NULL;
-   }
-
ds = dst->ds[0];
 
if (unlikely(!ds)) {
-- 
2.9.3