Re: [PATCH net-next] tipc: mark expected switch fall-throughs

2019-01-23 Thread David Miller
From: "Gustavo A. R. Silva" 
Date: Wed, 23 Jan 2019 01:09:31 -0600

> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> This patch fixes the following warnings:
> 
> net/tipc/link.c:1125:6: warning: this statement may fall through 
> [-Wimplicit-fallthrough=]
> net/tipc/socket.c:736:6: warning: this statement may fall through 
> [-Wimplicit-fallthrough=]
> net/tipc/socket.c:2418:7: warning: this statement may fall through 
> [-Wimplicit-fallthrough=]
> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 
> This patch is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough.
> 
> Signed-off-by: Gustavo A. R. Silva 

Applied.


[PATCH net-next] tipc: mark expected switch fall-throughs

2019-01-22 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

This patch fixes the following warnings:

net/tipc/link.c:1125:6: warning: this statement may fall through 
[-Wimplicit-fallthrough=]
net/tipc/socket.c:736:6: warning: this statement may fall through 
[-Wimplicit-fallthrough=]
net/tipc/socket.c:2418:7: warning: this statement may fall through 
[-Wimplicit-fallthrough=]

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enabling
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva 
---
 net/tipc/link.c   | 2 +-
 net/tipc/socket.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/tipc/link.c b/net/tipc/link.c
index 2792a3cae682..ac306d17f8ad 100644
--- a/net/tipc/link.c
+++ b/net/tipc/link.c
@@ -1126,7 +1126,7 @@ static bool tipc_data_input(struct tipc_link *l, struct 
sk_buff *skb,
skb_queue_tail(mc_inputq, skb);
return true;
}
-   /* else: fall through */
+   /* fall through */
case CONN_MANAGER:
skb_queue_tail(inputq, skb);
return true;
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index 1217c90a363b..8fc5acd4820d 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket.c
@@ -735,7 +735,7 @@ static __poll_t tipc_poll(struct file *file, struct socket 
*sock,
case TIPC_CONNECTING:
if (!tsk->cong_link_cnt && !tsk_conn_cong(tsk))
revents |= EPOLLOUT;
-   /* fall thru' */
+   /* fall through */
case TIPC_LISTEN:
if (!skb_queue_empty(>sk_receive_queue))
revents |= EPOLLIN | EPOLLRDNORM;
@@ -2416,7 +2416,7 @@ static int tipc_connect(struct socket *sock, struct 
sockaddr *dest,
 * case is EINPROGRESS, rather than EALREADY.
 */
res = -EINPROGRESS;
-   /* fall thru' */
+   /* fall through */
case TIPC_CONNECTING:
if (!timeout) {
if (previous == TIPC_CONNECTING)
-- 
2.20.1