Re: [PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver
On 2019/6/1 8:18, David Miller wrote: From: David Miller Date: Fri, 31 May 2019 17:15:29 -0700 (PDT) From: Huazhong Tan Date: Fri, 31 May 2019 16:54:46 +0800 This patch-set includes code optimizations and bugfixes for the HNS3 ethernet controller driver. [patch 1/12] removes the redundant core reset type [patch 2/12 - 3/12] fixes two VLAN related issues [patch 4/12] fixes a TM issue [patch 5/12 - 12/12] includes some patches related to RAS & MSI-X error Series applied. I reverted, you need to actually build test the infiniband side of your driver. drivers/infiniband/hw/hns/hns_roce_hw_v2.c: In function ‘hns_roce_v2_msix_interrupt_abn’: drivers/infiniband/hw/hns/hns_roce_hw_v2.c:5032:14: warning: passing argument 2 of ‘ops->set_default_reset_request’ makes pointer from integer without a cast [-Wint-conversion] HNAE3_FUNC_RESET); ^~~~ drivers/infiniband/hw/hns/hns_roce_hw_v2.c:5032:14: note: expected ‘long unsigned int *’ but argument is of type ‘int’ C-c C-cmake[5]: *** Deleting file 'drivers/net/wireless/ath/carl9170/cmd.o' Sorry, I will remove [10/12 - 11/12] for V2, these two patches needs to modify HNS's infiniband driver at the same time, so they will be upstreamed later with the infiniband's one.
Re: [PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver
From: David Miller Date: Fri, 31 May 2019 17:15:29 -0700 (PDT) > From: Huazhong Tan > Date: Fri, 31 May 2019 16:54:46 +0800 > >> This patch-set includes code optimizations and bugfixes for the HNS3 >> ethernet controller driver. >> >> [patch 1/12] removes the redundant core reset type >> >> [patch 2/12 - 3/12] fixes two VLAN related issues >> >> [patch 4/12] fixes a TM issue >> >> [patch 5/12 - 12/12] includes some patches related to RAS & MSI-X error > > Series applied. I reverted, you need to actually build test the infiniband side of your driver. drivers/infiniband/hw/hns/hns_roce_hw_v2.c: In function ‘hns_roce_v2_msix_interrupt_abn’: drivers/infiniband/hw/hns/hns_roce_hw_v2.c:5032:14: warning: passing argument 2 of ‘ops->set_default_reset_request’ makes pointer from integer without a cast [-Wint-conversion] HNAE3_FUNC_RESET); ^~~~ drivers/infiniband/hw/hns/hns_roce_hw_v2.c:5032:14: note: expected ‘long unsigned int *’ but argument is of type ‘int’ C-c C-cmake[5]: *** Deleting file 'drivers/net/wireless/ath/carl9170/cmd.o'
Re: [PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver
From: Huazhong Tan Date: Fri, 31 May 2019 16:54:46 +0800 > This patch-set includes code optimizations and bugfixes for the HNS3 > ethernet controller driver. > > [patch 1/12] removes the redundant core reset type > > [patch 2/12 - 3/12] fixes two VLAN related issues > > [patch 4/12] fixes a TM issue > > [patch 5/12 - 12/12] includes some patches related to RAS & MSI-X error Series applied.
[PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver
This patch-set includes code optimizations and bugfixes for the HNS3 ethernet controller driver. [patch 1/12] removes the redundant core reset type [patch 2/12 - 3/12] fixes two VLAN related issues [patch 4/12] fixes a TM issue [patch 5/12 - 12/12] includes some patches related to RAS & MSI-X error Huazhong Tan (1): net: hns3: remove redundant core reset Jian Shen (2): net: hns3: don't configure new VLAN ID into VF VLAN table when it's full net: hns3: fix VLAN filter restore issue after reset Shiju Jose (2): net: hns3: delay setting of reset level for HW errors until slot_reset is called net: hns3: fix avoid unnecessary resetting for the H/W errors which do not require reset Weihang Li (6): net: hns3: add a check to pointer in error_detected and slot_reset net: hns3: set ops to null when unregister ad_dev net: hns3: add handling of two bits in MAC tunnel interrupts net: hns3: remove setting bit of reset_requests when handling mac tunnel interrupts net: hns3: add opcode about query and clear RAS & MSI-X to special opcode net: hns3: delay and separate enabling of NIC and ROCE HW errors Yunsheng Lin (1): net: hns3: set the port shaper according to MAC speed drivers/net/ethernet/hisilicon/hns3/hnae3.c| 2 + drivers/net/ethernet/hisilicon/hns3/hnae3.h| 10 +- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 55 +--- drivers/net/ethernet/hisilicon/hns3/hns3_enet.h| 1 - .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c | 6 +- .../ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c | 2 +- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 351 - .../net/ethernet/hisilicon/hns3/hns3pf/hclge_err.h | 9 +- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 137 +--- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.h| 1 + .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 2 +- .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 12 +- 12 files changed, 268 insertions(+), 320 deletions(-) -- 2.7.4
Re: [PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver
From: Huazhong Tan Date: Tue, 28 May 2019 17:02:50 +0800 > This patch-set includes code optimizations and bugfixes for the HNS3 > ethernet controller driver. > > [patch 1/12] fixes a compile warning reported by kbuild test robot. > > [patch 2/12] fixes HNS3_RXD_GRO_SIZE_M macro definition error. > > [patch 3/12] adds a debugfs command to dump firmware information. > > [patch 4/12 - 10/12] adds some code optimizaions and cleanups for > reset and driver unloading. > > [patch 11/12 - 12/12] adds two bugfixes. Series applied, thanks.
[PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver
This patch-set includes code optimizations and bugfixes for the HNS3 ethernet controller driver. [patch 1/12] fixes a compile warning reported by kbuild test robot. [patch 2/12] fixes HNS3_RXD_GRO_SIZE_M macro definition error. [patch 3/12] adds a debugfs command to dump firmware information. [patch 4/12 - 10/12] adds some code optimizaions and cleanups for reset and driver unloading. [patch 11/12 - 12/12] adds two bugfixes. Huazhong Tan (9): net: hns3: use HCLGE_STATE_NIC_REGISTERED to indicate PF NIC client has registered net: hns3: use HCLGE_STATE_ROCE_REGISTERED to indicate PF ROCE client has registered net: hns3: use HCLGEVF_STATE_NIC_REGISTERED to indicate VF NIC client has registered net: hns3: modify hclge_init_client_instance() net: hns3: modify hclgevf_init_client_instance() net: hns3: add handshake with hardware while doing reset net: hns3: stop schedule reset service while unloading driver net: hns3: adjust hns3_uninit_phy()'s location in the hns3_client_uninit() net: hns3: fix a memory leak issue for hclge_map_unmap_ring_to_vf_vector Jian Shen (1): net: hns3: fix compile warning without CONFIG_RFS_ACCEL Yunsheng Lin (1): net: hns3: fix for HNS3_RXD_GRO_SIZE_M macro Zhongzhu Liu (1): net: hns3: add support for dump firmware statistics by debugfs drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 1 + drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 4 +- drivers/net/ethernet/hisilicon/hns3/hns3_enet.h| 2 +- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c | 6 +- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 8 ++ .../ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c | 57 +++ .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 110 ++--- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.h| 2 + .../net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 4 +- .../ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c | 2 - .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 95 -- .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h | 2 + 12 files changed, 213 insertions(+), 80 deletions(-) -- 2.7.4
Re: [PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver
Sorry, please ignore this patchset. I will send V2 to fix something else. On 2019/4/24 11:21, Huazhong Tan wrote: This patch-set includes code optimizations and bugfixes for the HNS3 ethernet controller driver. [patch 1/12 - 3/12] fixes some bugs about the IO path [patch 4/12 - 6/12] includes some optimization and bugfixes about mailbox message handling [patch 7/12 - 12/12] adds misc code optimizations and bugfixes. Huazhong Tan (7): net: hns3: stop sending keep alive msg when VF command queue needs reinit net: hns3: use atomic_t replace u32 for arq's count net: hns3: use a reserved byte to identify need_resp flag net: hns3: not reset TQP in the DOWN while VF resetting net: hns3: stop schedule reset service while unloading driver net: hns3: fix pause configure fail problem net: hns3: prevent double free in hns3_put_ring_config() Weihang Li (1): net: hns3: remove reset after command send failed Yunsheng Lin (3): net: hns3: fix data race between ring->next_to_clean net: hns3: fix for TX clean num when cleaning TX BD net: hns3: handle the BD info on the last BD of the packet liuzhongzhu (1): net: hns3: extend the loopback state acquisition time drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h| 7 ++- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 65 +- drivers/net/ethernet/hisilicon/hns3/hns3_enet.h| 7 ++- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 10 .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 8 ++- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 7 +-- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 5 +- .../ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c | 2 +- .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 12 ++-- .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h | 1 + .../ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c | 9 ++- 11 files changed, 76 insertions(+), 57 deletions(-)
Re: [Patch net-next 00/12] code optimizations & bugfixes for HNS3 driver
From: Huazhong Tan Date: Sat, 23 Feb 2019 17:22:07 +0800 > This patchset includes bugfixes and code optimizations for > the HNS3 ethernet controller driver. Series applied, thanks.
[Patch net-next 00/12] code optimizations & bugfixes for HNS3 driver
This patchset includes bugfixes and code optimizations for the HNS3 ethernet controller driver. Huazhong Tan (1): net: hns3: fix improper error handling for hns3_client_start Jian Shen (2): net: hns3: enable VF VLAN filter for each VF when initializing net: hns3: fix get VF RSS issue Peng Li (1): net: hns3: add support to config depth for tx|rx ring separately Shiju Jose (1): net: hns3: fix setting of the hns reset_type for rdma hw errors Yunsheng Lin (7): net: hns3: add xps setting support for hns3 driver net: hns3: avoid mult + div op in critical data path net: hns3: limit some variable scope in critical data path net: hns3: remove some ops in struct hns3_nic_ops net: hns3: add unlikely for error handling in data path net: hns3: replace hnae3_set_bit and hnae3_set_field in data path net: hns3: remove hnae3_get_bit in data path drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h| 1 + drivers/net/ethernet/hisilicon/hns3/hnae3.h| 10 +- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 264 +++-- drivers/net/ethernet/hisilicon/hns3/hns3_enet.h| 8 +- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 54 +++-- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 4 +- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 36 +-- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 52 ++-- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.h| 3 +- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 53 - .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 89 ++- .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h | 3 +- 12 files changed, 369 insertions(+), 208 deletions(-) -- 2.7.4
Re: [Patch net-next 00/12] code optimizations & bugfixes for HNS3 driver
From: Huazhong Tan Date: Wed, 20 Feb 2019 10:32:39 +0800 > This patchset includes bugfixes and code optimizations for > the HNS3 ethernet controller driver. Series applied, thank you.
[Patch net-next 00/12] code optimizations & bugfixes for HNS3 driver
This patchset includes bugfixes and code optimizations for the HNS3 ethernet controller driver. Huazhong Tan (2): net: hns3: uninitialize command queue while unloading PF driver net: hns3: clear command queue's registers when unloading VF driver Jian Shen (2): net: hns3: convert mac advertize and supported from u32 to link mode net: hns3: fix port info query issue for copper port Weihang Li (4): net: hns3: modify print message of ssu common ecc errors net: hns3: some bugfix of ppu(rcb) ras errors net: hns3: enable 8~11th bit of mac common msi-x error net: hns3: fix 6th bit of ppp mpf abnormal errors Yonglong Liu (2): net: hns3: add pointer checking at the beginning of the exported functions. net: hns3: Check variable is valid before assigning it to another liuzhongzhu (2): net: hns3: Record VF unicast and multicast tables net: hns3: Record VF vlan tables drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h| 2 + drivers/net/ethernet/hisilicon/hns3/hnae3.c| 37 ++- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 9 +- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c | 26 +++ .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 2 +- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 69 +- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_err.h | 5 +- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 248 +++-- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.h| 40 .../net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 32 ++- .../ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c| 17 +- .../ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c | 20 ++ 12 files changed, 451 insertions(+), 56 deletions(-) -- 2.7.4
Re: [PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver
From: Huazhong Tan Date: Sat, 2 Feb 2019 22:39:25 +0800 > This patchset includes bugfixes and code optimizations for the HNS3 > ethernet controller driver Series applied.
[PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver
This patchset includes bugfixes and code optimizations for the HNS3 ethernet controller driver Huazhong Tan (1): net: hns3: fix a wrong checking in the hclge_tx_buffer_calc() Jian Shen (1): net: hns3: don't allow user to change vlan filter state Peng Li (2): net: hns3: fix a code style issue for hns3_update_new_int_gl() net: hns3: fix an issue for hns3_update_new_int_gl Weihang Li (2): net: hns3: add hclge_cmd_check_retval() to parse comman's return value net: hns3: move some set_bit statement into hclge_prepare_mac_addr Yonglong Liu (1): net: hns3: Modify parameter type from int to bool in set_gro_en Yunsheng Lin (1): net: hns3: code optimization for hclge_rx_buffer_calc liuzhongzhu (4): net: hns3: fix the problem that the supported port is empty net: hns3: optimize the maximum TC macro net: hns3: modify the upper limit judgment condition net: hns3: MAC table entry count function increases operation 0 value protection measures .../net/ethernet/hisilicon/hns3/hclge_mbx.h | 4 +- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 2 +- .../net/ethernet/hisilicon/hns3/hns3_enet.c | 33 ++-- .../hisilicon/hns3/hns3pf/hclge_cmd.c | 62 +++--- .../hisilicon/hns3/hns3pf/hclge_cmd.h | 7 +- .../hisilicon/hns3/hns3pf/hclge_debugfs.c | 4 +- .../hisilicon/hns3/hns3pf/hclge_main.c| 184 -- .../hisilicon/hns3/hns3pf/hclge_mbx.c | 31 ++- .../hisilicon/hns3/hns3vf/hclgevf_main.c | 34 +++- .../hisilicon/hns3/hns3vf/hclgevf_main.h | 2 + .../hisilicon/hns3/hns3vf/hclgevf_mbx.c | 12 ++ 11 files changed, 216 insertions(+), 159 deletions(-) -- 2.20.1
Re: [PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver
From: Huazhong Tan Date: Thu, 31 Jan 2019 04:55:40 +0800 > This patchset includes bugfixes and code optimizations for the HNS3 > ethernet controller driver Series applied, thanks.
[PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver
This patchset includes bugfixes and code optimizations for the HNS3 ethernet controller driver Huazhong Tan (4): net: hns3: change hnae3_register_ae_dev() to int net: hns3: Fix NULL deref when unloading driver net: hns3: fix netif_napi_del() not do problem when unloading net: hns3: fix improper error handling in the hclge_init_ae_dev() Jian Shen (4): net: hns3: fix VF dump register issue net: hns3: fix for rss result nonuniform net: hns3: stop sending keep alive msg to PF when VF is resetting net: hns3: keep flow director state unchanged when reset Peng Li (2): net: hns3: use the correct interface to stop|open port net: hns3: fix an issue for hclgevf_ae_get_hdev Yunsheng Lin (1): net: hns3: only support tc 0 for VF liyongxin (1): net: hns3: reuse the definition of l3 and l4 header info union drivers/net/ethernet/hisilicon/hns3/hnae3.c | 10 +- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 4 +- .../net/ethernet/hisilicon/hns3/hns3_enet.c | 95 +-- .../net/ethernet/hisilicon/hns3/hns3_enet.h | 1 + .../ethernet/hisilicon/hns3/hns3_ethtool.c| 6 +- .../hisilicon/hns3/hns3pf/hclge_dcb.c | 12 +-- .../hisilicon/hns3/hns3pf/hclge_main.c| 50 +- .../hisilicon/hns3/hns3pf/hclge_main.h| 2 +- .../hisilicon/hns3/hns3pf/hclge_mbx.c | 10 +- .../hisilicon/hns3/hns3pf/hclge_mdio.c| 8 +- .../hisilicon/hns3/hns3pf/hclge_mdio.h| 4 +- .../ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 22 +++-- .../hisilicon/hns3/hns3vf/hclgevf_main.c | 25 - 13 files changed, 145 insertions(+), 104 deletions(-) -- 2.20.1
Re: [PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver
From: Huazhong Tan Date: Sun, 27 Jan 2019 00:49:09 +0800 > This patchset includes bugfixes and code optimizations for the HNS3 > ethernet controller driver Series applied, thanks.
[PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver
This patchset includes bugfixes and code optimizations for the HNS3 ethernet controller driver Jian Shen (6): net: hns3: don't update packet statistics for packets dropped by hardware net: hns3: clear pci private data when unload hns3 driver net: hns3: fix return value handle issue for hclge_set_loopback() net: hns3: fix broadcast promisc issue for revision 0x20 net: hns3: add initialization for nic state net: hns3: don't allow vf to enable promisc mode Peng Li (1): net: hns3: add 8 BD limit for tx flow Yunsheng Lin (4): net: hns3: add error handling in hclge_ieee_setets net: hns3: do reinitialization while mqprio configuration changed net: hns3: remove dcb_ops->map_update in hclge_dcb net: hns3: call hns3_nic_set_real_num_queue with netdev down liuzhongzhu (1): net: hns3: After setting the loopback, add the status of getting MAC drivers/net/ethernet/hisilicon/hns3/hnae3.h | 1 - .../net/ethernet/hisilicon/hns3/hns3_enet.c | 72 +-- .../ethernet/hisilicon/hns3/hns3_ethtool.c| 8 +-- .../hisilicon/hns3/hns3pf/hclge_dcb.c | 51 ++--- .../hisilicon/hns3/hns3pf/hclge_main.c| 36 +- .../hisilicon/hns3/hns3pf/hclge_mbx.c | 7 +- .../hisilicon/hns3/hns3vf/hclgevf_main.c | 32 + 7 files changed, 138 insertions(+), 69 deletions(-) -- 2.20.1
[PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver
This patchset includes bugfixes and code optimizations for the HNS3 ethernet controller driver Huazhong Tan (1): net: hns3: fix bug of ethtool_ops.get_channels for VF Jian Shen (2): net: hns3: add rx multicast packets statistic net: hns3: refactor the statistics updating for netdev Peng Li (2): net: hns3: add calling roce callback function when link status change net: hns3: clear param in ring when free ring Yunsheng Lin (6): net: hns3: fix rss configuration lost problem when setting channel net: hns3: fix for shaper not setting when TC num changes net: hns3: Change fw error code NOT_EXEC to NOT_SUPPORTED net: hns3: do not return GE PFC setting err when initializing net: hns3: add ETS TC weight setting in SSU module net: hns3: fix PFC not setting problem for DCB module liuzhongzhu (1): net: hns3: add statistics for PFC frames and MAC control frames drivers/net/ethernet/hisilicon/hns3/hnae3.h | 3 +- .../net/ethernet/hisilicon/hns3/hns3_enet.c | 47 -- .../net/ethernet/hisilicon/hns3/hns3_enet.h | 8 + .../ethernet/hisilicon/hns3/hns3_ethtool.c| 1 + .../hisilicon/hns3/hns3pf/hclge_cmd.c | 12 +- .../hisilicon/hns3/hns3pf/hclge_cmd.h | 4 +- .../hisilicon/hns3/hns3pf/hclge_dcb.c | 19 +-- .../hisilicon/hns3/hns3pf/hclge_main.c| 138 ++ .../hisilicon/hns3/hns3pf/hclge_main.h| 8 + .../ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 70 +++-- .../ethernet/hisilicon/hns3/hns3pf/hclge_tm.h | 7 +- .../hisilicon/hns3/hns3vf/hclgevf_main.c | 10 +- 12 files changed, 254 insertions(+), 73 deletions(-) -- 2.20.1
