Re: [PATCH net-next 09/16] net: dsa: use ports list to find first CPU port

[Florian Fainelli]

On 10/19/2019 8:19 PM, Vivien Didelot wrote:
> Use the new ports list instead of iterating over switches and their
> ports when looking up the first CPU port in the tree.
> 
> Signed-off-by: Vivien Didelot 

Reviewed-by: Florian Fainelli 
-- 
Florian

[PATCH net-next 09/16] net: dsa: use ports list to find first CPU port

[Vivien Didelot]

Use the new ports list instead of iterating over switches and their
ports when looking up the first CPU port in the tree.

Signed-off-by: Vivien Didelot 
---
 net/dsa/dsa2.c | 17 +++--
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
index 3b8de155bc0b..99f5dab06787 100644
--- a/net/dsa/dsa2.c
+++ b/net/dsa/dsa2.c
@@ -186,22 +186,11 @@ static bool dsa_tree_setup_routing_table(struct 
dsa_switch_tree *dst)
 
 static struct dsa_port *dsa_tree_find_first_cpu(struct dsa_switch_tree *dst)
 {
-   struct dsa_switch *ds;
struct dsa_port *dp;
-   int device, port;
-
-   for (device = 0; device < DSA_MAX_SWITCHES; device++) {
-   ds = dst->ds[device];
-   if (!ds)
-   continue;
 
-   for (port = 0; port < ds->num_ports; port++) {
-   dp = >ports[port];
-
-   if (dsa_port_is_cpu(dp))
-   return dp;
-   }
-   }
+   list_for_each_entry(dp, >ports, list)
+   if (dsa_port_is_cpu(dp))
+   return dp;
 
return NULL;
 }
-- 
2.23.0