Re: [PATCH net-next 1/3] net: ipa: fix a duplicated tlv_type value

[Manivannan Sadhasivam]

On Mon, Mar 15, 2021 at 10:21:10AM -0500, Alex Elder wrote:
> In the ipa_indication_register_req_ei[] encoding array, the tlv_type
> associated with the ipa_mhi_ready_ind field is wrong.  It duplicates
> the value used for the data_usage_quota_reached field (0x11) and
> should use value 0x12 instead.  Fix this bug.
> 
> Reported-by: Manivannan Sadhasivam 
> Signed-off-by: Alex Elder 

Acked-by: Manivannan Sadhasivam 

Thanks,
Mani

> ---
>  drivers/net/ipa/ipa_qmi_msg.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ipa/ipa_qmi_msg.c b/drivers/net/ipa/ipa_qmi_msg.c
> index 73413371e3d3e..e00f829a783f6 100644
> --- a/drivers/net/ipa/ipa_qmi_msg.c
> +++ b/drivers/net/ipa/ipa_qmi_msg.c
> @@ -56,7 +56,7 @@ struct qmi_elem_info ipa_indication_register_req_ei[] = {
>   .elem_size  =
>   sizeof_field(struct ipa_indication_register_req,
>ipa_mhi_ready_ind_valid),
> - .tlv_type   = 0x11,
> + .tlv_type   = 0x12,
>   .offset = offsetof(struct ipa_indication_register_req,
>  ipa_mhi_ready_ind_valid),
>   },
> @@ -66,7 +66,7 @@ struct qmi_elem_info ipa_indication_register_req_ei[] = {
>   .elem_size  =
>   sizeof_field(struct ipa_indication_register_req,
>ipa_mhi_ready_ind),
> - .tlv_type   = 0x11,
> + .tlv_type   = 0x12,
>   .offset = offsetof(struct ipa_indication_register_req,
>  ipa_mhi_ready_ind),
>   },
> -- 
> 2.27.0
> 

[PATCH net-next 1/3] net: ipa: fix a duplicated tlv_type value

[Alex Elder]

In the ipa_indication_register_req_ei[] encoding array, the tlv_type
associated with the ipa_mhi_ready_ind field is wrong.  It duplicates
the value used for the data_usage_quota_reached field (0x11) and
should use value 0x12 instead.  Fix this bug.

Reported-by: Manivannan Sadhasivam 
Signed-off-by: Alex Elder 
---
 drivers/net/ipa/ipa_qmi_msg.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ipa/ipa_qmi_msg.c b/drivers/net/ipa/ipa_qmi_msg.c
index 73413371e3d3e..e00f829a783f6 100644
--- a/drivers/net/ipa/ipa_qmi_msg.c
+++ b/drivers/net/ipa/ipa_qmi_msg.c
@@ -56,7 +56,7 @@ struct qmi_elem_info ipa_indication_register_req_ei[] = {
.elem_size  =
sizeof_field(struct ipa_indication_register_req,
 ipa_mhi_ready_ind_valid),
-   .tlv_type   = 0x11,
+   .tlv_type   = 0x12,
.offset = offsetof(struct ipa_indication_register_req,
   ipa_mhi_ready_ind_valid),
},
@@ -66,7 +66,7 @@ struct qmi_elem_info ipa_indication_register_req_ei[] = {
.elem_size  =
sizeof_field(struct ipa_indication_register_req,
 ipa_mhi_ready_ind),
-   .tlv_type   = 0x11,
+   .tlv_type   = 0x12,
.offset = offsetof(struct ipa_indication_register_req,
   ipa_mhi_ready_ind),
},
-- 
2.27.0