Re: [PATCH net-next 1/4] net: phy: broadcom: add exp register access methods without buslock

[Andrew Lunn]

On Sun, May 10, 2020 at 12:37:11AM +0200, Michael Walle wrote:
> Add helper to read and write expansion registers without taking the mdio
> lock.
> 
> Please note, that this changes the semantics of the read and write.
> Before there was no lock between selecting the expansion register and
> the actual read/write. This may lead to access failures if there are
> parallel accesses. Instead take the bus lock during the whole access
> cycle.
> 
> Signed-off-by: Michael Walle 

Reviewed-by: Andrew Lunn 

Andrew

Re: [PATCH net-next 1/4] net: phy: broadcom: add exp register access methods without buslock

[Florian Fainelli]

On 5/9/2020 3:37 PM, Michael Walle wrote:
> Add helper to read and write expansion registers without taking the mdio
> lock.
> 
> Please note, that this changes the semantics of the read and write.
> Before there was no lock between selecting the expansion register and
> the actual read/write. This may lead to access failures if there are
> parallel accesses. Instead take the bus lock during the whole access
> cycle.
> 
> Signed-off-by: Michael Walle 

Reviewed-by: Florian Fainelli 
-- 
Florian

[PATCH net-next 1/4] net: phy: broadcom: add exp register access methods without buslock

[Michael Walle]

Add helper to read and write expansion registers without taking the mdio
lock.

Please note, that this changes the semantics of the read and write.
Before there was no lock between selecting the expansion register and
the actual read/write. This may lead to access failures if there are
parallel accesses. Instead take the bus lock during the whole access
cycle.

Signed-off-by: Michael Walle 
---
 drivers/net/phy/bcm-phy-lib.c | 38 ---
 drivers/net/phy/bcm-phy-lib.h |  2 ++
 2 files changed, 33 insertions(+), 7 deletions(-)

diff --git a/drivers/net/phy/bcm-phy-lib.c b/drivers/net/phy/bcm-phy-lib.c
index d5f9a2701989..a390812714ed 100644
--- a/drivers/net/phy/bcm-phy-lib.c
+++ b/drivers/net/phy/bcm-phy-lib.c
@@ -14,33 +14,57 @@
 #define MII_BCM_CHANNEL_WIDTH 0x2000
 #define BCM_CL45VEN_EEE_ADV   0x3c
 
-int bcm_phy_write_exp(struct phy_device *phydev, u16 reg, u16 val)
+int __bcm_phy_write_exp(struct phy_device *phydev, u16 reg, u16 val)
 {
int rc;
 
-   rc = phy_write(phydev, MII_BCM54XX_EXP_SEL, reg);
+   rc = __phy_write(phydev, MII_BCM54XX_EXP_SEL, reg);
if (rc < 0)
return rc;
 
-   return phy_write(phydev, MII_BCM54XX_EXP_DATA, val);
+   return __phy_write(phydev, MII_BCM54XX_EXP_DATA, val);
+}
+EXPORT_SYMBOL_GPL(__bcm_phy_write_exp);
+
+int bcm_phy_write_exp(struct phy_device *phydev, u16 reg, u16 val)
+{
+   int rc;
+
+   phy_lock_mdio_bus(phydev);
+   rc = __bcm_phy_write_exp(phydev, reg, val);
+   phy_unlock_mdio_bus(phydev);
+
+   return rc;
 }
 EXPORT_SYMBOL_GPL(bcm_phy_write_exp);
 
-int bcm_phy_read_exp(struct phy_device *phydev, u16 reg)
+int __bcm_phy_read_exp(struct phy_device *phydev, u16 reg)
 {
int val;
 
-   val = phy_write(phydev, MII_BCM54XX_EXP_SEL, reg);
+   val = __phy_write(phydev, MII_BCM54XX_EXP_SEL, reg);
if (val < 0)
return val;
 
-   val = phy_read(phydev, MII_BCM54XX_EXP_DATA);
+   val = __phy_read(phydev, MII_BCM54XX_EXP_DATA);
 
/* Restore default value.  It's O.K. if this write fails. */
-   phy_write(phydev, MII_BCM54XX_EXP_SEL, 0);
+   __phy_write(phydev, MII_BCM54XX_EXP_SEL, 0);
 
return val;
 }
+EXPORT_SYMBOL_GPL(__bcm_phy_read_exp);
+
+int bcm_phy_read_exp(struct phy_device *phydev, u16 reg)
+{
+   int rc;
+
+   phy_lock_mdio_bus(phydev);
+   rc = __bcm_phy_read_exp(phydev, reg);
+   phy_unlock_mdio_bus(phydev);
+
+   return rc;
+}
 EXPORT_SYMBOL_GPL(bcm_phy_read_exp);
 
 int bcm54xx_auxctl_read(struct phy_device *phydev, u16 regnum)
diff --git a/drivers/net/phy/bcm-phy-lib.h b/drivers/net/phy/bcm-phy-lib.h
index 4d3de91cda6c..0eb5333cda39 100644
--- a/drivers/net/phy/bcm-phy-lib.h
+++ b/drivers/net/phy/bcm-phy-lib.h
@@ -27,6 +27,8 @@
 #define AFE_HPF_TRIM_OTHERSMISC_ADDR(0x3a, 0)
 
 
+int __bcm_phy_write_exp(struct phy_device *phydev, u16 reg, u16 val);
+int __bcm_phy_read_exp(struct phy_device *phydev, u16 reg);
 int bcm_phy_write_exp(struct phy_device *phydev, u16 reg, u16 val);
 int bcm_phy_read_exp(struct phy_device *phydev, u16 reg);
 
-- 
2.20.1