Re: [PATCH net-next 13/16] net: dsa: mv88e6xxx: use ports list to map bridge

[Florian Fainelli]

On 10/19/2019 8:19 PM, Vivien Didelot wrote:
> Instead of digging into the other dsa_switch structures of the fabric
> and relying too much on the dsa_to_port helper, use the new list
> of switch fabric ports to remap the Port VLAN Map of local bridge
> group members or remap the Port VLAN Table entry of external bridge
> group members.
> 
> Signed-off-by: Vivien Didelot 
> ---

[snip]

> - for (port = 0; port < ds->num_ports; ++port) {
> - if (dsa_to_port(ds, port)->bridge_dev == br) {
> - err = mv88e6xxx_pvt_map(chip, dev, port);
> + list_for_each_entry(dp, &dst->ports, list) {
> + /* Remap the Port VLAN Map of local bridge group members and
> +  * remap the PVT entry of external bridge group members.
> +  */

If you do a v2, I would tend to put these comments under the appropriate
branches taken below for clarify although the code is actually clearer
this want than it was before IMHO, so up to you :)

Reviewed-by: Florian Fainelli 
-- 
Florian

[PATCH net-next 13/16] net: dsa: mv88e6xxx: use ports list to map bridge

[Vivien Didelot]

Instead of digging into the other dsa_switch structures of the fabric
and relying too much on the dsa_to_port helper, use the new list
of switch fabric ports to remap the Port VLAN Map of local bridge
group members or remap the Port VLAN Table entry of external bridge
group members.

Signed-off-by: Vivien Didelot 
---
 drivers/net/dsa/mv88e6xxx/chip.c | 36 +---
 1 file changed, 15 insertions(+), 21 deletions(-)

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index af8943142053..8771f2525932 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -2043,29 +2043,23 @@ static int mv88e6xxx_port_fdb_dump(struct dsa_switch 
*ds, int port,
 static int mv88e6xxx_bridge_map(struct mv88e6xxx_chip *chip,
struct net_device *br)
 {
-   struct dsa_switch *ds;
-   int port;
-   int dev;
+   struct dsa_switch *ds = chip->ds;
+   struct dsa_switch_tree *dst = ds->dst;
+   struct dsa_port *dp;
int err;
 
-   /* Remap the Port VLAN of each local bridge group member */
-   for (port = 0; port < mv88e6xxx_num_ports(chip); ++port) {
-   if (dsa_to_port(chip->ds, port)->bridge_dev == br) {
-   err = mv88e6xxx_port_vlan_map(chip, port);
-   if (err)
-   return err;
-   }
-   }
-
-   /* Remap the Port VLAN of each cross-chip bridge group member */
-   for (dev = 0; dev < DSA_MAX_SWITCHES; ++dev) {
-   ds = chip->ds->dst->ds[dev];
-   if (!ds)
-   break;
-
-   for (port = 0; port < ds->num_ports; ++port) {
-   if (dsa_to_port(ds, port)->bridge_dev == br) {
-   err = mv88e6xxx_pvt_map(chip, dev, port);
+   list_for_each_entry(dp, &dst->ports, list) {
+   /* Remap the Port VLAN Map of local bridge group members and
+* remap the PVT entry of external bridge group members.
+*/
+   if (dp->bridge_dev == br) {
+   if (dp->ds == ds) {
+   err = mv88e6xxx_port_vlan_map(chip, dp->index);
+   if (err)
+   return err;
+   } else {
+   err = mv88e6xxx_pvt_map(chip, dp->ds->index,
+   dp->index);
if (err)
return err;
}
-- 
2.23.0