Re: [Linux-zigbee-devel] [PATCH net-next v2] 6lowpan: mac802154: fix coding style issues
On Fri, Jun 27, 2014 at 09:37:25AM +0530, Varka Bhadram wrote:
> This patch fixed the coding style issues reported by checkpatch.pl
>
> following issues fixed:
> CHECK: Alignment should match open parenthesis
> WARNING: line over 80 characters
> CHECK: Blank lines aren't necessary before a close brace '}'
> WARNING: networking block comments don't use an empty /* line, use /*
> Comment...
> WARNING: Missing a blank line after declarations
> WARNING: networking block comments start with * on subsequent lines
> CHECK: braces {} should be used on all arms of this statement
>
> Signed-off-by: Varka Bhadram
Tested-by: Alexander Aring
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [Linux-zigbee-devel] [PATCH net-next v2] 6lowpan: mac802154: fix coding style issues
On Fri, Jun 27, 2014 at 09:37:25AM +0530, Varka Bhadram wrote:
This patch fixed the coding style issues reported by checkpatch.pl
following issues fixed:
CHECK: Alignment should match open parenthesis
WARNING: line over 80 characters
CHECK: Blank lines aren't necessary before a close brace '}'
WARNING: networking block comments don't use an empty /* line, use /*
Comment...
WARNING: Missing a blank line after declarations
WARNING: networking block comments start with * on subsequent lines
CHECK: braces {} should be used on all arms of this statement
Signed-off-by: Varka Bhadram var...@cdac.in
Tested-by: Alexander Aring alex.ar...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH net-next v2] 6lowpan: mac802154: fix coding style issues
This patch fixed the coding style issues reported by checkpatch.pl
following issues fixed:
CHECK: Alignment should match open parenthesis
WARNING: line over 80 characters
CHECK: Blank lines aren't necessary before a close brace '}'
WARNING: networking block comments don't use an empty /* line, use /*
Comment...
WARNING: Missing a blank line after declarations
WARNING: networking block comments start with * on subsequent lines
CHECK: braces {} should be used on all arms of this statement
Signed-off-by: Varka Bhadram
---
net/ieee802154/6lowpan_iphc.c | 113 ++--
net/ieee802154/6lowpan_rtnl.c | 16 +++---
net/ieee802154/af_ieee802154.c | 26 +
net/ieee802154/dgram.c | 28 +-
net/ieee802154/ieee802154.h|2 +-
net/ieee802154/netlink.c |4 +-
net/ieee802154/nl-mac.c| 48 +
net/ieee802154/nl-phy.c| 23
net/ieee802154/raw.c | 14 +++--
net/ieee802154/reassembly.c|1 +
net/ieee802154/wpan-class.c| 10 ++--
net/mac802154/ieee802154_dev.c |4 +-
net/mac802154/llsec.c |1 +
net/mac802154/mib.c|7 +--
net/mac802154/tx.c |1 +
15 files changed, 153 insertions(+), 145 deletions(-)
diff --git a/net/ieee802154/6lowpan_iphc.c b/net/ieee802154/6lowpan_iphc.c
index 211b568..511ddee 100644
--- a/net/ieee802154/6lowpan_iphc.c
+++ b/net/ieee802154/6lowpan_iphc.c
@@ -3,8 +3,7 @@
* written by Alexander Smirnov
*/
-/*
- * Based on patches from Jon Smirl
+/* Based on patches from Jon Smirl
* Copyright (c) 2011 Jon Smirl
*
* This program is free software; you can redistribute it and/or modify
@@ -58,16 +57,15 @@
#include
#include
-/*
- * Uncompress address function for source and
+/* Uncompress address function for source and
* destination address(non-multicast).
*
* address_mode is sam value or dam value.
*/
static int uncompress_addr(struct sk_buff *skb,
- struct in6_addr *ipaddr, const u8 address_mode,
- const u8 *lladdr, const u8 addr_type,
- const u8 addr_len)
+ struct in6_addr *ipaddr, const u8 address_mode,
+ const u8 *lladdr, const u8 addr_type,
+ const u8 addr_len)
{
bool fail;
@@ -140,13 +138,12 @@ static int uncompress_addr(struct sk_buff *skb,
return 0;
}
-/*
- * Uncompress address function for source context
+/* Uncompress address function for source context
* based address(non-multicast).
*/
static int uncompress_context_based_src_addr(struct sk_buff *skb,
- struct in6_addr *ipaddr,
- const u8 sam)
+struct in6_addr *ipaddr,
+const u8 sam)
{
switch (sam) {
case LOWPAN_IPHC_ADDR_00:
@@ -175,13 +172,13 @@ static int uncompress_context_based_src_addr(struct
sk_buff *skb,
}
static int skb_deliver(struct sk_buff *skb, struct ipv6hdr *hdr,
- struct net_device *dev, skb_delivery_cb deliver_skb)
+ struct net_device *dev, skb_delivery_cb deliver_skb)
{
struct sk_buff *new;
int stat;
- new = skb_copy_expand(skb, sizeof(struct ipv6hdr), skb_tailroom(skb),
- GFP_ATOMIC);
+ new = skb_copy_expand(skb, sizeof(struct ipv6hdr),
+ skb_tailroom(skb), GFP_ATOMIC);
kfree_skb(skb);
if (!new)
@@ -196,7 +193,7 @@ static int skb_deliver(struct sk_buff *skb, struct ipv6hdr
*hdr,
new->dev = dev;
raw_dump_table(__func__, "raw skb data dump before receiving",
- new->data, new->len);
+ new->data, new->len);
stat = deliver_skb(new, dev);
@@ -210,8 +207,8 @@ static int skb_deliver(struct sk_buff *skb, struct ipv6hdr
*hdr,
*/
static int
lowpan_uncompress_multicast_daddr(struct sk_buff *skb,
- struct in6_addr *ipaddr,
- const u8 dam)
+ struct in6_addr *ipaddr,
+ const u8 dam)
{
bool fail;
@@ -314,8 +311,7 @@ uncompress_udp_header(struct sk_buff *skb, struct udphdr
*uh)
fail |= lowpan_fetch_skb(skb, >check, 2);
}
- /*
-* UDP lenght needs to be infered from the lower layers
+ /* UDP lenght needs to be infered from the lower layers
* here, we obtain the hint from the remaining size of the
* frame
*/
@@ -338,16 +334,17 @@ err:
static const u8 lowpan_ttl_values[] = { 0, 1, 64, 255 };
int
[PATCH net-next v2] 6lowpan: mac802154: fix coding style issues
This patch fixed the coding style issues reported by checkpatch.pl
following issues fixed:
CHECK: Alignment should match open parenthesis
WARNING: line over 80 characters
CHECK: Blank lines aren't necessary before a close brace '}'
WARNING: networking block comments don't use an empty /* line, use /*
Comment...
WARNING: Missing a blank line after declarations
WARNING: networking block comments start with * on subsequent lines
CHECK: braces {} should be used on all arms of this statement
Signed-off-by: Varka Bhadram var...@cdac.in
---
net/ieee802154/6lowpan_iphc.c | 113 ++--
net/ieee802154/6lowpan_rtnl.c | 16 +++---
net/ieee802154/af_ieee802154.c | 26 +
net/ieee802154/dgram.c | 28 +-
net/ieee802154/ieee802154.h|2 +-
net/ieee802154/netlink.c |4 +-
net/ieee802154/nl-mac.c| 48 +
net/ieee802154/nl-phy.c| 23
net/ieee802154/raw.c | 14 +++--
net/ieee802154/reassembly.c|1 +
net/ieee802154/wpan-class.c| 10 ++--
net/mac802154/ieee802154_dev.c |4 +-
net/mac802154/llsec.c |1 +
net/mac802154/mib.c|7 +--
net/mac802154/tx.c |1 +
15 files changed, 153 insertions(+), 145 deletions(-)
diff --git a/net/ieee802154/6lowpan_iphc.c b/net/ieee802154/6lowpan_iphc.c
index 211b568..511ddee 100644
--- a/net/ieee802154/6lowpan_iphc.c
+++ b/net/ieee802154/6lowpan_iphc.c
@@ -3,8 +3,7 @@
* written by Alexander Smirnov alex.bluesman.smir...@gmail.com
*/
-/*
- * Based on patches from Jon Smirl jonsm...@gmail.com
+/* Based on patches from Jon Smirl jonsm...@gmail.com
* Copyright (c) 2011 Jon Smirl jonsm...@gmail.com
*
* This program is free software; you can redistribute it and/or modify
@@ -58,16 +57,15 @@
#include net/ipv6.h
#include net/af_ieee802154.h
-/*
- * Uncompress address function for source and
+/* Uncompress address function for source and
* destination address(non-multicast).
*
* address_mode is sam value or dam value.
*/
static int uncompress_addr(struct sk_buff *skb,
- struct in6_addr *ipaddr, const u8 address_mode,
- const u8 *lladdr, const u8 addr_type,
- const u8 addr_len)
+ struct in6_addr *ipaddr, const u8 address_mode,
+ const u8 *lladdr, const u8 addr_type,
+ const u8 addr_len)
{
bool fail;
@@ -140,13 +138,12 @@ static int uncompress_addr(struct sk_buff *skb,
return 0;
}
-/*
- * Uncompress address function for source context
+/* Uncompress address function for source context
* based address(non-multicast).
*/
static int uncompress_context_based_src_addr(struct sk_buff *skb,
- struct in6_addr *ipaddr,
- const u8 sam)
+struct in6_addr *ipaddr,
+const u8 sam)
{
switch (sam) {
case LOWPAN_IPHC_ADDR_00:
@@ -175,13 +172,13 @@ static int uncompress_context_based_src_addr(struct
sk_buff *skb,
}
static int skb_deliver(struct sk_buff *skb, struct ipv6hdr *hdr,
- struct net_device *dev, skb_delivery_cb deliver_skb)
+ struct net_device *dev, skb_delivery_cb deliver_skb)
{
struct sk_buff *new;
int stat;
- new = skb_copy_expand(skb, sizeof(struct ipv6hdr), skb_tailroom(skb),
- GFP_ATOMIC);
+ new = skb_copy_expand(skb, sizeof(struct ipv6hdr),
+ skb_tailroom(skb), GFP_ATOMIC);
kfree_skb(skb);
if (!new)
@@ -196,7 +193,7 @@ static int skb_deliver(struct sk_buff *skb, struct ipv6hdr
*hdr,
new-dev = dev;
raw_dump_table(__func__, raw skb data dump before receiving,
- new-data, new-len);
+ new-data, new-len);
stat = deliver_skb(new, dev);
@@ -210,8 +207,8 @@ static int skb_deliver(struct sk_buff *skb, struct ipv6hdr
*hdr,
*/
static int
lowpan_uncompress_multicast_daddr(struct sk_buff *skb,
- struct in6_addr *ipaddr,
- const u8 dam)
+ struct in6_addr *ipaddr,
+ const u8 dam)
{
bool fail;
@@ -314,8 +311,7 @@ uncompress_udp_header(struct sk_buff *skb, struct udphdr
*uh)
fail |= lowpan_fetch_skb(skb, uh-check, 2);
}
- /*
-* UDP lenght needs to be infered from the lower layers
+ /* UDP lenght needs to be infered from the lower layers
* here, we obtain the hint from the remaining size of the
