Re: [PATCH net-next v2 07/20] net: ixgbe: slight optimization of addr compare
On Sat, 2013-12-28 at 14:17 +0800, Ding Tianhong wrote: > Use possibly more efficient ether_addr_equal > to instead of memcmp. > > Cc: Jeff Kirsher > Cc: Jesse Brandeburg > Cc: Bruce Allan > Signed-off-by: Ding Tianhong > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Thanks Ding, I will update the patch in my queue with this updated version. signature.asc Description: This is a digitally signed message part
Re: [PATCH net-next v2 07/20] net: ixgbe: slight optimization of addr compare
On Sat, 2013-12-28 at 14:17 +0800, Ding Tianhong wrote: > Use possibly more efficient ether_addr_equal > to instead of memcmp. > > Cc: Jeff Kirsher > Cc: Jesse Brandeburg > Cc: Bruce Allan > Signed-off-by: Ding Tianhong > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Thanks Ding, I will update the patch in my queue with this updated version. signature.asc Description: This is a digitally signed message part
Re: [PATCH net-next v2 07/20] net: ixgbe: slight optimization of addr compare
On Sat, 2013-12-28 at 14:17 +0800, Ding Tianhong wrote: Use possibly more efficient ether_addr_equal to instead of memcmp. Cc: Jeff Kirsher jeffrey.t.kirs...@intel.com Cc: Jesse Brandeburg jesse.brandeb...@intel.com Cc: Bruce Allan bruce.w.al...@intel.com Signed-off-by: Ding Tianhong dingtianh...@huawei.com --- drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Thanks Ding, I will update the patch in my queue with this updated version. signature.asc Description: This is a digitally signed message part
Re: [PATCH net-next v2 07/20] net: ixgbe: slight optimization of addr compare
On Sat, 2013-12-28 at 14:17 +0800, Ding Tianhong wrote: Use possibly more efficient ether_addr_equal to instead of memcmp. Cc: Jeff Kirsher jeffrey.t.kirs...@intel.com Cc: Jesse Brandeburg jesse.brandeb...@intel.com Cc: Bruce Allan bruce.w.al...@intel.com Signed-off-by: Ding Tianhong dingtianh...@huawei.com --- drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Thanks Ding, I will update the patch in my queue with this updated version. signature.asc Description: This is a digitally signed message part
[PATCH net-next v2 07/20] net: ixgbe: slight optimization of addr compare
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Jeff Kirsher
Cc: Jesse Brandeburg
Cc: Bruce Allan
Signed-off-by: Ding Tianhong
---
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
index d6f0c0d..9ce07f3 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
@@ -715,8 +715,7 @@ static int ixgbe_set_vf_mac_addr(struct ixgbe_adapter
*adapter,
}
if (adapter->vfinfo[vf].pf_set_mac &&
- memcmp(adapter->vfinfo[vf].vf_mac_addresses, new_mac,
- ETH_ALEN)) {
+ !ether_addr_equal(adapter->vfinfo[vf].vf_mac_addresses, new_mac)) {
e_warn(drv,
"VF %d attempted to override administratively set MAC
address\n"
"Reload the VF driver to resume operations\n",
--
1.8.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH net-next v2 07/20] net: ixgbe: slight optimization of addr compare
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Jeff Kirsher jeffrey.t.kirs...@intel.com
Cc: Jesse Brandeburg jesse.brandeb...@intel.com
Cc: Bruce Allan bruce.w.al...@intel.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
index d6f0c0d..9ce07f3 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
@@ -715,8 +715,7 @@ static int ixgbe_set_vf_mac_addr(struct ixgbe_adapter
*adapter,
}
if (adapter-vfinfo[vf].pf_set_mac
- memcmp(adapter-vfinfo[vf].vf_mac_addresses, new_mac,
- ETH_ALEN)) {
+ !ether_addr_equal(adapter-vfinfo[vf].vf_mac_addresses, new_mac)) {
e_warn(drv,
VF %d attempted to override administratively set MAC
address\n
Reload the VF driver to resume operations\n,
--
1.8.0
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
