Re: [PATCH net-next v3 0/7] vmxnet3: upgrade to version 3

[David Miller]

From: Shrikrishna Khare 
Date: Mon, 13 Jun 2016 18:50:00 -0700

> This patchset upgrades vmxnet3 to version 3.

As stated by others, it is completely unacceptable to post so many
patches with little or no commit log message.

You must describe, in full detail, what each and every patch does, why
it is doing so, and how it is doing it.

Re: [PATCH net-next v3 0/7] vmxnet3: upgrade to version 3

[David Miller]

From: Shrikrishna Khare 
Date: Mon, 13 Jun 2016 18:50:00 -0700

> This patchset upgrades vmxnet3 to version 3.

As stated by others, it is completely unacceptable to post so many
patches with little or no commit log message.

You must describe, in full detail, what each and every patch does, why
it is doing so, and how it is doing it.

Re: [PATCH net-next v3 0/7] vmxnet3: upgrade to version 3

[Or Gerlitz]

On Tue, Jun 14, 2016 at 4:50 AM, Shrikrishna Khare  wrote:
> This patchset upgrades vmxnet3 to version 3.

Except for one patch, all the rest lack change-log, which makes it
somehow needlessly harder to review and maintain

> Shrikrishna Khare (7):
>   vmxnet3: prepare for version 3 changes
>   vmxnet3: introduce generic command interface to configure the device
>   vmxnet3: allow variable length transmit data ring buffer
>   vmxnet3: add receive data ring support
>   vmxnet3: add support for get_coalesce, set_coalesce ethtool operations
>   vmxnet3: introduce command to register memory region
>   vmxnet3: update to version 3

Re: [PATCH net-next v3 0/7] vmxnet3: upgrade to version 3

[Or Gerlitz]

On Tue, Jun 14, 2016 at 4:50 AM, Shrikrishna Khare  wrote:
> This patchset upgrades vmxnet3 to version 3.

Except for one patch, all the rest lack change-log, which makes it
somehow needlessly harder to review and maintain

> Shrikrishna Khare (7):
>   vmxnet3: prepare for version 3 changes
>   vmxnet3: introduce generic command interface to configure the device
>   vmxnet3: allow variable length transmit data ring buffer
>   vmxnet3: add receive data ring support
>   vmxnet3: add support for get_coalesce, set_coalesce ethtool operations
>   vmxnet3: introduce command to register memory region
>   vmxnet3: update to version 3

[PATCH net-next v3 0/7] vmxnet3: upgrade to version 3

[Shrikrishna Khare]

This patchset upgrades vmxnet3 to version 3.

Changes in v2:
 - Following patch is updated. See that patch for details:
   Driver: Vmxnet3: Add support for get_coalesce, set_coalesce ethtool

Changes in v3:
 - fix subject line to use vmxnet3: instead of Driver:Vmxnet3
 - resubmit when net-next is open


Shrikrishna Khare (7):
  vmxnet3: prepare for version 3 changes
  vmxnet3: introduce generic command interface to configure the device
  vmxnet3: allow variable length transmit data ring buffer
  vmxnet3: add receive data ring support
  vmxnet3: add support for get_coalesce, set_coalesce ethtool operations
  vmxnet3: introduce command to register memory region
  vmxnet3: update to version 3

 drivers/net/vmxnet3/Makefile  |   4 +-
 drivers/net/vmxnet3/upt1_defs.h   |   4 +-
 drivers/net/vmxnet3/vmxnet3_defs.h| 105 -
 drivers/net/vmxnet3/vmxnet3_drv.c | 285 --
 drivers/net/vmxnet3/vmxnet3_ethtool.c | 217 --
 drivers/net/vmxnet3/vmxnet3_int.h |  54 ++-
 6 files changed, 587 insertions(+), 82 deletions(-)

-- 
2.8.2

[PATCH net-next v3 0/7] vmxnet3: upgrade to version 3

[Shrikrishna Khare]

This patchset upgrades vmxnet3 to version 3.

Changes in v2:
 - Following patch is updated. See that patch for details:
   Driver: Vmxnet3: Add support for get_coalesce, set_coalesce ethtool

Changes in v3:
 - fix subject line to use vmxnet3: instead of Driver:Vmxnet3
 - resubmit when net-next is open


Shrikrishna Khare (7):
  vmxnet3: prepare for version 3 changes
  vmxnet3: introduce generic command interface to configure the device
  vmxnet3: allow variable length transmit data ring buffer
  vmxnet3: add receive data ring support
  vmxnet3: add support for get_coalesce, set_coalesce ethtool operations
  vmxnet3: introduce command to register memory region
  vmxnet3: update to version 3

 drivers/net/vmxnet3/Makefile  |   4 +-
 drivers/net/vmxnet3/upt1_defs.h   |   4 +-
 drivers/net/vmxnet3/vmxnet3_defs.h| 105 -
 drivers/net/vmxnet3/vmxnet3_drv.c | 285 --
 drivers/net/vmxnet3/vmxnet3_ethtool.c | 217 --
 drivers/net/vmxnet3/vmxnet3_int.h |  54 ++-
 6 files changed, 587 insertions(+), 82 deletions(-)

-- 
2.8.2