Re: [PATCH net v2 0/3] net/smc: move some definitions to UAPI
From: Ursula Braun Date: Wed, 25 Sep 2019 14:10:05 +0200 > we have to admit that it is already late for these patches. Nevertheless > we think it is better to come up with them now than never. We doubt there > exists already much userland code for it - except our own IBM-provided > package smc-tools. Thus we appreciate acceptance of these patches. Ursula, it's going to break the build of userland code. I consider that unacceptable.
Re: [PATCH net v2 0/3] net/smc: move some definitions to UAPI
On 9/24/19 4:52 PM, David Miller wrote: > From: Eugene Syromiatnikov > Date: Fri, 20 Sep 2019 17:41:47 +0200 > >> As of now, it's a bit difficult to use SMC protocol, as significant part >> of definitions related to it are defined in private headers and are not >> part of UAPI. The following commits move some definitions to UAPI, >> making them readily available to the user space. >> >> Changes since v1[1]: >> * Patch "provide fallback diagnostic codes in UAPI" is updated >>in accordance with the updated set of diagnostic codes. >> >> [1] https://lkml.org/lkml/2018/10/7/177 > > Isn't it way too late for this? > > These definitions will now be duplicates for userland code that > defines the values on their own. > Dave, we have to admit that it is already late for these patches. Nevertheless we think it is better to come up with them now than never. We doubt there exists already much userland code for it - except our own IBM-provided package smc-tools. Thus we appreciate acceptance of these patches. Kind regards, Ursula
Re: [PATCH net v2 0/3] net/smc: move some definitions to UAPI
From: Eugene Syromiatnikov Date: Fri, 20 Sep 2019 17:41:47 +0200 > As of now, it's a bit difficult to use SMC protocol, as significant part > of definitions related to it are defined in private headers and are not > part of UAPI. The following commits move some definitions to UAPI, > making them readily available to the user space. > > Changes since v1[1]: > * Patch "provide fallback diagnostic codes in UAPI" is updated >in accordance with the updated set of diagnostic codes. > > [1] https://lkml.org/lkml/2018/10/7/177 Isn't it way too late for this? These definitions will now be duplicates for userland code that defines the values on their own.
Re: [PATCH net v2 0/3] net/smc: move some definitions to UAPI
On 9/20/19 5:41 PM, Eugene Syromiatnikov wrote: > Hello. > > As of now, it's a bit difficult to use SMC protocol, as significant part > of definitions related to it are defined in private headers and are not > part of UAPI. The following commits move some definitions to UAPI, > making them readily available to the user space. > > Changes since v1[1]: > * Patch "provide fallback diagnostic codes in UAPI" is updated >in accordance with the updated set of diagnostic codes. > > [1] https://lkml.org/lkml/2018/10/7/177 > Thanks Eugene, your patches look good. They will be part of our next SMC patch submission for the net-next tree. Regards, Ursula > Eugene Syromiatnikov (3): > uapi, net/smc: move protocol constant definitions to UAPI > uapi, net/smc: provide fallback diagnostic codes in UAPI > uapi, net/smc: provide socket state constants in UAPI > > include/uapi/linux/smc.h | 32 +++- > include/uapi/linux/smc_diag.h | 17 + > net/smc/smc.h | 22 ++ > net/smc/smc_clc.h | 22 -- > 4 files changed, 50 insertions(+), 43 deletions(-) >
[PATCH net v2 0/3] net/smc: move some definitions to UAPI
Hello. As of now, it's a bit difficult to use SMC protocol, as significant part of definitions related to it are defined in private headers and are not part of UAPI. The following commits move some definitions to UAPI, making them readily available to the user space. Changes since v1[1]: * Patch "provide fallback diagnostic codes in UAPI" is updated in accordance with the updated set of diagnostic codes. [1] https://lkml.org/lkml/2018/10/7/177 Eugene Syromiatnikov (3): uapi, net/smc: move protocol constant definitions to UAPI uapi, net/smc: provide fallback diagnostic codes in UAPI uapi, net/smc: provide socket state constants in UAPI include/uapi/linux/smc.h | 32 +++- include/uapi/linux/smc_diag.h | 17 + net/smc/smc.h | 22 ++ net/smc/smc_clc.h | 22 -- 4 files changed, 50 insertions(+), 43 deletions(-) -- 2.1.4
