Re: [PATCH tip/core/rcu 06/10] softirq: Don't try waking ksoftirqd before it has been spawned
On Fri, Mar 12, 2021 at 12:36:41PM +0100, Frederic Weisbecker wrote: > On Wed, Mar 03, 2021 at 04:00:15PM -0800, paul...@kernel.org wrote: > > From: "Paul E. McKenney" > > > > If there is heavy softirq activity, the softirq system will attempt > > to awaken ksoftirqd and will stop the traditional back-of-interrupt > > softirq processing. This is all well and good, but only if the > > ksoftirqd kthreads already exist, which is not the case during early > > boot, in which case the system hangs. > > > > One reproducer is as follows: > > > > tools/testing/selftests/rcutorture/bin/kvm.sh --allcpus --duration 2 > > --configs "TREE03" --kconfig "CONFIG_DEBUG_LOCK_ALLOC=y > > CONFIG_PROVE_LOCKING=y CONFIG_NO_HZ_IDLE=y CONFIG_HZ_PERIODIC=n" --bootargs > > "threadirqs=1" --trust-make > > > > This commit therefore adds a couple of existence checks for ksoftirqd > > and forces back-of-interrupt softirq processing when ksoftirqd does not > > yet exist. With this change, the above test passes. > > > > Reported-by: Sebastian Andrzej Siewior > > Reported-by: Uladzislau Rezki > > Cc: Peter Zijlstra > > Cc: Thomas Gleixner > > [ paulmck: Remove unneeded check per Sebastian Siewior feedback. ] > > Signed-off-by: Paul E. McKenney > > Reviewed-by: Frederic Weisbecker Applied, thank you! Thanx, Paul
Re: [PATCH tip/core/rcu 06/10] softirq: Don't try waking ksoftirqd before it has been spawned
On Wed, Mar 03, 2021 at 04:00:15PM -0800, paul...@kernel.org wrote: > From: "Paul E. McKenney" > > If there is heavy softirq activity, the softirq system will attempt > to awaken ksoftirqd and will stop the traditional back-of-interrupt > softirq processing. This is all well and good, but only if the > ksoftirqd kthreads already exist, which is not the case during early > boot, in which case the system hangs. > > One reproducer is as follows: > > tools/testing/selftests/rcutorture/bin/kvm.sh --allcpus --duration 2 > --configs "TREE03" --kconfig "CONFIG_DEBUG_LOCK_ALLOC=y > CONFIG_PROVE_LOCKING=y CONFIG_NO_HZ_IDLE=y CONFIG_HZ_PERIODIC=n" --bootargs > "threadirqs=1" --trust-make > > This commit therefore adds a couple of existence checks for ksoftirqd > and forces back-of-interrupt softirq processing when ksoftirqd does not > yet exist. With this change, the above test passes. > > Reported-by: Sebastian Andrzej Siewior > Reported-by: Uladzislau Rezki > Cc: Peter Zijlstra > Cc: Thomas Gleixner > [ paulmck: Remove unneeded check per Sebastian Siewior feedback. ] > Signed-off-by: Paul E. McKenney Reviewed-by: Frederic Weisbecker
[PATCH tip/core/rcu 06/10] softirq: Don't try waking ksoftirqd before it has been spawned
From: "Paul E. McKenney"
If there is heavy softirq activity, the softirq system will attempt
to awaken ksoftirqd and will stop the traditional back-of-interrupt
softirq processing. This is all well and good, but only if the
ksoftirqd kthreads already exist, which is not the case during early
boot, in which case the system hangs.
One reproducer is as follows:
tools/testing/selftests/rcutorture/bin/kvm.sh --allcpus --duration 2 --configs
"TREE03" --kconfig "CONFIG_DEBUG_LOCK_ALLOC=y CONFIG_PROVE_LOCKING=y
CONFIG_NO_HZ_IDLE=y CONFIG_HZ_PERIODIC=n" --bootargs "threadirqs=1" --trust-make
This commit therefore adds a couple of existence checks for ksoftirqd
and forces back-of-interrupt softirq processing when ksoftirqd does not
yet exist. With this change, the above test passes.
Reported-by: Sebastian Andrzej Siewior
Reported-by: Uladzislau Rezki
Cc: Peter Zijlstra
Cc: Thomas Gleixner
[ paulmck: Remove unneeded check per Sebastian Siewior feedback. ]
Signed-off-by: Paul E. McKenney
---
kernel/softirq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 9908ec4a..bad14ca 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -211,7 +211,7 @@ static inline void invoke_softirq(void)
if (ksoftirqd_running(local_softirq_pending()))
return;
- if (!force_irqthreads) {
+ if (!force_irqthreads || !__this_cpu_read(ksoftirqd)) {
#ifdef CONFIG_HAVE_IRQ_EXIT_ON_IRQ_STACK
/*
* We can safely execute softirq on the current stack if
--
2.9.5
