RE: [PATCH v1] ARM64: dts: imx8mp: correct sdma1 clk setting

[Robin Gong]

On 2020/08/31 19:12 Fabio Estevam  wrote: 
> Hi Robin,
> 
> On Mon, Aug 31, 2020 at 6:22 AM Robin Gong  wrote:
> >
> > Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so
> > that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3
> > use 1:1.
> >
> > Signed-off-by: Robin Gong 
> 
> Please add a Fixes tag.
Resent with tags, thanks.

Re: [PATCH v1] ARM64: dts: imx8mp: correct sdma1 clk setting

[Fabio Estevam]

Hi Robin,

On Mon, Aug 31, 2020 at 6:22 AM Robin Gong  wrote:
>
> Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so
> that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3 use
> 1:1.
>
> Signed-off-by: Robin Gong 

Please add a Fixes tag.

Thanks

[PATCH v1] ARM64: dts: imx8mp: correct sdma1 clk setting

[Robin Gong]

Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so
that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3 use
1:1.

Signed-off-by: Robin Gong 
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi 
b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index cad2dd7..6038f66 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -702,7 +702,7 @@
reg = <0x30bd 0x1>;
interrupts = ;
clocks = < IMX8MP_CLK_SDMA1_ROOT>,
-< IMX8MP_CLK_SDMA1_ROOT>;
+< IMX8MP_CLK_AHB>;
clock-names = "ipg", "ahb";
#dma-cells = <3>;
fsl,sdma-ram-script-name = 
"imx/sdma/sdma-imx7d.bin";
-- 
2.7.4